Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: contract eth_call bug and made some improvements #5785

Merged
merged 5 commits into from
Jul 24, 2023
Merged

fix: contract eth_call bug and made some improvements #5785

merged 5 commits into from
Jul 24, 2023

Conversation

nazarhussain
Copy link
Contributor

Motivation

Use the @lodestar/prover in an existing project.

Description

  • Fix a bug in eth_call to mix the transaction id in batch request
  • Made some improvements on few places
  • Made the exports works with the webpack.

Steps to test or reproduce

Run all tests.

@nazarhussain nazarhussain requested a review from a team as a code owner July 21, 2023 16:38
@nazarhussain nazarhussain self-assigned this Jul 21, 2023
@nazarhussain nazarhussain changed the title fix: fix contract eth_call bug and made some improvements fix: contract eth_call bug and made some improvements Jul 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023 •
edited

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 4ab6050 Previous: 7f19831 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 520.55 us/op 648.81 us/op 0.80
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 77.486 us/op 88.163 us/op 0.88
BLS verify - blst-native 1.2754 ms/op 1.2315 ms/op 1.04
BLS verifyMultipleSignatures 3 - blst-native 2.5956 ms/op 2.5311 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 5.5676 ms/op 5.4233 ms/op 1.03
BLS verifyMultipleSignatures 32 - blst-native 20.278 ms/op 19.698 ms/op 1.03
BLS aggregatePubkeys 32 - blst-native 26.594 us/op 26.289 us/op 1.01
BLS aggregatePubkeys 128 - blst-native 104.22 us/op 102.48 us/op 1.02
getAttestationsForBlock 57.961 ms/op 62.156 ms/op 0.93
isKnown best case - 1 super set check 326.00 ns/op 427.00 ns/op 0.76
isKnown normal case - 2 super set checks 316.00 ns/op 456.00 ns/op 0.69
isKnown worse case - 16 super set checks 304.00 ns/op 458.00 ns/op 0.66
CheckpointStateCache - add get delete 5.3720 us/op 5.8400 us/op 0.92
validate api signedAggregateAndProof - struct 2.8562 ms/op 2.8600 ms/op 1.00
validate gossip signedAggregateAndProof - struct 2.8700 ms/op 2.8956 ms/op 0.99
validate api attestation - struct 1.3692 ms/op 1.3560 ms/op 1.01
validate gossip attestation - struct 1.3747 ms/op 1.3723 ms/op 1.00
pickEth1Vote - no votes 1.2722 ms/op 1.2891 ms/op 0.99
pickEth1Vote - max votes 11.740 ms/op 10.757 ms/op 1.09
pickEth1Vote - Eth1Data hashTreeRoot value x2048 9.4288 ms/op 9.2731 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 14.934 ms/op 15.723 ms/op 0.95
pickEth1Vote - Eth1Data fastSerialize value x2048 672.82 us/op 701.00 us/op 0.96
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.7610 ms/op 6.9281 ms/op 0.69
bytes32 toHexString 533.00 ns/op 657.00 ns/op 0.81
bytes32 Buffer.toString(hex) 312.00 ns/op 333.00 ns/op 0.94
bytes32 Buffer.toString(hex) from Uint8Array 508.00 ns/op 540.00 ns/op 0.94
bytes32 Buffer.toString(hex) + 0x 330.00 ns/op 320.00 ns/op 1.03
Object access 1 prop 0.17800 ns/op 0.20300 ns/op 0.88
Map access 1 prop 0.15300 ns/op 0.15600 ns/op 0.98
Object get x1000 8.0480 ns/op 7.1950 ns/op 1.12
Map get x1000 0.69800 ns/op 0.59600 ns/op 1.17
Object set x1000 60.197 ns/op 64.225 ns/op 0.94
Map set x1000 44.798 ns/op 47.892 ns/op 0.94
Return object 10000 times 0.25120 ns/op 0.24780 ns/op 1.01
Throw Error 10000 times 3.9466 us/op 3.9906 us/op 0.99
fastMsgIdFn sha256 / 200 bytes 3.5350 us/op 3.3810 us/op 1.05
fastMsgIdFn h32 xxhash / 200 bytes 335.00 ns/op 339.00 ns/op 0.99
fastMsgIdFn h64 xxhash / 200 bytes 378.00 ns/op 402.00 ns/op 0.94
fastMsgIdFn sha256 / 1000 bytes 12.024 us/op 11.700 us/op 1.03
fastMsgIdFn h32 xxhash / 1000 bytes 483.00 ns/op 498.00 ns/op 0.97
fastMsgIdFn h64 xxhash / 1000 bytes 470.00 ns/op 480.00 ns/op 0.98
fastMsgIdFn sha256 / 10000 bytes 107.36 us/op 106.03 us/op 1.01
fastMsgIdFn h32 xxhash / 10000 bytes 2.0090 us/op 2.0210 us/op 0.99
fastMsgIdFn h64 xxhash / 10000 bytes 1.3820 us/op 1.4520 us/op 0.95
enrSubnets - fastDeserialize 64 bits 1.3320 us/op 1.6710 us/op 0.80
enrSubnets - ssz BitVector 64 bits 469.00 ns/op 540.00 ns/op 0.87
enrSubnets - fastDeserialize 4 bits 195.00 ns/op 223.00 ns/op 0.87
enrSubnets - ssz BitVector 4 bits 478.00 ns/op 561.00 ns/op 0.85
prioritizePeers score -10:0 att 32-0.1 sync 2-0 114.73 us/op 119.58 us/op 0.96
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 151.31 us/op 148.53 us/op 1.02
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 182.13 us/op 199.63 us/op 0.91
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 319.64 us/op 351.65 us/op 0.91
prioritizePeers score 0:0 att 64-1 sync 4-1 362.59 us/op 381.99 us/op 0.95
array of 16000 items push then shift 1.6179 us/op 1.6250 us/op 1.00
LinkedList of 16000 items push then shift 9.1000 ns/op 9.9780 ns/op 0.91
array of 16000 items push then pop 56.856 ns/op 63.421 ns/op 0.90
LinkedList of 16000 items push then pop 8.9350 ns/op 9.3200 ns/op 0.96
array of 24000 items push then shift 2.4834 us/op 2.4991 us/op 0.99
LinkedList of 24000 items push then shift 9.4790 ns/op 10.104 ns/op 0.94
array of 24000 items push then pop 116.85 ns/op 118.83 ns/op 0.98
LinkedList of 24000 items push then pop 9.1590 ns/op 9.2680 ns/op 0.99
intersect bitArray bitLen 8 7.2090 ns/op 6.9630 ns/op 1.04
intersect array and set length 8 63.712 ns/op 73.848 ns/op 0.86
intersect bitArray bitLen 128 33.377 ns/op 32.655 ns/op 1.02
intersect array and set length 128 876.66 ns/op 816.62 ns/op 1.07
bitArray.getTrueBitIndexes() bitLen 128 1.7440 us/op 1.7080 us/op 1.02
bitArray.getTrueBitIndexes() bitLen 248 2.9630 us/op 2.6520 us/op 1.12
bitArray.getTrueBitIndexes() bitLen 512 5.4760 us/op 5.7550 us/op 0.95
Buffer.concat 32 items 1.0190 us/op 1.1550 us/op 0.88
Uint8Array.set 32 items 1.8110 us/op 2.1660 us/op 0.84
transfer serialized Status (84 B) 1.8400 us/op 1.9890 us/op 0.93
copy serialized Status (84 B) 1.5950 us/op 1.7560 us/op 0.91
transfer serialized SignedVoluntaryExit (112 B) 1.9400 us/op 2.1010 us/op 0.92
copy serialized SignedVoluntaryExit (112 B) 1.6260 us/op 1.8270 us/op 0.89
transfer serialized ProposerSlashing (416 B) 2.5140 us/op 2.3420 us/op 1.07
copy serialized ProposerSlashing (416 B) 2.9370 us/op 2.1840 us/op 1.34
transfer serialized Attestation (485 B) 3.2250 us/op 2.3190 us/op 1.39
copy serialized Attestation (485 B) 2.7770 us/op 2.2880 us/op 1.21
transfer serialized AttesterSlashing (33232 B) 2.8680 us/op 2.3810 us/op 1.20
copy serialized AttesterSlashing (33232 B) 7.0890 us/op 6.8560 us/op 1.03
transfer serialized Small SignedBeaconBlock (128000 B) 2.9200 us/op 2.5030 us/op 1.17
copy serialized Small SignedBeaconBlock (128000 B) 18.237 us/op 16.193 us/op 1.13
transfer serialized Avg SignedBeaconBlock (200000 B) 3.1880 us/op 3.0740 us/op 1.04
copy serialized Avg SignedBeaconBlock (200000 B) 25.380 us/op 31.245 us/op 0.81
transfer serialized BlobsSidecar (524380 B) 3.1870 us/op 3.6490 us/op 0.87
copy serialized BlobsSidecar (524380 B) 86.247 us/op 127.44 us/op 0.68
transfer serialized Big SignedBeaconBlock (1000000 B) 3.4090 us/op 4.2030 us/op 0.81
copy serialized Big SignedBeaconBlock (1000000 B) 176.73 us/op 200.65 us/op 0.88
pass gossip attestations to forkchoice per slot 2.2974 ms/op 2.1963 ms/op 1.05
forkChoice updateHead vc 100000 bc 64 eq 0 2.2397 ms/op 2.3912 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 0 13.986 ms/op 14.583 ms/op 0.96
forkChoice updateHead vc 1000000 bc 64 eq 0 23.739 ms/op 24.672 ms/op 0.96
forkChoice updateHead vc 600000 bc 320 eq 0 17.672 ms/op 17.512 ms/op 1.01
forkChoice updateHead vc 600000 bc 1200 eq 0 94.594 ms/op 96.171 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 1000 23.373 ms/op 22.233 ms/op 1.05
forkChoice updateHead vc 600000 bc 64 eq 10000 25.629 ms/op 24.227 ms/op 1.06
forkChoice updateHead vc 600000 bc 64 eq 300000 38.794 ms/op 35.331 ms/op 1.10
computeDeltas 3.1586 ms/op 3.3481 ms/op 0.94
computeProposerBoostScoreFromBalances 401.25 us/op 402.57 us/op 1.00
altair processAttestation - 250000 vs - 7PWei normalcase 2.9399 ms/op 2.7825 ms/op 1.06
altair processAttestation - 250000 vs - 7PWei worstcase 3.8758 ms/op 4.0659 ms/op 0.95
altair processAttestation - setStatus - 1/6 committees join 206.90 us/op 194.59 us/op 1.06
altair processAttestation - setStatus - 1/3 committees join 390.31 us/op 367.70 us/op 1.06
altair processAttestation - setStatus - 1/2 committees join 533.96 us/op 473.96 us/op 1.13
altair processAttestation - setStatus - 2/3 committees join 653.05 us/op 600.97 us/op 1.09
altair processAttestation - setStatus - 4/5 committees join 928.58 us/op 837.51 us/op 1.11
altair processAttestation - setStatus - 100% committees join 1.1083 ms/op 953.16 us/op 1.16
altair processBlock - 250000 vs - 7PWei normalcase 10.312 ms/op 10.669 ms/op 0.97
altair processBlock - 250000 vs - 7PWei normalcase hashState 17.822 ms/op 19.461 ms/op 0.92
altair processBlock - 250000 vs - 7PWei worstcase 38.634 ms/op 43.619 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase hashState 59.593 ms/op 64.037 ms/op 0.93
phase0 processBlock - 250000 vs - 7PWei normalcase 2.4189 ms/op 2.9978 ms/op 0.81
phase0 processBlock - 250000 vs - 7PWei worstcase 31.315 ms/op 34.463 ms/op 0.91
altair processEth1Data - 250000 vs - 7PWei normalcase 631.34 us/op 709.73 us/op 0.89
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 14.150 us/op 21.492 us/op 0.66
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 62.394 us/op 98.449 us/op 0.63
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 18.560 us/op 33.037 us/op 0.56
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.5240 us/op 11.820 us/op 0.81
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 167.90 us/op 191.69 us/op 0.88
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.4466 ms/op 1.3103 ms/op 1.10
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.8676 ms/op 1.6701 ms/op 1.12
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.9302 ms/op 1.9476 ms/op 0.99
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.8029 ms/op 4.2596 ms/op 0.89
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.5994 ms/op 2.6409 ms/op 0.98
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.9403 ms/op 5.8096 ms/op 1.02
Tree 40 250000 create 385.41 ms/op 385.49 ms/op 1.00
Tree 40 250000 get(125000) 212.96 ns/op 208.31 ns/op 1.02
Tree 40 250000 set(125000) 1.0059 us/op 1.0376 us/op 0.97
Tree 40 250000 toArray() 23.587 ms/op 22.637 ms/op 1.04
Tree 40 250000 iterate all - toArray() + loop 24.050 ms/op 21.902 ms/op 1.10
Tree 40 250000 iterate all - get(i) 75.903 ms/op 74.658 ms/op 1.02
MutableVector 250000 create 12.223 ms/op 13.169 ms/op 0.93
MutableVector 250000 get(125000) 6.6970 ns/op 6.6620 ns/op 1.01
MutableVector 250000 set(125000) 311.64 ns/op 299.44 ns/op 1.04
MutableVector 250000 toArray() 3.7574 ms/op 4.0980 ms/op 0.92
MutableVector 250000 iterate all - toArray() + loop 3.5677 ms/op 4.1179 ms/op 0.87
MutableVector 250000 iterate all - get(i) 1.6007 ms/op 1.5742 ms/op 1.02
Array 250000 create 3.3258 ms/op 3.9793 ms/op 0.84
Array 250000 clone - spread 1.1202 ms/op 1.2580 ms/op 0.89
Array 250000 get(125000) 0.52200 ns/op 0.63300 ns/op 0.82
Array 250000 set(125000) 0.59700 ns/op 0.70700 ns/op 0.84
Array 250000 iterate all - loop 85.525 us/op 84.032 us/op 1.02
effectiveBalanceIncrements clone Uint8Array 300000 27.999 us/op 49.960 us/op 0.56
effectiveBalanceIncrements clone MutableVector 300000 281.00 ns/op 382.00 ns/op 0.74
effectiveBalanceIncrements rw all Uint8Array 300000 184.13 us/op 181.12 us/op 1.02
effectiveBalanceIncrements rw all MutableVector 300000 80.965 ms/op 89.623 ms/op 0.90
phase0 afterProcessEpoch - 250000 vs - 7PWei 121.59 ms/op 117.52 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 42.247 ms/op 37.811 ms/op 1.12
altair processEpoch - mainnet_e81889 339.54 ms/op 329.92 ms/op 1.03
mainnet_e81889 - altair beforeProcessEpoch 66.595 ms/op 60.937 ms/op 1.09
mainnet_e81889 - altair processJustificationAndFinalization 16.927 us/op 15.427 us/op 1.10
mainnet_e81889 - altair processInactivityUpdates 6.0857 ms/op 6.0176 ms/op 1.01
mainnet_e81889 - altair processRewardsAndPenalties 71.246 ms/op 63.764 ms/op 1.12
mainnet_e81889 - altair processRegistryUpdates 2.8650 us/op 2.5500 us/op 1.12
mainnet_e81889 - altair processSlashings 830.00 ns/op 377.00 ns/op 2.20
mainnet_e81889 - altair processEth1DataReset 818.00 ns/op 455.00 ns/op 1.80
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3111 ms/op 1.2654 ms/op 1.04
mainnet_e81889 - altair processSlashingsReset 4.3020 us/op 4.0580 us/op 1.06
mainnet_e81889 - altair processRandaoMixesReset 7.6270 us/op 9.3240 us/op 0.82
mainnet_e81889 - altair processHistoricalRootsUpdate 1.8490 us/op 1.2330 us/op 1.50
mainnet_e81889 - altair processParticipationFlagUpdates 2.5330 us/op 1.8320 us/op 1.38
mainnet_e81889 - altair processSyncCommitteeUpdates 641.00 ns/op 546.00 ns/op 1.17
mainnet_e81889 - altair afterProcessEpoch 131.06 ms/op 124.43 ms/op 1.05
phase0 processEpoch - mainnet_e58758 373.95 ms/op 354.93 ms/op 1.05
mainnet_e58758 - phase0 beforeProcessEpoch 157.90 ms/op 129.06 ms/op 1.22
mainnet_e58758 - phase0 processJustificationAndFinalization 19.298 us/op 14.736 us/op 1.31
mainnet_e58758 - phase0 processRewardsAndPenalties 66.184 ms/op 65.700 ms/op 1.01
mainnet_e58758 - phase0 processRegistryUpdates 14.759 us/op 9.6580 us/op 1.53
mainnet_e58758 - phase0 processSlashings 694.00 ns/op 485.00 ns/op 1.43
mainnet_e58758 - phase0 processEth1DataReset 611.00 ns/op 511.00 ns/op 1.20
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.2021 ms/op 1.3709 ms/op 0.88
mainnet_e58758 - phase0 processSlashingsReset 3.4640 us/op 2.0300 us/op 1.71
mainnet_e58758 - phase0 processRandaoMixesReset 5.7610 us/op 3.9500 us/op 1.46
mainnet_e58758 - phase0 processHistoricalRootsUpdate 838.00 ns/op 574.00 ns/op 1.46
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.4720 us/op 3.8760 us/op 1.15
mainnet_e58758 - phase0 afterProcessEpoch 111.52 ms/op 99.561 ms/op 1.12
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.4544 ms/op 1.2498 ms/op 1.16
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.5097 ms/op 1.6207 ms/op 0.93
altair processInactivityUpdates - 250000 normalcase 26.382 ms/op 24.028 ms/op 1.10
altair processInactivityUpdates - 250000 worstcase 27.774 ms/op 23.515 ms/op 1.18
phase0 processRegistryUpdates - 250000 normalcase 10.403 us/op 9.9600 us/op 1.04
phase0 processRegistryUpdates - 250000 badcase_full_deposits 379.68 us/op 346.13 us/op 1.10
phase0 processRegistryUpdates - 250000 worstcase 0.5 153.77 ms/op 109.93 ms/op 1.40
altair processRewardsAndPenalties - 250000 normalcase 75.009 ms/op 67.624 ms/op 1.11
altair processRewardsAndPenalties - 250000 worstcase 73.213 ms/op 69.796 ms/op 1.05
phase0 getAttestationDeltas - 250000 normalcase 9.5961 ms/op 7.9209 ms/op 1.21
phase0 getAttestationDeltas - 250000 worstcase 9.4408 ms/op 7.7559 ms/op 1.22
phase0 processSlashings - 250000 worstcase 2.6300 ms/op 2.4365 ms/op 1.08
altair processSyncCommitteeUpdates - 250000 169.19 ms/op 159.46 ms/op 1.06
BeaconState.hashTreeRoot - No change 308.00 ns/op 250.00 ns/op 1.23
BeaconState.hashTreeRoot - 1 full validator 58.907 us/op 51.594 us/op 1.14
BeaconState.hashTreeRoot - 32 full validator 644.34 us/op 520.30 us/op 1.24
BeaconState.hashTreeRoot - 512 full validator 7.5052 ms/op 5.6523 ms/op 1.33
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 67.800 us/op 66.851 us/op 1.01
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.0419 ms/op 878.94 us/op 1.19
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 17.071 ms/op 11.213 ms/op 1.52
BeaconState.hashTreeRoot - 1 balances 54.624 us/op 51.621 us/op 1.06
BeaconState.hashTreeRoot - 32 balances 591.88 us/op 488.94 us/op 1.21
BeaconState.hashTreeRoot - 512 balances 5.7263 ms/op 4.7028 ms/op 1.22
BeaconState.hashTreeRoot - 250000 balances 88.489 ms/op 75.138 ms/op 1.18
aggregationBits - 2048 els - zipIndexesInBitList 26.894 us/op 14.858 us/op 1.81
regular array get 100000 times 51.747 us/op 33.145 us/op 1.56
wrappedArray get 100000 times 46.942 us/op 33.175 us/op 1.41
arrayWithProxy get 100000 times 21.457 ms/op 16.630 ms/op 1.29
ssz.Root.equals 298.00 ns/op 212.00 ns/op 1.41
byteArrayEquals 283.00 ns/op 204.00 ns/op 1.39
shuffle list - 16384 els 8.0242 ms/op 7.0991 ms/op 1.13
shuffle list - 250000 els 118.39 ms/op 102.85 ms/op 1.15
processSlot - 1 slots 12.619 us/op 8.2880 us/op 1.52
processSlot - 32 slots 1.6428 ms/op 1.3175 ms/op 1.25
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 62.042 ms/op 54.772 ms/op 1.13
getCommitteeAssignments - req 1 vs - 250000 vc 2.6901 ms/op 2.5191 ms/op 1.07
getCommitteeAssignments - req 100 vs - 250000 vc 3.9184 ms/op 3.7137 ms/op 1.06
getCommitteeAssignments - req 1000 vs - 250000 vc 4.5095 ms/op 4.0995 ms/op 1.10
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.5500 ns/op 4.9200 ns/op 1.13
state getBlockRootAtSlot - 250000 vs - 7PWei 802.48 ns/op 910.21 ns/op 0.88
computeProposers - vc 250000 9.9967 ms/op 8.8613 ms/op 1.13
computeEpochShuffling - vc 250000 111.70 ms/op 105.67 ms/op 1.06
getNextSyncCommittee - vc 250000 168.54 ms/op 149.75 ms/op 1.13
computeSigningRoot for AttestationData 15.471 us/op 13.457 us/op 1.15
hash AttestationData serialized data then Buffer.toString(base64) 2.5543 us/op 2.3690 us/op 1.08
toHexString serialized data 1.3761 us/op 1.1473 us/op 1.20
Buffer.toString(base64) 286.20 ns/op 247.68 ns/op 1.16

by benchmarkbot/action

g11tech
g11tech previously approved these changes Jul 22, 2023
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

nazarhussain
nazarhussain commented Jul 24, 2023
View reviewed changes
packages/prover/package.json
Comment on lines +18 to +21
"import": "./lib/index.js"
},
"./browser": {
"import": "./lib/browser/index.js"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to make this chance, because conditional exports were not equally compatible with different libraries and tools.

Named exports on the other hand make it more easy for all web builders and tools.

@wemeetagain wemeetagain merged commit c0aa752 into unstable Jul 24, 2023
12 checks passed
@wemeetagain wemeetagain deleted the nh/prover-improvments branch July 24, 2023 16:54
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.10.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

@nflaig nflaig nflaig approved these changes

@g11tech g11tech g11tech left review comments

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nazarhussain @wemeetagain @nflaig @g11tech