-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update networking page #6289
Conversation
d2670de
to
a0591e7
Compare
a0591e7
to
9fe07d8
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
This comment was marked as off-topic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great idea to add this! Just a couple small comments
- 13000/TCP - Prysm P2P communication port | ||
- 12000/UDP - Prysm P2P communication port |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should not be removed or lodestar will have issue p2p communicating with Prysm. I get that these are Lodestar docs but we communicate with Prysm
https://docs.prylabs.network/docs/prysm-usage/p2p-host-ip#configure-your-firewall
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps they go in an "optional" section with a note so people know the issue exists.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lodestar will have issue p2p communicating with Prysm
This only concerns inbound ports, not outbound. I already mentioned that in the PR description, if you start speculating on what ports other nodes in the network are running on, you are fighting a losing battle.
Just an example, on dappnode Lodestar p2p port is configured to use 9512, same goes for other clients, they don't use default ports.
Maybe we should highlight that it is important to not block any outbound ports, but I felt like this is unnecessary as nobody does this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK makes sense. Maybe we can add a note in another PR that these are the defaults and that there are some extenuating circumstances that do not fall under these rules
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Matthew Keil <me@matthewkeil.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!! 🚀
* docs: update networking page * Update wordlist * Update port description * must instead of should * Apply feedback Co-authored-by: Matthew Keil <me@matthewkeil.com> * Why on startup, who cares * Add log exmaple --------- Co-authored-by: Matthew Keil <me@matthewkeil.com>
🎉 This PR is included in v1.15.0 🎉 |
* docs: update networking page * Update wordlist * Update port description * must instead of should * Apply feedback Co-authored-by: Matthew Keil <me@matthewkeil.com> * Why on startup, who cares * Add log exmaple --------- Co-authored-by: Matthew Keil <me@matthewkeil.com>
Motivation
There were several users already that asked about how to retrieve their ENR, hence i think it makes sense to explicitly mention this in our docs.
Also simplified ports a little bit, I think it's better to only talk about protecting incoming ports as users should not be concerned about outgoing ports, there is no reason to block any of those and if people do, they probably have a good reason for it and know what they are doing.
There is also no point in listing Prysm ports, those were only about outbound ports and there are plenty of setups that change the default 9000 p2p port to something else, e.g. rocketpool uses 9001. Listing them all does not make sense.
Description