fix: ignore already known errors in API #6321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
commented
Jan 17, 2024
| e instanceof SyncCommitteeError && | ||
| e.type.code === SyncCommitteeErrorCode.SYNC_COMMITTEE_AGGREGATOR_ALREADY_KNOWN | ||
| ) { | ||
| logger.debug("Ignoring known contributionAndProof", logCtx); |
There was a problem hiding this comment.
This error was already ignored previously (added in #2598) but it got removed again by #2816 as the PR changed the error behavior.
In #4019 it was introduced again that the error is thrown during validation but the handling on the API was not re-added.
The error was recently observed (#6021 (comment)) and should be ignored again.
| @@ -224,7 +234,7 @@ export function getBeaconPoolApi({ | |||
| ); | |||
|
|
|||
| if (errors.length > 1) { | |||
| throw Error("Multiple errors on publishAggregateAndProofs\n" + errors.map((e) => e.message).join("\n")); | |||
| throw Error("Multiple errors on submitPoolSyncCommitteeSignatures\n" + errors.map((e) => e.message).join("\n")); | |||
There was a problem hiding this comment.
This just fixes a typo but it is worth highlighting that we don't need to handle already known errors in submitPoolSyncCommitteeSignatures as the api only verifies the signature
lodestar/packages/beacon-node/src/api/impl/beacon/pool/index.ts
Lines 184 to 186 in d7ca290
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6321 +/- ##
=========================================
Coverage 76.52% 76.53%
=========================================
Files 248 248
Lines 25935 25943 +8
Branches 1449 1449
=========================================
+ Hits 19847 19855 +8
Misses 6058 6058
Partials 30 30 |
Performance Report✔️ no performance regression detected Full benchmark results
|
nflaig
commented
Jan 17, 2024
wemeetagain
approved these changes
Jan 17, 2024
ensi321
pushed a commit
to ensi321/lodestar
that referenced
this pull request
Jan 22, 2024
* Ignore known attestations submitted through API * Ignore known sync committee aggregate * Add log contex to ignored aggregate attestations * Fix typo in submitPoolSyncCommitteeSignatures
|
🎉 This PR is included in v1.15.0 🎉 |
jeluard
pushed a commit
to jeluard/lodestar
that referenced
this pull request
Jan 30, 2024
* Ignore known attestations submitted through API * Ignore known sync committee aggregate * Add log contex to ignored aggregate attestations * Fix typo in submitPoolSyncCommitteeSignatures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Attestations might already be published by another node as part of a fallback setup or DVT cluster
and can reach our node by gossip before the api. The error can be ignored and should not result in a 500 response.
There are also other errors related to that like known aggregates which should be ignored as well (see previous PR #2598)
Description
Ignore already known (
_ALREADY_KNOWN) errors in API and return 200 response.Closes #6021