feat: emit slashing events #6391
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
jeluard
force-pushed
the
jeluard/emit-slashing-events
branch
from
a9df592
to
b22e7ad
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6391 +/- ##
=========================================
Coverage 60.14% 60.14%
=========================================
Files 407 407
Lines 46512 46526 +14
Branches 1551 1551
=========================================
+ Hits 27975 27985 +10
- Misses 18505 18509 +4
Partials 32 32 |
wemeetagain
reviewed
Feb 7, 2024
nflaig
reviewed
Feb 7, 2024
| @@ -138,6 +138,70 @@ function runTests({useWorker}: {useWorker: boolean}): void { | |||
| ); | |||
| }); | |||
|
|
|||
| it("Publish and receive an attesterSlashing", async function () { | |||
There was a problem hiding this comment.
The amount of copy pasted code is quite high in this file, maybe something that could be improved in this PR (or later one) to make it easier to add new events in the future
There was a problem hiding this comment.
I would suggest to do that in a different PR for extra clarity.
Co-authored-by: Nico Flaig <nflaig@protonmail.com>
nflaig
approved these changes
Feb 8, 2024
nflaig
approved these changes
Feb 8, 2024
|
🎉 This PR is included in v1.16.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Add
proposer_slashingandattester_slashingto SSEDescription
Make sure new events introduced by ethereum/beacon-APIs#376 are now emitted and made available via SSE.
Closes #6209