New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: upgrade geth and nethermind for sim tests #6395
Conversation
Would it make sense to store those values so that they are reused by |
Performance Report✔️ no performance regression detected Full benchmark results
|
@@ -23,9 +23,9 @@ on: | |||
default: 40 | |||
|
|||
env: | |||
GETH_DOCKER_IMAGE: ethereum/client-go:v1.11.6 | |||
GETH_DOCKER_IMAGE: ethereum/client-go:v1.13.11 | |||
LIGHTHOUSE_DOCKER_IMAGE: sigp/lighthouse:latest-amd64-modern-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use a release version for lighthouse as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lighthosue releases does not build with minimal
preset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about sigp/lighthouse:v4.6.0-amd64-modern-dev, the -dev
suffix suggest it has minimal preset.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes the build with -dev
is the right one. Seems for latest releases they started the dev builds. I will update it shortly.
I think that is a good idea, we should make as easy as possible to run tests locally, also this PR did not update value in |
Reusability is always great. Will try to find better approach to share across scripts, workflows and local env. Probably an env file will work out. Will double check. |
🎉 This PR is included in v1.16.0 🎉 |
Motivation
Test compatibility with latest versions of all clients.
Description
Upgrade Geth and Nethermind for the sim tests.
Steps to test or reproduce