Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade geth and nethermind for sim tests #6395

Merged
merged 1 commit into from Feb 6, 2024

Conversation

nazarhussain
Copy link
Contributor

Motivation

Test compatibility with latest versions of all clients.

Description

Upgrade Geth and Nethermind for the sim tests.

Steps to test or reproduce

  • Run all tests

@nazarhussain nazarhussain requested a review from a team as a code owner February 6, 2024 10:10
@nazarhussain nazarhussain self-assigned this Feb 6, 2024
@jeluard
Copy link
Member

jeluard commented Feb 6, 2024

Would it make sense to store those values so that they are reused by e2e tests too? Right now they are also defined in test.yml and CONTRIBUTING.md.
It also forces users to provide those value manually when running scripts/run_e2e_env.sh.

Copy link
Contributor

github-actions bot commented Feb 6, 2024

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 35eabd4 Previous: c4bf385 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 624.85 us/op 625.13 us/op 1.00
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 155.61 us/op 56.537 us/op 2.75
BLS verify - blst-native 1.3719 ms/op 1.1082 ms/op 1.24
BLS verifyMultipleSignatures 3 - blst-native 2.8745 ms/op 2.3678 ms/op 1.21
BLS verifyMultipleSignatures 8 - blst-native 6.3905 ms/op 5.2280 ms/op 1.22
BLS verifyMultipleSignatures 32 - blst-native 23.576 ms/op 19.202 ms/op 1.23
BLS verifyMultipleSignatures 64 - blst-native 45.681 ms/op 37.817 ms/op 1.21
BLS verifyMultipleSignatures 128 - blst-native 91.030 ms/op 75.120 ms/op 1.21
BLS deserializing 10000 signatures 976.75 ms/op 808.20 ms/op 1.21
BLS deserializing 100000 signatures 9.3488 s/op 8.2632 s/op 1.13
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3813 ms/op 1.1466 ms/op 1.20
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5830 ms/op 1.2701 ms/op 1.25
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.7154 ms/op 2.0206 ms/op 1.34
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.8335 ms/op 4.1166 ms/op 0.93
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.2147 ms/op 5.0445 ms/op 1.23
BLS aggregatePubkeys 32 - blst-native 28.368 us/op 23.043 us/op 1.23
BLS aggregatePubkeys 128 - blst-native 106.42 us/op 89.845 us/op 1.18
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 77.248 ms/op 46.387 ms/op 1.67
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 61.692 ms/op 43.494 ms/op 1.42
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 56.146 ms/op 28.023 ms/op 2.00
getSlashingsAndExits - default max 369.74 us/op 134.50 us/op 2.75
getSlashingsAndExits - 2k 564.61 us/op 336.25 us/op 1.68
proposeBlockBody type=full, size=empty 6.3960 ms/op 4.1646 ms/op 1.54
isKnown best case - 1 super set check 580.00 ns/op 337.00 ns/op 1.72
isKnown normal case - 2 super set checks 628.00 ns/op 332.00 ns/op 1.89
isKnown worse case - 16 super set checks 626.00 ns/op 336.00 ns/op 1.86
CheckpointStateCache - add get delete 6.3710 us/op 3.8180 us/op 1.67
validate api signedAggregateAndProof - struct 2.8359 ms/op 2.3669 ms/op 1.20
validate gossip signedAggregateAndProof - struct 2.9213 ms/op 2.4688 ms/op 1.18
validate gossip attestation - vc 640000 1.3972 ms/op 1.1588 ms/op 1.21
batch validate gossip attestation - vc 640000 - chunk 32 167.25 us/op 146.31 us/op 1.14
batch validate gossip attestation - vc 640000 - chunk 64 149.46 us/op 120.48 us/op 1.24
batch validate gossip attestation - vc 640000 - chunk 128 145.30 us/op 110.45 us/op 1.32
batch validate gossip attestation - vc 640000 - chunk 256 143.76 us/op 108.84 us/op 1.32
pickEth1Vote - no votes 1.4043 ms/op 778.41 us/op 1.80
pickEth1Vote - max votes 9.1697 ms/op 8.8317 ms/op 1.04
pickEth1Vote - Eth1Data hashTreeRoot value x2048 16.182 ms/op 20.959 ms/op 0.77
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 31.917 ms/op 26.463 ms/op 1.21
pickEth1Vote - Eth1Data fastSerialize value x2048 665.08 us/op 420.86 us/op 1.58
pickEth1Vote - Eth1Data fastSerialize tree x2048 4.3390 ms/op 7.6648 ms/op 0.57
bytes32 toHexString 575.00 ns/op 437.00 ns/op 1.32
bytes32 Buffer.toString(hex) 294.00 ns/op 294.00 ns/op 1.00
bytes32 Buffer.toString(hex) from Uint8Array 482.00 ns/op 393.00 ns/op 1.23
bytes32 Buffer.toString(hex) + 0x 288.00 ns/op 287.00 ns/op 1.00
Object access 1 prop 0.18400 ns/op 0.19600 ns/op 0.94
Map access 1 prop 0.15500 ns/op 0.19300 ns/op 0.80
Object get x1000 7.2110 ns/op 5.6750 ns/op 1.27
Map get x1000 0.85700 ns/op 0.71400 ns/op 1.20
Object set x1000 61.445 ns/op 24.488 ns/op 2.51
Map set x1000 43.451 ns/op 16.922 ns/op 2.57
Return object 10000 times 0.23950 ns/op 0.22550 ns/op 1.06
Throw Error 10000 times 3.9354 us/op 2.6314 us/op 1.50
fastMsgIdFn sha256 / 200 bytes 3.4120 us/op 1.9590 us/op 1.74
fastMsgIdFn h32 xxhash / 200 bytes 331.00 ns/op 278.00 ns/op 1.19
fastMsgIdFn h64 xxhash / 200 bytes 387.00 ns/op 336.00 ns/op 1.15
fastMsgIdFn sha256 / 1000 bytes 11.550 us/op 6.0510 us/op 1.91
fastMsgIdFn h32 xxhash / 1000 bytes 466.00 ns/op 397.00 ns/op 1.17
fastMsgIdFn h64 xxhash / 1000 bytes 454.00 ns/op 405.00 ns/op 1.12
fastMsgIdFn sha256 / 10000 bytes 105.13 us/op 52.943 us/op 1.99
fastMsgIdFn h32 xxhash / 10000 bytes 1.9740 us/op 1.7730 us/op 1.11
fastMsgIdFn h64 xxhash / 10000 bytes 1.3760 us/op 1.2180 us/op 1.13
send data - 1000 256B messages 21.566 ms/op 11.058 ms/op 1.95
send data - 1000 512B messages 29.169 ms/op 14.990 ms/op 1.95
send data - 1000 1024B messages 42.607 ms/op 22.728 ms/op 1.87
send data - 1000 1200B messages 40.810 ms/op 28.449 ms/op 1.43
send data - 1000 2048B messages 51.437 ms/op 33.820 ms/op 1.52
send data - 1000 4096B messages 43.549 ms/op 29.314 ms/op 1.49
send data - 1000 16384B messages 109.16 ms/op 91.387 ms/op 1.19
send data - 1000 65536B messages 459.29 ms/op 444.68 ms/op 1.03
enrSubnets - fastDeserialize 64 bits 1.3100 us/op 1.0340 us/op 1.27
enrSubnets - ssz BitVector 64 bits 502.00 ns/op 420.00 ns/op 1.20
enrSubnets - fastDeserialize 4 bits 228.00 ns/op 215.00 ns/op 1.06
enrSubnets - ssz BitVector 4 bits 529.00 ns/op 430.00 ns/op 1.23
prioritizePeers score -10:0 att 32-0.1 sync 2-0 112.71 us/op 66.663 us/op 1.69
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 146.57 us/op 79.071 us/op 1.85
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 197.10 us/op 116.07 us/op 1.70
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 332.32 us/op 186.34 us/op 1.78
prioritizePeers score 0:0 att 64-1 sync 4-1 369.64 us/op 215.46 us/op 1.72
array of 16000 items push then shift 1.6843 us/op 1.2836 us/op 1.31
LinkedList of 16000 items push then shift 9.0700 ns/op 5.9700 ns/op 1.52
array of 16000 items push then pop 109.53 ns/op 66.738 ns/op 1.64
LinkedList of 16000 items push then pop 8.9930 ns/op 5.7630 ns/op 1.56
array of 24000 items push then shift 2.5799 us/op 1.9164 us/op 1.35
LinkedList of 24000 items push then shift 9.4300 ns/op 5.9000 ns/op 1.60
array of 24000 items push then pop 147.40 ns/op 112.18 ns/op 1.31
LinkedList of 24000 items push then pop 8.8880 ns/op 5.7350 ns/op 1.55
intersect bitArray bitLen 8 5.7520 ns/op 4.9000 ns/op 1.17
intersect array and set length 8 68.627 ns/op 49.557 ns/op 1.38
intersect bitArray bitLen 128 35.159 ns/op 29.728 ns/op 1.18
intersect array and set length 128 987.16 ns/op 689.61 ns/op 1.43
bitArray.getTrueBitIndexes() bitLen 128 1.7180 us/op 1.2470 us/op 1.38
bitArray.getTrueBitIndexes() bitLen 248 3.0730 us/op 1.9990 us/op 1.54
bitArray.getTrueBitIndexes() bitLen 512 6.1730 us/op 3.7560 us/op 1.64
Buffer.concat 32 items 996.00 ns/op 814.00 ns/op 1.22
Uint8Array.set 32 items 1.7660 us/op 1.6150 us/op 1.09
Set add up to 64 items then delete first 4.6941 us/op 1.7854 us/op 2.63
OrderedSet add up to 64 items then delete first 5.9031 us/op 2.7134 us/op 2.18
Set add up to 64 items then delete last 5.3257 us/op 2.0878 us/op 2.55
OrderedSet add up to 64 items then delete last 6.6878 us/op 3.0412 us/op 2.20
Set add up to 64 items then delete middle 5.3270 us/op 1.9888 us/op 2.68
OrderedSet add up to 64 items then delete middle 8.4814 us/op 4.1897 us/op 2.02
Set add up to 128 items then delete first 10.636 us/op 3.9313 us/op 2.71
OrderedSet add up to 128 items then delete first 13.925 us/op 6.1671 us/op 2.26
Set add up to 128 items then delete last 10.600 us/op 3.7642 us/op 2.82
OrderedSet add up to 128 items then delete last 14.347 us/op 5.9187 us/op 2.42
Set add up to 128 items then delete middle 10.480 us/op 3.9914 us/op 2.63
OrderedSet add up to 128 items then delete middle 20.358 us/op 11.943 us/op 1.70
Set add up to 256 items then delete first 21.231 us/op 7.5031 us/op 2.83
OrderedSet add up to 256 items then delete first 28.557 us/op 12.165 us/op 2.35
Set add up to 256 items then delete last 21.251 us/op 8.2396 us/op 2.58
OrderedSet add up to 256 items then delete last 30.111 us/op 12.013 us/op 2.51
Set add up to 256 items then delete middle 21.394 us/op 7.2514 us/op 2.95
OrderedSet add up to 256 items then delete middle 52.274 us/op 32.419 us/op 1.61
transfer serialized Status (84 B) 1.9520 us/op 1.3430 us/op 1.45
copy serialized Status (84 B) 1.4450 us/op 1.0780 us/op 1.34
transfer serialized SignedVoluntaryExit (112 B) 2.1430 us/op 1.3840 us/op 1.55
copy serialized SignedVoluntaryExit (112 B) 1.5760 us/op 1.0720 us/op 1.47
transfer serialized ProposerSlashing (416 B) 3.3570 us/op 1.5500 us/op 2.17
copy serialized ProposerSlashing (416 B) 2.9730 us/op 1.4140 us/op 2.10
transfer serialized Attestation (485 B) 2.9370 us/op 1.6040 us/op 1.83
copy serialized Attestation (485 B) 2.3540 us/op 1.3270 us/op 1.77
transfer serialized AttesterSlashing (33232 B) 2.8070 us/op 1.6420 us/op 1.71
copy serialized AttesterSlashing (33232 B) 9.9310 us/op 6.0090 us/op 1.65
transfer serialized Small SignedBeaconBlock (128000 B) 3.0510 us/op 2.4100 us/op 1.27
copy serialized Small SignedBeaconBlock (128000 B) 18.981 us/op 10.436 us/op 1.82
transfer serialized Avg SignedBeaconBlock (200000 B) 3.9860 us/op 2.7910 us/op 1.43
copy serialized Avg SignedBeaconBlock (200000 B) 24.661 us/op 13.071 us/op 1.89
transfer serialized BlobsSidecar (524380 B) 3.9990 us/op 2.8580 us/op 1.40
copy serialized BlobsSidecar (524380 B) 85.426 us/op 128.29 us/op 0.67
transfer serialized Big SignedBeaconBlock (1000000 B) 4.4330 us/op 2.7120 us/op 1.63
copy serialized Big SignedBeaconBlock (1000000 B) 198.71 us/op 143.18 us/op 1.39
pass gossip attestations to forkchoice per slot 4.4207 ms/op 2.5523 ms/op 1.73
forkChoice updateHead vc 100000 bc 64 eq 0 690.33 us/op 410.65 us/op 1.68
forkChoice updateHead vc 600000 bc 64 eq 0 5.0360 ms/op 3.3266 ms/op 1.51
forkChoice updateHead vc 1000000 bc 64 eq 0 7.3290 ms/op 4.3449 ms/op 1.69
forkChoice updateHead vc 600000 bc 320 eq 0 4.2351 ms/op 2.6229 ms/op 1.61
forkChoice updateHead vc 600000 bc 1200 eq 0 4.4326 ms/op 2.7244 ms/op 1.63
forkChoice updateHead vc 600000 bc 7200 eq 0 6.0988 ms/op 3.4263 ms/op 1.78
forkChoice updateHead vc 600000 bc 64 eq 1000 11.894 ms/op 10.111 ms/op 1.18
forkChoice updateHead vc 600000 bc 64 eq 10000 12.315 ms/op 9.8064 ms/op 1.26
forkChoice updateHead vc 600000 bc 64 eq 300000 20.858 ms/op 11.874 ms/op 1.76
computeDeltas 500000 validators 300 proto nodes 6.7585 ms/op 3.2507 ms/op 2.08
computeDeltas 500000 validators 1200 proto nodes 6.4382 ms/op 3.3413 ms/op 1.93
computeDeltas 500000 validators 7200 proto nodes 6.4758 ms/op 3.3361 ms/op 1.94
computeDeltas 750000 validators 300 proto nodes 9.3500 ms/op 5.0178 ms/op 1.86
computeDeltas 750000 validators 1200 proto nodes 9.5924 ms/op 5.2271 ms/op 1.84
computeDeltas 750000 validators 7200 proto nodes 9.9300 ms/op 6.8061 ms/op 1.46
computeDeltas 1400000 validators 300 proto nodes 18.793 ms/op 10.498 ms/op 1.79
computeDeltas 1400000 validators 1200 proto nodes 18.332 ms/op 9.8738 ms/op 1.86
computeDeltas 1400000 validators 7200 proto nodes 18.804 ms/op 9.7867 ms/op 1.92
computeDeltas 2100000 validators 300 proto nodes 37.101 ms/op 14.339 ms/op 2.59
computeDeltas 2100000 validators 1200 proto nodes 33.413 ms/op 13.788 ms/op 2.42
computeDeltas 2100000 validators 7200 proto nodes 37.794 ms/op 13.343 ms/op 2.83
altair processAttestation - 250000 vs - 7PWei normalcase 4.2239 ms/op 1.6356 ms/op 2.58
altair processAttestation - 250000 vs - 7PWei worstcase 5.7599 ms/op 2.4061 ms/op 2.39
altair processAttestation - setStatus - 1/6 committees join 313.46 us/op 108.19 us/op 2.90
altair processAttestation - setStatus - 1/3 committees join 519.54 us/op 208.59 us/op 2.49
altair processAttestation - setStatus - 1/2 committees join 613.87 us/op 290.99 us/op 2.11
altair processAttestation - setStatus - 2/3 committees join 700.72 us/op 379.37 us/op 1.85
altair processAttestation - setStatus - 4/5 committees join 948.31 us/op 502.97 us/op 1.89
altair processAttestation - setStatus - 100% committees join 1.0896 ms/op 594.01 us/op 1.83
altair processBlock - 250000 vs - 7PWei normalcase 12.821 ms/op 6.6171 ms/op 1.94
altair processBlock - 250000 vs - 7PWei normalcase hashState 47.372 ms/op 29.545 ms/op 1.60
altair processBlock - 250000 vs - 7PWei worstcase 50.745 ms/op 36.081 ms/op 1.41
altair processBlock - 250000 vs - 7PWei worstcase hashState 112.71 ms/op 82.936 ms/op 1.36
phase0 processBlock - 250000 vs - 7PWei normalcase 4.9939 ms/op 2.3591 ms/op 2.12
phase0 processBlock - 250000 vs - 7PWei worstcase 34.325 ms/op 25.292 ms/op 1.36
altair processEth1Data - 250000 vs - 7PWei normalcase 699.39 us/op 311.93 us/op 2.24
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 11.063 us/op 5.6110 us/op 1.97
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 94.749 us/op 57.603 us/op 1.64
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 35.192 us/op 20.106 us/op 1.75
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 23.937 us/op 12.410 us/op 1.93
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 185.04 us/op 149.58 us/op 1.24
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.6182 ms/op 1.0711 ms/op 1.51
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.0079 ms/op 908.39 us/op 2.21
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.3774 ms/op 1.5449 ms/op 1.54
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.7113 ms/op 2.5982 ms/op 1.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.8134 ms/op 2.1092 ms/op 1.33
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 6.6271 ms/op 4.3769 ms/op 1.51
Tree 40 250000 create 421.01 ms/op 265.96 ms/op 1.58
Tree 40 250000 get(125000) 215.62 ns/op 117.26 ns/op 1.84
Tree 40 250000 set(125000) 1.6046 us/op 789.70 ns/op 2.03
Tree 40 250000 toArray() 27.714 ms/op 18.961 ms/op 1.46
Tree 40 250000 iterate all - toArray() + loop 25.172 ms/op 20.331 ms/op 1.24
Tree 40 250000 iterate all - get(i) 80.759 ms/op 49.028 ms/op 1.65
MutableVector 250000 create 14.047 ms/op 13.344 ms/op 1.05
MutableVector 250000 get(125000) 6.9710 ns/op 5.5780 ns/op 1.25
MutableVector 250000 set(125000) 379.67 ns/op 205.65 ns/op 1.85
MutableVector 250000 toArray() 3.9849 ms/op 2.9022 ms/op 1.37
MutableVector 250000 iterate all - toArray() + loop 4.0664 ms/op 3.2228 ms/op 1.26
MutableVector 250000 iterate all - get(i) 1.5593 ms/op 1.3200 ms/op 1.18
Array 250000 create 3.7920 ms/op 2.8848 ms/op 1.31
Array 250000 clone - spread 1.5675 ms/op 1.1024 ms/op 1.42
Array 250000 get(125000) 1.2680 ns/op 1.0130 ns/op 1.25
Array 250000 set(125000) 5.4830 ns/op 1.2150 ns/op 4.51
Array 250000 iterate all - loop 167.87 us/op 150.24 us/op 1.12
effectiveBalanceIncrements clone Uint8Array 300000 59.772 us/op 25.982 us/op 2.30
effectiveBalanceIncrements clone MutableVector 300000 484.00 ns/op 408.00 ns/op 1.19
effectiveBalanceIncrements rw all Uint8Array 300000 201.09 us/op 179.18 us/op 1.12
effectiveBalanceIncrements rw all MutableVector 300000 105.19 ms/op 73.710 ms/op 1.43
phase0 afterProcessEpoch - 250000 vs - 7PWei 116.05 ms/op 79.386 ms/op 1.46
phase0 beforeProcessEpoch - 250000 vs - 7PWei 57.888 ms/op 48.357 ms/op 1.20
altair processEpoch - mainnet_e81889 516.82 ms/op 412.55 ms/op 1.25
mainnet_e81889 - altair beforeProcessEpoch 88.772 ms/op 79.126 ms/op 1.12
mainnet_e81889 - altair processJustificationAndFinalization 16.184 us/op 12.416 us/op 1.30
mainnet_e81889 - altair processInactivityUpdates 6.1836 ms/op 5.9755 ms/op 1.03
mainnet_e81889 - altair processRewardsAndPenalties 64.096 ms/op 52.732 ms/op 1.22
mainnet_e81889 - altair processRegistryUpdates 5.1350 us/op 1.9100 us/op 2.69
mainnet_e81889 - altair processSlashings 1.1900 us/op 777.00 ns/op 1.53
mainnet_e81889 - altair processEth1DataReset 1.3940 us/op 556.00 ns/op 2.51
mainnet_e81889 - altair processEffectiveBalanceUpdates 4.3673 ms/op 1.8377 ms/op 2.38
mainnet_e81889 - altair processSlashingsReset 8.5340 us/op 4.4050 us/op 1.94
mainnet_e81889 - altair processRandaoMixesReset 9.7850 us/op 6.9870 us/op 1.40
mainnet_e81889 - altair processHistoricalRootsUpdate 1.6840 us/op 843.00 ns/op 2.00
mainnet_e81889 - altair processParticipationFlagUpdates 3.7880 us/op 2.2410 us/op 1.69
mainnet_e81889 - altair processSyncCommitteeUpdates 1.2760 us/op 691.00 ns/op 1.85
mainnet_e81889 - altair afterProcessEpoch 144.31 ms/op 81.837 ms/op 1.76
capella processEpoch - mainnet_e217614 2.5131 s/op 1.9810 s/op 1.27
mainnet_e217614 - capella beforeProcessEpoch 595.66 ms/op 479.77 ms/op 1.24
mainnet_e217614 - capella processJustificationAndFinalization 17.874 us/op 13.214 us/op 1.35
mainnet_e217614 - capella processInactivityUpdates 18.707 ms/op 15.944 ms/op 1.17
mainnet_e217614 - capella processRewardsAndPenalties 445.29 ms/op 352.68 ms/op 1.26
mainnet_e217614 - capella processRegistryUpdates 30.472 us/op 32.301 us/op 0.94
mainnet_e217614 - capella processSlashings 570.00 ns/op 650.00 ns/op 0.88
mainnet_e217614 - capella processEth1DataReset 432.00 ns/op 544.00 ns/op 0.79
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.4497 ms/op 3.9198 ms/op 1.14
mainnet_e217614 - capella processSlashingsReset 6.9350 us/op 2.3740 us/op 2.92
mainnet_e217614 - capella processRandaoMixesReset 5.1420 us/op 3.0090 us/op 1.71
mainnet_e217614 - capella processHistoricalRootsUpdate 482.00 ns/op 622.00 ns/op 0.77
mainnet_e217614 - capella processParticipationFlagUpdates 1.3540 us/op 1.4070 us/op 0.96
mainnet_e217614 - capella afterProcessEpoch 299.81 ms/op 226.70 ms/op 1.32
phase0 processEpoch - mainnet_e58758 442.59 ms/op 404.57 ms/op 1.09
mainnet_e58758 - phase0 beforeProcessEpoch 117.19 ms/op 112.61 ms/op 1.04
mainnet_e58758 - phase0 processJustificationAndFinalization 15.100 us/op 15.581 us/op 0.97
mainnet_e58758 - phase0 processRewardsAndPenalties 51.258 ms/op 43.711 ms/op 1.17
mainnet_e58758 - phase0 processRegistryUpdates 10.925 us/op 10.883 us/op 1.00
mainnet_e58758 - phase0 processSlashings 439.00 ns/op 827.00 ns/op 0.53
mainnet_e58758 - phase0 processEth1DataReset 495.00 ns/op 814.00 ns/op 0.61
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1711 ms/op 985.52 us/op 1.19
mainnet_e58758 - phase0 processSlashingsReset 2.9320 us/op 3.8120 us/op 0.77
mainnet_e58758 - phase0 processRandaoMixesReset 4.0260 us/op 7.1940 us/op 0.56
mainnet_e58758 - phase0 processHistoricalRootsUpdate 379.00 ns/op 796.00 ns/op 0.48
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.3030 us/op 4.2830 us/op 1.00
mainnet_e58758 - phase0 afterProcessEpoch 95.833 ms/op 67.690 ms/op 1.42
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.3744 ms/op 1.0526 ms/op 1.31
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.6186 ms/op 1.2207 ms/op 1.33
altair processInactivityUpdates - 250000 normalcase 23.642 ms/op 29.482 ms/op 0.80
altair processInactivityUpdates - 250000 worstcase 30.843 ms/op 27.088 ms/op 1.14
phase0 processRegistryUpdates - 250000 normalcase 11.977 us/op 11.568 us/op 1.04
phase0 processRegistryUpdates - 250000 badcase_full_deposits 434.75 us/op 446.62 us/op 0.97
phase0 processRegistryUpdates - 250000 worstcase 0.5 141.50 ms/op 141.63 ms/op 1.00
altair processRewardsAndPenalties - 250000 normalcase 60.903 ms/op 53.683 ms/op 1.13
altair processRewardsAndPenalties - 250000 worstcase 45.060 ms/op 59.712 ms/op 0.75
phase0 getAttestationDeltas - 250000 normalcase 9.1511 ms/op 6.1449 ms/op 1.49
phase0 getAttestationDeltas - 250000 worstcase 9.2791 ms/op 6.4122 ms/op 1.45
phase0 processSlashings - 250000 worstcase 90.986 us/op 92.394 us/op 0.98
altair processSyncCommitteeUpdates - 250000 160.58 ms/op 119.55 ms/op 1.34
BeaconState.hashTreeRoot - No change 466.00 ns/op 433.00 ns/op 1.08
BeaconState.hashTreeRoot - 1 full validator 135.25 us/op 118.73 us/op 1.14
BeaconState.hashTreeRoot - 32 full validator 1.7311 ms/op 1.3126 ms/op 1.32
BeaconState.hashTreeRoot - 512 full validator 16.208 ms/op 14.565 ms/op 1.11
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 187.45 us/op 141.35 us/op 1.33
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.3466 ms/op 1.6239 ms/op 1.45
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 30.171 ms/op 21.475 ms/op 1.40
BeaconState.hashTreeRoot - 1 balances 136.01 us/op 119.81 us/op 1.14
BeaconState.hashTreeRoot - 32 balances 1.1889 ms/op 1.1801 ms/op 1.01
BeaconState.hashTreeRoot - 512 balances 10.395 ms/op 14.559 ms/op 0.71
BeaconState.hashTreeRoot - 250000 balances 178.74 ms/op 229.37 ms/op 0.78
aggregationBits - 2048 els - zipIndexesInBitList 18.194 us/op 27.726 us/op 0.66
byteArrayEquals 32 75.660 ns/op 64.126 ns/op 1.18
Buffer.compare 32 56.166 ns/op 36.576 ns/op 1.54
byteArrayEquals 1024 2.0654 us/op 1.7138 us/op 1.21
Buffer.compare 1024 69.979 ns/op 41.927 ns/op 1.67
byteArrayEquals 16384 32.930 us/op 27.026 us/op 1.22
Buffer.compare 16384 277.99 ns/op 226.55 ns/op 1.23
byteArrayEquals 123687377 244.28 ms/op 204.98 ms/op 1.19
Buffer.compare 123687377 6.5044 ms/op 6.8879 ms/op 0.94
byteArrayEquals 32 - diff last byte 72.345 ns/op 61.147 ns/op 1.18
Buffer.compare 32 - diff last byte 56.770 ns/op 37.528 ns/op 1.51
byteArrayEquals 1024 - diff last byte 2.0336 us/op 1.7152 us/op 1.19
Buffer.compare 1024 - diff last byte 70.154 ns/op 43.124 ns/op 1.63
byteArrayEquals 16384 - diff last byte 32.401 us/op 26.711 us/op 1.21
Buffer.compare 16384 - diff last byte 270.89 ns/op 216.67 ns/op 1.25
byteArrayEquals 123687377 - diff last byte 246.35 ms/op 201.89 ms/op 1.22
Buffer.compare 123687377 - diff last byte 8.1047 ms/op 4.5187 ms/op 1.79
byteArrayEquals 32 - random bytes 5.6560 ns/op 4.6680 ns/op 1.21
Buffer.compare 32 - random bytes 62.306 ns/op 39.773 ns/op 1.57
byteArrayEquals 1024 - random bytes 6.4950 ns/op 4.5280 ns/op 1.43
Buffer.compare 1024 - random bytes 61.557 ns/op 38.875 ns/op 1.58
byteArrayEquals 16384 - random bytes 6.0040 ns/op 4.5730 ns/op 1.31
Buffer.compare 16384 - random bytes 62.565 ns/op 39.115 ns/op 1.60
byteArrayEquals 123687377 - random bytes 8.8200 ns/op 8.1500 ns/op 1.08
Buffer.compare 123687377 - random bytes 66.000 ns/op 41.730 ns/op 1.58
regular array get 100000 times 44.939 us/op 41.556 us/op 1.08
wrappedArray get 100000 times 45.842 us/op 41.428 us/op 1.11
arrayWithProxy get 100000 times 14.127 ms/op 10.129 ms/op 1.39
ssz.Root.equals 54.591 ns/op 55.053 ns/op 0.99
byteArrayEquals 53.684 ns/op 53.939 ns/op 1.00
Buffer.compare 11.729 ns/op 9.2680 ns/op 1.27
shuffle list - 16384 els 7.1373 ms/op 4.5518 ms/op 1.57
shuffle list - 250000 els 108.97 ms/op 66.311 ms/op 1.64
processSlot - 1 slots 21.607 us/op 12.489 us/op 1.73
processSlot - 32 slots 3.8219 ms/op 2.1376 ms/op 1.79
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 62.793 ms/op 49.721 ms/op 1.26
getCommitteeAssignments - req 1 vs - 250000 vc 2.7082 ms/op 2.1689 ms/op 1.25
getCommitteeAssignments - req 100 vs - 250000 vc 3.9934 ms/op 3.2973 ms/op 1.21
getCommitteeAssignments - req 1000 vs - 250000 vc 4.3997 ms/op 3.5791 ms/op 1.23
findModifiedValidators - 10000 modified validators 638.57 ms/op 413.50 ms/op 1.54
findModifiedValidators - 1000 modified validators 528.86 ms/op 336.27 ms/op 1.57
findModifiedValidators - 100 modified validators 498.36 ms/op 323.93 ms/op 1.54
findModifiedValidators - 10 modified validators 503.27 ms/op 319.10 ms/op 1.58
findModifiedValidators - 1 modified validators 469.21 ms/op 306.53 ms/op 1.53
findModifiedValidators - no difference 493.47 ms/op 321.21 ms/op 1.54
compare ViewDUs 5.3493 s/op 3.8620 s/op 1.39
compare each validator Uint8Array 2.0025 s/op 1.5472 s/op 1.29
compare ViewDU to Uint8Array 1.4788 s/op 992.96 ms/op 1.49
migrate state 1000000 validators, 24 modified, 0 new 898.96 ms/op 685.45 ms/op 1.31
migrate state 1000000 validators, 1700 modified, 1000 new 1.2405 s/op 1.0840 s/op 1.14
migrate state 1000000 validators, 3400 modified, 2000 new 1.5038 s/op 1.4147 s/op 1.06
migrate state 1500000 validators, 24 modified, 0 new 775.04 ms/op 832.87 ms/op 0.93
migrate state 1500000 validators, 1700 modified, 1000 new 1.1017 s/op 1.0415 s/op 1.06
migrate state 1500000 validators, 3400 modified, 2000 new 1.4027 s/op 1.4721 s/op 0.95
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.1100 ns/op 4.9800 ns/op 1.03
state getBlockRootAtSlot - 250000 vs - 7PWei 666.03 ns/op 860.99 ns/op 0.77
computeProposers - vc 250000 9.9406 ms/op 8.0330 ms/op 1.24
computeEpochShuffling - vc 250000 105.82 ms/op 69.857 ms/op 1.51
getNextSyncCommittee - vc 250000 160.06 ms/op 131.14 ms/op 1.22
computeSigningRoot for AttestationData 26.103 us/op 33.367 us/op 0.78
hash AttestationData serialized data then Buffer.toString(base64) 2.3777 us/op 1.3500 us/op 1.76
toHexString serialized data 1.1243 us/op 826.88 ns/op 1.36
Buffer.toString(base64) 237.90 ns/op 168.81 ns/op 1.41

by benchmarkbot/action

@@ -23,9 +23,9 @@ on:
default: 40

env:
GETH_DOCKER_IMAGE: ethereum/client-go:v1.11.6
GETH_DOCKER_IMAGE: ethereum/client-go:v1.13.11
LIGHTHOUSE_DOCKER_IMAGE: sigp/lighthouse:latest-amd64-modern-dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should use a release version for lighthouse as well

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lighthosue releases does not build with minimal preset.

Copy link
Member

@nflaig nflaig Feb 6, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about sigp/lighthouse:v4.6.0-amd64-modern-dev, the -dev suffix suggest it has minimal preset.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes the build with -dev is the right one. Seems for latest releases they started the dev builds. I will update it shortly.

@nazarhussain nazarhussain merged commit d8b500a into unstable Feb 6, 2024
13 of 15 checks passed
@nazarhussain nazarhussain deleted the nh/sim-client-upgrade branch February 6, 2024 14:18
@nflaig
Copy link
Member

nflaig commented Feb 6, 2024

Would it make sense to store those values so that they are reused by e2e tests too? Right now they are also defined in test.yml and CONTRIBUTING.md. It also forces users to provide those value manually when running scripts/run_e2e_env.sh.

I think that is a good idea, we should make as easy as possible to run tests locally, also this PR did not update value in CONTRIBUTING.md, which seems incomplete to me

@nazarhussain
Copy link
Contributor Author

reused by e2e tests too

Reusability is always great. Will try to find better approach to share across scripts, workflows and local env. Probably an env file will work out. Will double check.

@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants