Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce verbosity of gossip block errors #6430

Merged
merged 7 commits into from Feb 15, 2024
Merged

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 15, 2024

Motivation

Follow logging-policy and avoid user concerns by reducing verbosity of non-critical errors.

Description

  • Adjust verbosity based on error type
  • Log gossip block errors as warnings
  • Only log to debug if blobs are unavailable within cutoff time

TODO

  • come up with a better approach to determine log verbosity (based on error type / code)

Closes #6402

@nflaig nflaig requested a review from a team as a code owner February 15, 2024 10:44
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #6430 (9b5fd54) into unstable (c52c7bd) will decrease coverage by 0.02%.
Report is 2 commits behind head on unstable.
The diff coverage is 6.66%.

❗ Current head 9b5fd54 differs from pull request most recent head 4b583a0. Consider uploading reports for the commit 4b583a0 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           unstable    #6430      +/-   ##
============================================
- Coverage     61.72%   61.70%   -0.02%     
============================================
  Files           553      553              
  Lines         57845    57858      +13     
  Branches       1829     1828       -1     
============================================
- Hits          35702    35701       -1     
- Misses        22106    22120      +14     
  Partials         37       37              

This comment was marked as off-topic.

Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@g11tech g11tech enabled auto-merge (squash) February 15, 2024 14:29
@g11tech g11tech merged commit 48871eb into unstable Feb 15, 2024
14 of 16 checks passed
@g11tech g11tech deleted the nflaig/block-error-logs branch February 15, 2024 15:15
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.16.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BLOCK_ERROR_DATA_UNAVAILABLE errors if blobs are late
3 participants