Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: use term 'retries' instead of 'retryAttempts' consistently #6465

Merged
merged 2 commits into from Feb 22, 2024
Merged

chore: use term 'retries' instead of 'retryAttempts' consistently #6465

merged 2 commits into from Feb 22, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 21, 2024

Motivation

Consistency in naming, and avoiding confusion if this setting is count of retries or count of attempts.

Description

Use term 'retries' instead of 'retryAttempts' consistently

@nflaig nflaig requested a review from a team as a code owner February 21, 2024 16:18
@codecov Codecov
Copy link

codecov bot commented Feb 21, 2024 •
edited

Codecov Report

Merging #6465 (72dd50b) into unstable (14ea654) will decrease coverage by 0.02%.
Report is 2 commits behind head on unstable.
The diff coverage is 75.00%.

❗ Current head 72dd50b differs from pull request most recent head 80c8ee9. Consider uploading reports for the commit 80c8ee9 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6465      +/-   ##
============================================
- Coverage     61.65%   61.63%   -0.02%     
============================================
  Files           553      553              
  Lines         57998    57999       +1     
  Branches       1843     1837       -6     
============================================
- Hits          35756    35750       -6     
- Misses        22206    22210       +4     
- Partials         36       39       +3

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 21, 2024 •
edited

⚠️ Performance Alert ⚠️

Possible performance regression was detected for some benchmarks.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold.

Benchmark suite Current: 3b6040f Previous: 53f8f99 Ratio
BeaconState.hashTreeRoot - No change 1.1870 us/op 392.00 ns/op 3.03
Full benchmark results
Benchmark suite Current: 3b6040f Previous: 53f8f99 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 609.24 us/op 688.59 us/op 0.88
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 106.22 us/op 115.21 us/op 0.92
BLS verify - blst-native 1.4455 ms/op 1.4655 ms/op 0.99
BLS verifyMultipleSignatures 3 - blst-native 2.9778 ms/op 3.1562 ms/op 0.94
BLS verifyMultipleSignatures 8 - blst-native 6.2864 ms/op 6.1628 ms/op 1.02
BLS verifyMultipleSignatures 32 - blst-native 22.677 ms/op 25.022 ms/op 0.91
BLS verifyMultipleSignatures 64 - blst-native 44.535 ms/op 47.853 ms/op 0.93
BLS verifyMultipleSignatures 128 - blst-native 89.778 ms/op 92.856 ms/op 0.97
BLS deserializing 10000 signatures 955.51 ms/op 1.0055 s/op 0.95
BLS deserializing 100000 signatures 9.2669 s/op 9.7152 s/op 0.95
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3434 ms/op 1.4797 ms/op 0.91
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.5418 ms/op 1.7701 ms/op 0.87
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.4126 ms/op 2.6747 ms/op 0.90
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.5174 ms/op 4.1978 ms/op 0.84
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.8916 ms/op 6.4479 ms/op 0.91
BLS aggregatePubkeys 32 - blst-native 27.106 us/op 30.295 us/op 0.89
BLS aggregatePubkeys 128 - blst-native 101.91 us/op 115.77 us/op 0.88
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 67.577 ms/op 69.609 ms/op 0.97
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 58.118 ms/op 68.238 ms/op 0.85
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 46.286 ms/op 54.899 ms/op 0.84
getSlashingsAndExits - default max 383.17 us/op 237.12 us/op 1.62
getSlashingsAndExits - 2k 486.62 us/op 927.37 us/op 0.52
proposeBlockBody type=full, size=empty 7.2127 ms/op 7.3259 ms/op 0.98
isKnown best case - 1 super set check 743.00 ns/op 743.00 ns/op 1.00
isKnown normal case - 2 super set checks 654.00 ns/op 916.00 ns/op 0.71
isKnown worse case - 16 super set checks 591.00 ns/op 837.00 ns/op 0.71
CheckpointStateCache - add get delete 6.4550 us/op 8.4690 us/op 0.76
validate api signedAggregateAndProof - struct 2.9885 ms/op 3.2351 ms/op 0.92
validate gossip signedAggregateAndProof - struct 3.0687 ms/op 3.1390 ms/op 0.98
validate gossip attestation - vc 640000 1.4997 ms/op 1.5341 ms/op 0.98
batch validate gossip attestation - vc 640000 - chunk 32 186.41 us/op 197.10 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 64 176.35 us/op 172.48 us/op 1.02
batch validate gossip attestation - vc 640000 - chunk 128 164.96 us/op 166.50 us/op 0.99
batch validate gossip attestation - vc 640000 - chunk 256 163.70 us/op 165.38 us/op 0.99
pickEth1Vote - no votes 1.5420 ms/op 1.5331 ms/op 1.01
pickEth1Vote - max votes 13.022 ms/op 16.000 ms/op 0.81
pickEth1Vote - Eth1Data hashTreeRoot value x2048 27.021 ms/op 26.465 ms/op 1.02
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 38.944 ms/op 55.562 ms/op 0.70
pickEth1Vote - Eth1Data fastSerialize value x2048 925.84 us/op 801.01 us/op 1.16
pickEth1Vote - Eth1Data fastSerialize tree x2048 6.7604 ms/op 5.4711 ms/op 1.24
bytes32 toHexString 878.00 ns/op 603.00 ns/op 1.46
bytes32 Buffer.toString(hex) 355.00 ns/op 370.00 ns/op 0.96
bytes32 Buffer.toString(hex) from Uint8Array 625.00 ns/op 537.00 ns/op 1.16
bytes32 Buffer.toString(hex) + 0x 363.00 ns/op 336.00 ns/op 1.08
Object access 1 prop 0.26800 ns/op 0.21600 ns/op 1.24
Map access 1 prop 0.19400 ns/op 0.17600 ns/op 1.10
Object get x1000 8.9960 ns/op 7.9890 ns/op 1.13
Map get x1000 1.0150 ns/op 0.93500 ns/op 1.09
Object set x1000 80.832 ns/op 81.651 ns/op 0.99
Map set x1000 62.914 ns/op 52.517 ns/op 1.20
Return object 10000 times 0.27410 ns/op 0.26130 ns/op 1.05
Throw Error 10000 times 4.4920 us/op 4.2046 us/op 1.07
fastMsgIdFn sha256 / 200 bytes 4.0950 us/op 3.5510 us/op 1.15
fastMsgIdFn h32 xxhash / 200 bytes 397.00 ns/op 355.00 ns/op 1.12
fastMsgIdFn h64 xxhash / 200 bytes 464.00 ns/op 420.00 ns/op 1.10
fastMsgIdFn sha256 / 1000 bytes 13.518 us/op 11.762 us/op 1.15
fastMsgIdFn h32 xxhash / 1000 bytes 562.00 ns/op 492.00 ns/op 1.14
fastMsgIdFn h64 xxhash / 1000 bytes 514.00 ns/op 480.00 ns/op 1.07
fastMsgIdFn sha256 / 10000 bytes 127.08 us/op 107.03 us/op 1.19
fastMsgIdFn h32 xxhash / 10000 bytes 2.2240 us/op 2.0180 us/op 1.10
fastMsgIdFn h64 xxhash / 10000 bytes 1.6020 us/op 1.4350 us/op 1.12
send data - 1000 256B messages 27.292 ms/op 22.933 ms/op 1.19
send data - 1000 512B messages 34.752 ms/op 35.104 ms/op 0.99
send data - 1000 1024B messages 56.698 ms/op 48.159 ms/op 1.18
send data - 1000 1200B messages 58.582 ms/op 42.243 ms/op 1.39
send data - 1000 2048B messages 59.148 ms/op 60.770 ms/op 0.97
send data - 1000 4096B messages 50.491 ms/op 55.088 ms/op 0.92
send data - 1000 16384B messages 143.72 ms/op 153.21 ms/op 0.94
send data - 1000 65536B messages 554.33 ms/op 555.06 ms/op 1.00
enrSubnets - fastDeserialize 64 bits 1.9680 us/op 1.6470 us/op 1.19
enrSubnets - ssz BitVector 64 bits 636.00 ns/op 604.00 ns/op 1.05
enrSubnets - fastDeserialize 4 bits 275.00 ns/op 274.00 ns/op 1.00
enrSubnets - ssz BitVector 4 bits 610.00 ns/op 634.00 ns/op 0.96
prioritizePeers score -10:0 att 32-0.1 sync 2-0 134.44 us/op 147.20 us/op 0.91
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 169.65 us/op 173.07 us/op 0.98
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 223.63 us/op 221.93 us/op 1.01
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 401.40 us/op 420.19 us/op 0.96
prioritizePeers score 0:0 att 64-1 sync 4-1 447.06 us/op 455.49 us/op 0.98
array of 16000 items push then shift 1.7895 us/op 1.9032 us/op 0.94
LinkedList of 16000 items push then shift 10.412 ns/op 12.769 ns/op 0.82
array of 16000 items push then pop 133.43 ns/op 145.34 ns/op 0.92
LinkedList of 16000 items push then pop 10.135 ns/op 11.438 ns/op 0.89
array of 24000 items push then shift 2.7135 us/op 2.8314 us/op 0.96
LinkedList of 24000 items push then shift 11.082 ns/op 10.792 ns/op 1.03
array of 24000 items push then pop 163.43 ns/op 188.29 ns/op 0.87
LinkedList of 24000 items push then pop 9.7230 ns/op 10.130 ns/op 0.96
intersect bitArray bitLen 8 6.3900 ns/op 6.6060 ns/op 0.97
intersect array and set length 8 102.88 ns/op 93.199 ns/op 1.10
intersect bitArray bitLen 128 38.493 ns/op 40.360 ns/op 0.95
intersect array and set length 128 1.1754 us/op 1.2468 us/op 0.94
bitArray.getTrueBitIndexes() bitLen 128 2.1500 us/op 2.1610 us/op 0.99
bitArray.getTrueBitIndexes() bitLen 248 3.6270 us/op 3.6880 us/op 0.98
bitArray.getTrueBitIndexes() bitLen 512 7.2220 us/op 7.8090 us/op 0.92
Buffer.concat 32 items 1.2140 us/op 1.1590 us/op 1.05
Uint8Array.set 32 items 2.7970 us/op 2.0250 us/op 1.38
Set add up to 64 items then delete first 5.7103 us/op 5.8289 us/op 0.98
OrderedSet add up to 64 items then delete first 7.7688 us/op 7.7910 us/op 1.00
Set add up to 64 items then delete last 5.9109 us/op 6.1213 us/op 0.97
OrderedSet add up to 64 items then delete last 7.9748 us/op 7.9404 us/op 1.00
Set add up to 64 items then delete middle 5.8026 us/op 6.2409 us/op 0.93
OrderedSet add up to 64 items then delete middle 9.1540 us/op 9.8269 us/op 0.93
Set add up to 128 items then delete first 11.676 us/op 12.325 us/op 0.95
OrderedSet add up to 128 items then delete first 16.012 us/op 16.295 us/op 0.98
Set add up to 128 items then delete last 11.417 us/op 11.701 us/op 0.98
OrderedSet add up to 128 items then delete last 14.722 us/op 15.429 us/op 0.95
Set add up to 128 items then delete middle 11.707 us/op 11.463 us/op 1.02
OrderedSet add up to 128 items then delete middle 21.050 us/op 21.927 us/op 0.96
Set add up to 256 items then delete first 22.649 us/op 24.800 us/op 0.91
OrderedSet add up to 256 items then delete first 32.684 us/op 33.589 us/op 0.97
Set add up to 256 items then delete last 22.104 us/op 24.877 us/op 0.89
OrderedSet add up to 256 items then delete last 28.807 us/op 33.465 us/op 0.86
Set add up to 256 items then delete middle 22.266 us/op 25.161 us/op 0.88
OrderedSet add up to 256 items then delete middle 55.192 us/op 57.909 us/op 0.95
transfer serialized Status (84 B) 1.9790 us/op 2.2050 us/op 0.90
copy serialized Status (84 B) 1.4640 us/op 1.6960 us/op 0.86
transfer serialized SignedVoluntaryExit (112 B) 2.1570 us/op 2.1140 us/op 1.02
copy serialized SignedVoluntaryExit (112 B) 1.6160 us/op 1.5910 us/op 1.02
transfer serialized ProposerSlashing (416 B) 2.5840 us/op 3.2190 us/op 0.80
copy serialized ProposerSlashing (416 B) 2.3380 us/op 2.5480 us/op 0.92
transfer serialized Attestation (485 B) 2.5750 us/op 2.6520 us/op 0.97
copy serialized Attestation (485 B) 2.2880 us/op 3.4990 us/op 0.65
transfer serialized AttesterSlashing (33232 B) 3.2280 us/op 3.4930 us/op 0.92
copy serialized AttesterSlashing (33232 B) 11.388 us/op 10.220 us/op 1.11
transfer serialized Small SignedBeaconBlock (128000 B) 4.2670 us/op 3.5360 us/op 1.21
copy serialized Small SignedBeaconBlock (128000 B) 38.035 us/op 31.452 us/op 1.21
transfer serialized Avg SignedBeaconBlock (200000 B) 3.5520 us/op 4.1330 us/op 0.86
copy serialized Avg SignedBeaconBlock (200000 B) 51.730 us/op 42.764 us/op 1.21
transfer serialized BlobsSidecar (524380 B) 4.1050 us/op 4.1760 us/op 0.98
copy serialized BlobsSidecar (524380 B) 289.52 us/op 131.97 us/op 2.19
transfer serialized Big SignedBeaconBlock (1000000 B) 4.6500 us/op 5.9850 us/op 0.78
copy serialized Big SignedBeaconBlock (1000000 B) 294.20 us/op 261.24 us/op 1.13
pass gossip attestations to forkchoice per slot 4.5897 ms/op 4.4491 ms/op 1.03
forkChoice updateHead vc 100000 bc 64 eq 0 794.46 us/op 785.00 us/op 1.01
forkChoice updateHead vc 600000 bc 64 eq 0 5.5941 ms/op 4.8686 ms/op 1.15
forkChoice updateHead vc 1000000 bc 64 eq 0 8.4183 ms/op 9.2844 ms/op 0.91
forkChoice updateHead vc 600000 bc 320 eq 0 4.9902 ms/op 5.1787 ms/op 0.96
forkChoice updateHead vc 600000 bc 1200 eq 0 5.0340 ms/op 5.7253 ms/op 0.88
forkChoice updateHead vc 600000 bc 7200 eq 0 6.1428 ms/op 6.6276 ms/op 0.93
forkChoice updateHead vc 600000 bc 64 eq 1000 12.713 ms/op 13.289 ms/op 0.96
forkChoice updateHead vc 600000 bc 64 eq 10000 13.828 ms/op 15.870 ms/op 0.87
forkChoice updateHead vc 600000 bc 64 eq 300000 26.012 ms/op 40.851 ms/op 0.64
computeDeltas 500000 validators 300 proto nodes 7.2715 ms/op 7.3342 ms/op 0.99
computeDeltas 500000 validators 1200 proto nodes 7.2272 ms/op 7.6225 ms/op 0.95
computeDeltas 500000 validators 7200 proto nodes 6.9776 ms/op 7.0726 ms/op 0.99
computeDeltas 750000 validators 300 proto nodes 10.519 ms/op 10.470 ms/op 1.00
computeDeltas 750000 validators 1200 proto nodes 10.777 ms/op 10.821 ms/op 1.00
computeDeltas 750000 validators 7200 proto nodes 10.940 ms/op 11.397 ms/op 0.96
computeDeltas 1400000 validators 300 proto nodes 21.521 ms/op 21.476 ms/op 1.00
computeDeltas 1400000 validators 1200 proto nodes 20.988 ms/op 21.532 ms/op 0.97
computeDeltas 1400000 validators 7200 proto nodes 20.714 ms/op 22.233 ms/op 0.93
computeDeltas 2100000 validators 300 proto nodes 30.191 ms/op 33.216 ms/op 0.91
computeDeltas 2100000 validators 1200 proto nodes 31.407 ms/op 34.139 ms/op 0.92
computeDeltas 2100000 validators 7200 proto nodes 30.658 ms/op 33.194 ms/op 0.92
altair processAttestation - 250000 vs - 7PWei normalcase 3.6888 ms/op 3.7464 ms/op 0.98
altair processAttestation - 250000 vs - 7PWei worstcase 4.1589 ms/op 5.3926 ms/op 0.77
altair processAttestation - setStatus - 1/6 committees join 202.06 us/op 204.79 us/op 0.99
altair processAttestation - setStatus - 1/3 committees join 379.19 us/op 397.84 us/op 0.95
altair processAttestation - setStatus - 1/2 committees join 539.50 us/op 493.57 us/op 1.09
altair processAttestation - setStatus - 2/3 committees join 658.91 us/op 611.89 us/op 1.08
altair processAttestation - setStatus - 4/5 committees join 863.92 us/op 879.12 us/op 0.98
altair processAttestation - setStatus - 100% committees join 1.0203 ms/op 1.1404 ms/op 0.89
altair processBlock - 250000 vs - 7PWei normalcase 12.625 ms/op 13.362 ms/op 0.94
altair processBlock - 250000 vs - 7PWei normalcase hashState 40.437 ms/op 49.896 ms/op 0.81
altair processBlock - 250000 vs - 7PWei worstcase 49.023 ms/op 53.837 ms/op 0.91
altair processBlock - 250000 vs - 7PWei worstcase hashState 107.07 ms/op 112.75 ms/op 0.95
phase0 processBlock - 250000 vs - 7PWei normalcase 3.2570 ms/op 3.8228 ms/op 0.85
phase0 processBlock - 250000 vs - 7PWei worstcase 37.463 ms/op 40.072 ms/op 0.93
altair processEth1Data - 250000 vs - 7PWei normalcase 743.50 us/op 1.1017 ms/op 0.67
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 16.382 us/op 23.996 us/op 0.68
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 53.257 us/op 88.486 us/op 0.60
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 31.374 us/op 43.046 us/op 0.73
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 18.611 us/op 30.935 us/op 0.60
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 210.68 us/op 271.08 us/op 0.78
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.8882 ms/op 2.2769 ms/op 0.83
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 2.3833 ms/op 3.3185 ms/op 0.72
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 2.1273 ms/op 2.4594 ms/op 0.86
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 4.2339 ms/op 6.0820 ms/op 0.70
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 3.2283 ms/op 3.7066 ms/op 0.87
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 7.0586 ms/op 10.810 ms/op 0.65
Tree 40 250000 create 656.11 ms/op 800.78 ms/op 0.82
Tree 40 250000 get(125000) 225.80 ns/op 249.67 ns/op 0.90
Tree 40 250000 set(125000) 1.8116 us/op 2.5852 us/op 0.70
Tree 40 250000 toArray() 28.065 ms/op 30.349 ms/op 0.92
Tree 40 250000 iterate all - toArray() + loop 25.456 ms/op 28.616 ms/op 0.89
Tree 40 250000 iterate all - get(i) 79.537 ms/op 87.675 ms/op 0.91
MutableVector 250000 create 17.154 ms/op 21.133 ms/op 0.81
MutableVector 250000 get(125000) 6.8960 ns/op 7.3370 ns/op 0.94
MutableVector 250000 set(125000) 360.14 ns/op 675.30 ns/op 0.53
MutableVector 250000 toArray() 4.1531 ms/op 5.0373 ms/op 0.82
MutableVector 250000 iterate all - toArray() + loop 4.2117 ms/op 5.0474 ms/op 0.83
MutableVector 250000 iterate all - get(i) 1.6064 ms/op 1.8627 ms/op 0.86
Array 250000 create 3.7577 ms/op 4.5063 ms/op 0.83
Array 250000 clone - spread 1.5875 ms/op 1.8837 ms/op 0.84
Array 250000 get(125000) 1.6830 ns/op 2.0770 ns/op 0.81
Array 250000 set(125000) 5.5870 ns/op 6.1580 ns/op 0.91
Array 250000 iterate all - loop 175.06 us/op 194.09 us/op 0.90
effectiveBalanceIncrements clone Uint8Array 300000 56.466 us/op 62.515 us/op 0.90
effectiveBalanceIncrements clone MutableVector 300000 457.00 ns/op 574.00 ns/op 0.80
effectiveBalanceIncrements rw all Uint8Array 300000 216.87 us/op 223.79 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 161.56 ms/op 156.02 ms/op 1.04
phase0 afterProcessEpoch - 250000 vs - 7PWei 132.27 ms/op 134.89 ms/op 0.98
phase0 beforeProcessEpoch - 250000 vs - 7PWei 70.744 ms/op 64.225 ms/op 1.10
altair processEpoch - mainnet_e81889 597.42 ms/op 587.72 ms/op 1.02
mainnet_e81889 - altair beforeProcessEpoch 101.05 ms/op 96.075 ms/op 1.05
mainnet_e81889 - altair processJustificationAndFinalization 26.772 us/op 15.791 us/op 1.70
mainnet_e81889 - altair processInactivityUpdates 7.1435 ms/op 7.4364 ms/op 0.96
mainnet_e81889 - altair processRewardsAndPenalties 67.292 ms/op 67.156 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 4.9210 us/op 3.2860 us/op 1.50
mainnet_e81889 - altair processSlashings 1.4760 us/op 429.00 ns/op 3.44
mainnet_e81889 - altair processEth1DataReset 1.4900 us/op 1.1180 us/op 1.33
mainnet_e81889 - altair processEffectiveBalanceUpdates 2.0453 ms/op 1.8424 ms/op 1.11
mainnet_e81889 - altair processSlashingsReset 9.2040 us/op 5.1250 us/op 1.80
mainnet_e81889 - altair processRandaoMixesReset 14.202 us/op 7.2520 us/op 1.96
mainnet_e81889 - altair processHistoricalRootsUpdate 1.4850 us/op 1.1180 us/op 1.33
mainnet_e81889 - altair processParticipationFlagUpdates 3.6440 us/op 2.2290 us/op 1.63
mainnet_e81889 - altair processSyncCommitteeUpdates 2.0050 us/op 675.00 ns/op 2.97
mainnet_e81889 - altair afterProcessEpoch 148.69 ms/op 127.83 ms/op 1.16
capella processEpoch - mainnet_e217614 2.8852 s/op 2.2671 s/op 1.27
mainnet_e217614 - capella beforeProcessEpoch 585.64 ms/op 466.14 ms/op 1.26
mainnet_e217614 - capella processJustificationAndFinalization 37.531 us/op 14.404 us/op 2.61
mainnet_e217614 - capella processInactivityUpdates 33.602 ms/op 19.486 ms/op 1.72
mainnet_e217614 - capella processRewardsAndPenalties 528.84 ms/op 401.61 ms/op 1.32
mainnet_e217614 - capella processRegistryUpdates 55.470 us/op 20.000 us/op 2.77
mainnet_e217614 - capella processSlashings 2.0470 us/op 594.00 ns/op 3.45
mainnet_e217614 - capella processEth1DataReset 1.6500 us/op 416.00 ns/op 3.97
mainnet_e217614 - capella processEffectiveBalanceUpdates 8.2470 ms/op 4.4598 ms/op 1.85
mainnet_e217614 - capella processSlashingsReset 9.5990 us/op 3.5340 us/op 2.72
mainnet_e217614 - capella processRandaoMixesReset 15.364 us/op 3.7500 us/op 4.10
mainnet_e217614 - capella processHistoricalRootsUpdate 1.8640 us/op 572.00 ns/op 3.26
mainnet_e217614 - capella processParticipationFlagUpdates 5.4240 us/op 1.6030 us/op 3.38
mainnet_e217614 - capella afterProcessEpoch 413.25 ms/op 333.19 ms/op 1.24
phase0 processEpoch - mainnet_e58758 685.47 ms/op 480.43 ms/op 1.43
mainnet_e58758 - phase0 beforeProcessEpoch 223.60 ms/op 147.61 ms/op 1.51
mainnet_e58758 - phase0 processJustificationAndFinalization 34.894 us/op 15.797 us/op 2.21
mainnet_e58758 - phase0 processRewardsAndPenalties 83.176 ms/op 55.519 ms/op 1.50
mainnet_e58758 - phase0 processRegistryUpdates 24.856 us/op 9.9400 us/op 2.50
mainnet_e58758 - phase0 processSlashings 1.4190 us/op 601.00 ns/op 2.36
mainnet_e58758 - phase0 processEth1DataReset 1.3830 us/op 489.00 ns/op 2.83
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.6781 ms/op 1.1637 ms/op 1.44
mainnet_e58758 - phase0 processSlashingsReset 8.3300 us/op 2.6810 us/op 3.11
mainnet_e58758 - phase0 processRandaoMixesReset 12.732 us/op 4.0220 us/op 3.17
mainnet_e58758 - phase0 processHistoricalRootsUpdate 1.2340 us/op 658.00 ns/op 1.88
mainnet_e58758 - phase0 processParticipationRecordUpdates 11.010 us/op 3.6420 us/op 3.02
mainnet_e58758 - phase0 afterProcessEpoch 130.79 ms/op 104.31 ms/op 1.25
phase0 processEffectiveBalanceUpdates - 250000 normalcase 2.1505 ms/op 1.4450 ms/op 1.49
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.3117 ms/op 1.8016 ms/op 1.28
altair processInactivityUpdates - 250000 normalcase 60.049 ms/op 34.428 ms/op 1.74
altair processInactivityUpdates - 250000 worstcase 46.168 ms/op 32.515 ms/op 1.42
phase0 processRegistryUpdates - 250000 normalcase 20.973 us/op 9.1250 us/op 2.30
phase0 processRegistryUpdates - 250000 badcase_full_deposits 717.59 us/op 443.12 us/op 1.62
phase0 processRegistryUpdates - 250000 worstcase 0.5 293.73 ms/op 147.50 ms/op 1.99
altair processRewardsAndPenalties - 250000 normalcase 91.954 ms/op 68.467 ms/op 1.34
altair processRewardsAndPenalties - 250000 worstcase 88.595 ms/op 64.356 ms/op 1.38
phase0 getAttestationDeltas - 250000 normalcase 14.594 ms/op 10.622 ms/op 1.37
phase0 getAttestationDeltas - 250000 worstcase 14.519 ms/op 9.4588 ms/op 1.53
phase0 processSlashings - 250000 worstcase 147.56 us/op 95.085 us/op 1.55
altair processSyncCommitteeUpdates - 250000 250.33 ms/op 167.53 ms/op 1.49
BeaconState.hashTreeRoot - No change 1.1870 us/op 392.00 ns/op 3.03
BeaconState.hashTreeRoot - 1 full validator 244.58 us/op 130.47 us/op 1.87
BeaconState.hashTreeRoot - 32 full validator 2.1804 ms/op 1.8883 ms/op 1.15
BeaconState.hashTreeRoot - 512 full validator 29.541 ms/op 21.241 ms/op 1.39
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 243.81 us/op 211.39 us/op 1.15
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 3.6051 ms/op 2.9063 ms/op 1.24
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 46.344 ms/op 36.968 ms/op 1.25
BeaconState.hashTreeRoot - 1 balances 186.01 us/op 168.47 us/op 1.10
BeaconState.hashTreeRoot - 32 balances 1.8528 ms/op 1.7335 ms/op 1.07
BeaconState.hashTreeRoot - 512 balances 18.689 ms/op 16.361 ms/op 1.14
BeaconState.hashTreeRoot - 250000 balances 305.23 ms/op 238.57 ms/op 1.28
aggregationBits - 2048 els - zipIndexesInBitList 45.201 us/op 23.156 us/op 1.95
byteArrayEquals 32 89.484 ns/op 75.970 ns/op 1.18
Buffer.compare 32 65.769 ns/op 58.022 ns/op 1.13
byteArrayEquals 1024 2.4059 us/op 2.1076 us/op 1.14
Buffer.compare 1024 79.966 ns/op 73.351 ns/op 1.09
byteArrayEquals 16384 37.082 us/op 33.478 us/op 1.11
Buffer.compare 16384 272.91 ns/op 280.66 ns/op 0.97
byteArrayEquals 123687377 263.15 ms/op 260.76 ms/op 1.01
Buffer.compare 123687377 9.5341 ms/op 7.8148 ms/op 1.22
byteArrayEquals 32 - diff last byte 86.856 ns/op 75.579 ns/op 1.15
Buffer.compare 32 - diff last byte 66.975 ns/op 58.565 ns/op 1.14
byteArrayEquals 1024 - diff last byte 2.2669 us/op 2.0856 us/op 1.09
Buffer.compare 1024 - diff last byte 77.076 ns/op 75.657 ns/op 1.02
byteArrayEquals 16384 - diff last byte 36.598 us/op 33.998 us/op 1.08
Buffer.compare 16384 - diff last byte 267.33 ns/op 254.61 ns/op 1.05
byteArrayEquals 123687377 - diff last byte 301.43 ms/op 258.94 ms/op 1.16
Buffer.compare 123687377 - diff last byte 12.631 ms/op 8.4061 ms/op 1.50
byteArrayEquals 32 - random bytes 9.3790 ns/op 5.6000 ns/op 1.67
Buffer.compare 32 - random bytes 79.613 ns/op 62.271 ns/op 1.28
byteArrayEquals 1024 - random bytes 7.3840 ns/op 5.9520 ns/op 1.24
Buffer.compare 1024 - random bytes 76.718 ns/op 66.204 ns/op 1.16
byteArrayEquals 16384 - random bytes 7.6110 ns/op 5.6230 ns/op 1.35
Buffer.compare 16384 - random bytes 71.150 ns/op 69.117 ns/op 1.03
byteArrayEquals 123687377 - random bytes 19.930 ns/op 9.0600 ns/op 2.20
Buffer.compare 123687377 - random bytes 83.900 ns/op 78.300 ns/op 1.07
regular array get 100000 times 56.369 us/op 48.015 us/op 1.17
wrappedArray get 100000 times 55.161 us/op 49.640 us/op 1.11
arrayWithProxy get 100000 times 20.878 ms/op 14.509 ms/op 1.44
ssz.Root.equals 63.014 ns/op 57.853 ns/op 1.09
byteArrayEquals 60.430 ns/op 58.140 ns/op 1.04
Buffer.compare 15.511 ns/op 11.569 ns/op 1.34
shuffle list - 16384 els 8.6661 ms/op 7.1868 ms/op 1.21
shuffle list - 250000 els 121.24 ms/op 106.34 ms/op 1.14
processSlot - 1 slots 26.513 us/op 16.854 us/op 1.57
processSlot - 32 slots 5.1886 ms/op 3.3946 ms/op 1.53
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 81.608 ms/op 60.381 ms/op 1.35
getCommitteeAssignments - req 1 vs - 250000 vc 2.8377 ms/op 2.6825 ms/op 1.06
getCommitteeAssignments - req 100 vs - 250000 vc 4.3554 ms/op 3.8977 ms/op 1.12
getCommitteeAssignments - req 1000 vs - 250000 vc 4.8268 ms/op 4.3067 ms/op 1.12
findModifiedValidators - 10000 modified validators 709.86 ms/op 576.50 ms/op 1.23
findModifiedValidators - 1000 modified validators 620.19 ms/op 464.94 ms/op 1.33
findModifiedValidators - 100 modified validators 560.10 ms/op 469.87 ms/op 1.19
findModifiedValidators - 10 modified validators 625.60 ms/op 498.14 ms/op 1.26
findModifiedValidators - 1 modified validators 674.44 ms/op 444.46 ms/op 1.52
findModifiedValidators - no difference 505.21 ms/op 471.36 ms/op 1.07
compare ViewDUs 5.4580 s/op 5.4867 s/op 0.99
compare each validator Uint8Array 2.3676 s/op 2.2965 s/op 1.03
compare ViewDU to Uint8Array 1.6431 s/op 1.5671 s/op 1.05
migrate state 1000000 validators, 24 modified, 0 new 1.0845 s/op 930.89 ms/op 1.16
migrate state 1000000 validators, 1700 modified, 1000 new 1.3963 s/op 1.1415 s/op 1.22
migrate state 1000000 validators, 3400 modified, 2000 new 1.8585 s/op 1.4727 s/op 1.26
migrate state 1500000 validators, 24 modified, 0 new 1.2869 s/op 949.26 ms/op 1.36
migrate state 1500000 validators, 1700 modified, 1000 new 1.8448 s/op 1.4166 s/op 1.30
migrate state 1500000 validators, 3400 modified, 2000 new 2.0925 s/op 1.7594 s/op 1.19
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 6.8700 ns/op 5.6100 ns/op 1.22
state getBlockRootAtSlot - 250000 vs - 7PWei 883.47 ns/op 785.74 ns/op 1.12
computeProposers - vc 250000 12.956 ms/op 13.419 ms/op 0.97
computeEpochShuffling - vc 250000 134.47 ms/op 137.72 ms/op 0.98
getNextSyncCommittee - vc 250000 200.90 ms/op 182.59 ms/op 1.10
computeSigningRoot for AttestationData 43.818 us/op 35.831 us/op 1.22
hash AttestationData serialized data then Buffer.toString(base64) 2.9274 us/op 2.7717 us/op 1.06
toHexString serialized data 2.1622 us/op 1.3643 us/op 1.58
Buffer.toString(base64) 433.81 ns/op 292.11 ns/op 1.49

by benchmarkbot/action

@nflaig nflaig enabled auto-merge (squash) February 22, 2024 13:57
@nflaig nflaig merged commit c999e4a into unstable Feb 22, 2024
17 of 20 checks passed
@nflaig nflaig deleted the nflaig/rename-retryAttempts branch February 22, 2024 14:04
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.17.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ensi321 ensi321 ensi321 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nflaig @wemeetagain @ensi321