Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: remove duplicate debug logs upload step #6474

Merged
merged 1 commit into from Feb 22, 2024
Merged

ci: remove duplicate debug logs upload step #6474

merged 1 commit into from Feb 22, 2024

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Feb 22, 2024

Motivation

https://github.com/ChainSafe/lodestar/actions/runs/8006063823/job/21866912900#step:19:20

image

Description

Remove duplicate debug logs upload step causing 409 error. See related issue actions/upload-artifact#478, previously v3 would just override files while v4 now throws an error.

@nflaig nflaig requested a review from a team as a code owner February 22, 2024 19:34
@codecov Codecov
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Merging #6474 (9238ef1) into unstable (8959bda) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6474   +/-   ##
=========================================
  Coverage     61.66%   61.66%           
=========================================
  Files           554      554           
  Lines         58078    58078           
  Branches       1837     1837           
=========================================
  Hits          35811    35811           
  Misses        22228    22228           
  Partials         39       39

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 07e8674 Previous: 8959bda Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 591.13 us/op 386.77 us/op 1.53
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 80.678 us/op 52.713 us/op 1.53
BLS verify - blst-native 1.1181 ms/op 1.1065 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.5168 ms/op 2.4125 ms/op 1.04
BLS verifyMultipleSignatures 8 - blst-native 5.3284 ms/op 5.2622 ms/op 1.01
BLS verifyMultipleSignatures 32 - blst-native 19.555 ms/op 19.393 ms/op 1.01
BLS verifyMultipleSignatures 64 - blst-native 38.598 ms/op 38.213 ms/op 1.01
BLS verifyMultipleSignatures 128 - blst-native 79.728 ms/op 75.454 ms/op 1.06
BLS deserializing 10000 signatures 818.63 ms/op 797.14 ms/op 1.03
BLS deserializing 100000 signatures 8.8220 s/op 8.2573 s/op 1.07
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.2194 ms/op 1.1121 ms/op 1.10
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.3595 ms/op 1.2572 ms/op 1.08
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.1624 ms/op 1.9712 ms/op 1.10
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.3058 ms/op 3.7683 ms/op 1.14
BLS verifyMultipleSignatures - same message - 128 - blst-native 5.1587 ms/op 4.8938 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 25.190 us/op 22.071 us/op 1.14
BLS aggregatePubkeys 128 - blst-native 94.609 us/op 86.402 us/op 1.09
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 45.686 ms/op 45.012 ms/op 1.01
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 47.091 ms/op 42.561 ms/op 1.11
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 27.838 ms/op 25.926 ms/op 1.07
getSlashingsAndExits - default max 115.45 us/op 223.06 us/op 0.52
getSlashingsAndExits - 2k 347.07 us/op 350.91 us/op 0.99
proposeBlockBody type=full, size=empty 3.8159 ms/op 3.7844 ms/op 1.01
isKnown best case - 1 super set check 351.00 ns/op 474.00 ns/op 0.74
isKnown normal case - 2 super set checks 341.00 ns/op 389.00 ns/op 0.88
isKnown worse case - 16 super set checks 336.00 ns/op 340.00 ns/op 0.99
CheckpointStateCache - add get delete 4.4450 us/op 3.7860 us/op 1.17
validate api signedAggregateAndProof - struct 2.3200 ms/op 2.3719 ms/op 0.98
validate gossip signedAggregateAndProof - struct 2.4231 ms/op 2.2532 ms/op 1.08
validate gossip attestation - vc 640000 1.1395 ms/op 1.1302 ms/op 1.01
batch validate gossip attestation - vc 640000 - chunk 32 138.88 us/op 138.19 us/op 1.01
batch validate gossip attestation - vc 640000 - chunk 64 121.94 us/op 128.71 us/op 0.95
batch validate gossip attestation - vc 640000 - chunk 128 122.55 us/op 124.56 us/op 0.98
batch validate gossip attestation - vc 640000 - chunk 256 114.80 us/op 114.03 us/op 1.01
pickEth1Vote - no votes 1.0581 ms/op 874.46 us/op 1.21
pickEth1Vote - max votes 9.8048 ms/op 9.2615 ms/op 1.06
pickEth1Vote - Eth1Data hashTreeRoot value x2048 18.539 ms/op 21.090 ms/op 0.88
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 33.970 ms/op 26.025 ms/op 1.31
pickEth1Vote - Eth1Data fastSerialize value x2048 445.08 us/op 412.58 us/op 1.08
pickEth1Vote - Eth1Data fastSerialize tree x2048 9.3964 ms/op 5.8079 ms/op 1.62
bytes32 toHexString 518.00 ns/op 458.00 ns/op 1.13
bytes32 Buffer.toString(hex) 344.00 ns/op 311.00 ns/op 1.11
bytes32 Buffer.toString(hex) from Uint8Array 553.00 ns/op 447.00 ns/op 1.24
bytes32 Buffer.toString(hex) + 0x 365.00 ns/op 309.00 ns/op 1.18
Object access 1 prop 0.22600 ns/op 0.22000 ns/op 1.03
Map access 1 prop 0.20100 ns/op 0.20700 ns/op 0.97
Object get x1000 5.9020 ns/op 4.8920 ns/op 1.21
Map get x1000 0.78300 ns/op 0.75400 ns/op 1.04
Object set x1000 25.790 ns/op 25.506 ns/op 1.01
Map set x1000 18.582 ns/op 18.433 ns/op 1.01
Return object 10000 times 0.24530 ns/op 0.22100 ns/op 1.11
Throw Error 10000 times 2.8863 us/op 2.6150 us/op 1.10
fastMsgIdFn sha256 / 200 bytes 2.1750 us/op 1.9720 us/op 1.10
fastMsgIdFn h32 xxhash / 200 bytes 346.00 ns/op 322.00 ns/op 1.07
fastMsgIdFn h64 xxhash / 200 bytes 429.00 ns/op 340.00 ns/op 1.26
fastMsgIdFn sha256 / 1000 bytes 6.7560 us/op 5.9550 us/op 1.13
fastMsgIdFn h32 xxhash / 1000 bytes 516.00 ns/op 446.00 ns/op 1.16
fastMsgIdFn h64 xxhash / 1000 bytes 483.00 ns/op 427.00 ns/op 1.13
fastMsgIdFn sha256 / 10000 bytes 56.297 us/op 50.483 us/op 1.12
fastMsgIdFn h32 xxhash / 10000 bytes 1.9730 us/op 1.7950 us/op 1.10
fastMsgIdFn h64 xxhash / 10000 bytes 1.3680 us/op 1.2490 us/op 1.10
send data - 1000 256B messages 17.296 ms/op 13.509 ms/op 1.28
send data - 1000 512B messages 22.114 ms/op 16.686 ms/op 1.33
send data - 1000 1024B messages 34.797 ms/op 31.195 ms/op 1.12
send data - 1000 1200B messages 36.530 ms/op 30.750 ms/op 1.19
send data - 1000 2048B messages 43.255 ms/op 38.646 ms/op 1.12
send data - 1000 4096B messages 37.919 ms/op 38.966 ms/op 0.97
send data - 1000 16384B messages 106.41 ms/op 92.689 ms/op 1.15
send data - 1000 65536B messages 468.07 ms/op 456.11 ms/op 1.03
enrSubnets - fastDeserialize 64 bits 1.2720 us/op 1.0360 us/op 1.23
enrSubnets - ssz BitVector 64 bits 652.00 ns/op 502.00 ns/op 1.30
enrSubnets - fastDeserialize 4 bits 307.00 ns/op 254.00 ns/op 1.21
enrSubnets - ssz BitVector 4 bits 602.00 ns/op 515.00 ns/op 1.17
prioritizePeers score -10:0 att 32-0.1 sync 2-0 96.400 us/op 103.95 us/op 0.93
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 112.61 us/op 114.04 us/op 0.99
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 151.91 us/op 146.76 us/op 1.04
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 258.39 us/op 260.80 us/op 0.99
prioritizePeers score 0:0 att 64-1 sync 4-1 294.77 us/op 277.13 us/op 1.06
array of 16000 items push then shift 1.3873 us/op 1.3783 us/op 1.01
LinkedList of 16000 items push then shift 8.4490 ns/op 8.5800 ns/op 0.98
array of 16000 items push then pop 113.17 ns/op 113.41 ns/op 1.00
LinkedList of 16000 items push then pop 6.3050 ns/op 7.7260 ns/op 0.82
array of 24000 items push then shift 1.9773 us/op 1.8896 us/op 1.05
LinkedList of 24000 items push then shift 7.9810 ns/op 7.5310 ns/op 1.06
array of 24000 items push then pop 156.07 ns/op 150.20 ns/op 1.04
LinkedList of 24000 items push then pop 7.4890 ns/op 6.0850 ns/op 1.23
intersect bitArray bitLen 8 4.8810 ns/op 4.9080 ns/op 0.99
intersect array and set length 8 67.069 ns/op 50.458 ns/op 1.33
intersect bitArray bitLen 128 30.213 ns/op 29.444 ns/op 1.03
intersect array and set length 128 953.81 ns/op 696.32 ns/op 1.37
bitArray.getTrueBitIndexes() bitLen 128 1.6670 us/op 1.3890 us/op 1.20
bitArray.getTrueBitIndexes() bitLen 248 2.9450 us/op 2.9850 us/op 0.99
bitArray.getTrueBitIndexes() bitLen 512 6.0490 us/op 6.3790 us/op 0.95
Buffer.concat 32 items 1.0050 us/op 1.0400 us/op 0.97
Uint8Array.set 32 items 2.0080 us/op 2.3270 us/op 0.86
Set add up to 64 items then delete first 2.6357 us/op 2.4738 us/op 1.07
OrderedSet add up to 64 items then delete first 2.9930 us/op 3.8685 us/op 0.77
Set add up to 64 items then delete last 2.3140 us/op 2.7309 us/op 0.85
OrderedSet add up to 64 items then delete last 3.3627 us/op 3.7934 us/op 0.89
Set add up to 64 items then delete middle 2.1431 us/op 2.3774 us/op 0.90
OrderedSet add up to 64 items then delete middle 5.9548 us/op 5.2910 us/op 1.13
Set add up to 128 items then delete first 5.9218 us/op 5.0557 us/op 1.17
OrderedSet add up to 128 items then delete first 9.2090 us/op 8.5599 us/op 1.08
Set add up to 128 items then delete last 5.5651 us/op 5.4318 us/op 1.02
OrderedSet add up to 128 items then delete last 8.1700 us/op 8.5114 us/op 0.96
Set add up to 128 items then delete middle 4.7836 us/op 5.1232 us/op 0.93
OrderedSet add up to 128 items then delete middle 11.543 us/op 13.268 us/op 0.87
Set add up to 256 items then delete first 8.6219 us/op 11.025 us/op 0.78
OrderedSet add up to 256 items then delete first 13.707 us/op 16.499 us/op 0.83
Set add up to 256 items then delete last 8.0569 us/op 10.382 us/op 0.78
OrderedSet add up to 256 items then delete last 13.234 us/op 15.686 us/op 0.84
Set add up to 256 items then delete middle 8.4114 us/op 10.915 us/op 0.77
OrderedSet add up to 256 items then delete middle 36.588 us/op 36.435 us/op 1.00
transfer serialized Status (84 B) 1.7440 us/op 1.5920 us/op 1.10
copy serialized Status (84 B) 1.5340 us/op 1.3100 us/op 1.17
transfer serialized SignedVoluntaryExit (112 B) 1.9850 us/op 1.7400 us/op 1.14
copy serialized SignedVoluntaryExit (112 B) 1.6210 us/op 1.3480 us/op 1.20
transfer serialized ProposerSlashing (416 B) 2.4510 us/op 2.3590 us/op 1.04
copy serialized ProposerSlashing (416 B) 2.6840 us/op 2.4810 us/op 1.08
transfer serialized Attestation (485 B) 2.4450 us/op 2.7570 us/op 0.89
copy serialized Attestation (485 B) 2.4680 us/op 2.6620 us/op 0.93
transfer serialized AttesterSlashing (33232 B) 2.3520 us/op 2.8950 us/op 0.81
copy serialized AttesterSlashing (33232 B) 6.1810 us/op 10.299 us/op 0.60
transfer serialized Small SignedBeaconBlock (128000 B) 2.7070 us/op 2.8030 us/op 0.97
copy serialized Small SignedBeaconBlock (128000 B) 31.866 us/op 11.933 us/op 2.67
transfer serialized Avg SignedBeaconBlock (200000 B) 2.5050 us/op 2.4200 us/op 1.04
copy serialized Avg SignedBeaconBlock (200000 B) 53.768 us/op 56.162 us/op 0.96
transfer serialized BlobsSidecar (524380 B) 2.8590 us/op 2.6150 us/op 1.09
copy serialized BlobsSidecar (524380 B) 93.812 us/op 75.719 us/op 1.24
transfer serialized Big SignedBeaconBlock (1000000 B) 3.1480 us/op 2.6830 us/op 1.17
copy serialized Big SignedBeaconBlock (1000000 B) 169.06 us/op 292.08 us/op 0.58
pass gossip attestations to forkchoice per slot 3.4108 ms/op 2.9304 ms/op 1.16
forkChoice updateHead vc 100000 bc 64 eq 0 512.50 us/op 492.15 us/op 1.04
forkChoice updateHead vc 600000 bc 64 eq 0 2.8422 ms/op 3.2767 ms/op 0.87
forkChoice updateHead vc 1000000 bc 64 eq 0 5.0460 ms/op 6.3741 ms/op 0.79
forkChoice updateHead vc 600000 bc 320 eq 0 2.7945 ms/op 2.6594 ms/op 1.05
forkChoice updateHead vc 600000 bc 1200 eq 0 2.8644 ms/op 2.8068 ms/op 1.02
forkChoice updateHead vc 600000 bc 7200 eq 0 3.9829 ms/op 3.5648 ms/op 1.12
forkChoice updateHead vc 600000 bc 64 eq 1000 10.665 ms/op 9.8837 ms/op 1.08
forkChoice updateHead vc 600000 bc 64 eq 10000 10.329 ms/op 9.6663 ms/op 1.07
forkChoice updateHead vc 600000 bc 64 eq 300000 13.459 ms/op 12.158 ms/op 1.11
computeDeltas 500000 validators 300 proto nodes 3.6281 ms/op 3.3531 ms/op 1.08
computeDeltas 500000 validators 1200 proto nodes 3.4045 ms/op 3.3802 ms/op 1.01
computeDeltas 500000 validators 7200 proto nodes 3.2138 ms/op 3.2492 ms/op 0.99
computeDeltas 750000 validators 300 proto nodes 4.9612 ms/op 5.4233 ms/op 0.91
computeDeltas 750000 validators 1200 proto nodes 5.0054 ms/op 5.1672 ms/op 0.97
computeDeltas 750000 validators 7200 proto nodes 4.7446 ms/op 5.5880 ms/op 0.85
computeDeltas 1400000 validators 300 proto nodes 9.3714 ms/op 10.850 ms/op 0.86
computeDeltas 1400000 validators 1200 proto nodes 9.2043 ms/op 10.587 ms/op 0.87
computeDeltas 1400000 validators 7200 proto nodes 9.5673 ms/op 9.3930 ms/op 1.02
computeDeltas 2100000 validators 300 proto nodes 13.707 ms/op 15.580 ms/op 0.88
computeDeltas 2100000 validators 1200 proto nodes 14.043 ms/op 16.707 ms/op 0.84
computeDeltas 2100000 validators 7200 proto nodes 14.023 ms/op 14.448 ms/op 0.97
altair processAttestation - 250000 vs - 7PWei normalcase 2.0452 ms/op 1.5358 ms/op 1.33
altair processAttestation - 250000 vs - 7PWei worstcase 2.6261 ms/op 2.6276 ms/op 1.00
altair processAttestation - setStatus - 1/6 committees join 112.19 us/op 75.732 us/op 1.48
altair processAttestation - setStatus - 1/3 committees join 218.51 us/op 158.53 us/op 1.38
altair processAttestation - setStatus - 1/2 committees join 306.23 us/op 214.24 us/op 1.43
altair processAttestation - setStatus - 2/3 committees join 393.19 us/op 284.28 us/op 1.38
altair processAttestation - setStatus - 4/5 committees join 528.17 us/op 446.22 us/op 1.18
altair processAttestation - setStatus - 100% committees join 640.42 us/op 555.52 us/op 1.15
altair processBlock - 250000 vs - 7PWei normalcase 8.0588 ms/op 8.8400 ms/op 0.91
altair processBlock - 250000 vs - 7PWei normalcase hashState 36.757 ms/op 23.593 ms/op 1.56
altair processBlock - 250000 vs - 7PWei worstcase 34.562 ms/op 28.896 ms/op 1.20
altair processBlock - 250000 vs - 7PWei worstcase hashState 81.735 ms/op 73.332 ms/op 1.11
phase0 processBlock - 250000 vs - 7PWei normalcase 2.6276 ms/op 2.5752 ms/op 1.02
phase0 processBlock - 250000 vs - 7PWei worstcase 27.447 ms/op 24.642 ms/op 1.11
altair processEth1Data - 250000 vs - 7PWei normalcase 445.74 us/op 304.15 us/op 1.47
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 8.5740 us/op 14.982 us/op 0.57
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 38.613 us/op 57.881 us/op 0.67
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 15.022 us/op 21.257 us/op 0.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 13.130 us/op 8.3040 us/op 1.58
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 180.69 us/op 155.26 us/op 1.16
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1289 ms/op 1.0416 ms/op 1.08
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 958.44 us/op 1.4487 ms/op 0.66
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.0611 ms/op 1.0319 ms/op 1.03
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 2.4796 ms/op 3.0478 ms/op 0.81
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 1.8644 ms/op 1.5104 ms/op 1.23
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 3.8213 ms/op 5.4104 ms/op 0.71
Tree 40 250000 create 239.12 ms/op 348.45 ms/op 0.69
Tree 40 250000 get(125000) 117.58 ns/op 122.11 ns/op 0.96
Tree 40 250000 set(125000) 770.91 ns/op 841.70 ns/op 0.92
Tree 40 250000 toArray() 11.179 ms/op 25.457 ms/op 0.44
Tree 40 250000 iterate all - toArray() + loop 12.009 ms/op 26.073 ms/op 0.46
Tree 40 250000 iterate all - get(i) 43.444 ms/op 54.605 ms/op 0.80
MutableVector 250000 create 8.9039 ms/op 12.246 ms/op 0.73
MutableVector 250000 get(125000) 6.1100 ns/op 5.7150 ns/op 1.07
MutableVector 250000 set(125000) 216.46 ns/op 221.35 ns/op 0.98
MutableVector 250000 toArray() 2.2699 ms/op 2.4479 ms/op 0.93
MutableVector 250000 iterate all - toArray() + loop 3.6169 ms/op 2.4492 ms/op 1.48
MutableVector 250000 iterate all - get(i) 1.3379 ms/op 1.3476 ms/op 0.99
Array 250000 create 2.6715 ms/op 2.3086 ms/op 1.16
Array 250000 clone - spread 1.2836 ms/op 1.1861 ms/op 1.08
Array 250000 get(125000) 1.1000 ns/op 1.0660 ns/op 1.03
Array 250000 set(125000) 1.5120 ns/op 2.0970 ns/op 0.72
Array 250000 iterate all - loop 159.47 us/op 155.19 us/op 1.03
effectiveBalanceIncrements clone Uint8Array 300000 16.129 us/op 53.953 us/op 0.30
effectiveBalanceIncrements clone MutableVector 300000 496.00 ns/op 906.00 ns/op 0.55
effectiveBalanceIncrements rw all Uint8Array 300000 208.61 us/op 184.71 us/op 1.13
effectiveBalanceIncrements rw all MutableVector 300000 72.817 ms/op 113.57 ms/op 0.64
phase0 afterProcessEpoch - 250000 vs - 7PWei 78.370 ms/op 78.605 ms/op 1.00
phase0 beforeProcessEpoch - 250000 vs - 7PWei 46.218 ms/op 35.742 ms/op 1.29
altair processEpoch - mainnet_e81889 445.82 ms/op 472.21 ms/op 0.94
mainnet_e81889 - altair beforeProcessEpoch 73.126 ms/op 84.059 ms/op 0.87
mainnet_e81889 - altair processJustificationAndFinalization 13.148 us/op 14.334 us/op 0.92
mainnet_e81889 - altair processInactivityUpdates 6.9422 ms/op 3.8011 ms/op 1.83
mainnet_e81889 - altair processRewardsAndPenalties 54.648 ms/op 54.907 ms/op 1.00
mainnet_e81889 - altair processRegistryUpdates 1.9200 us/op 2.1410 us/op 0.90
mainnet_e81889 - altair processSlashings 678.00 ns/op 641.00 ns/op 1.06
mainnet_e81889 - altair processEth1DataReset 633.00 ns/op 720.00 ns/op 0.88
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.0844 ms/op 1.0622 ms/op 1.02
mainnet_e81889 - altair processSlashingsReset 4.9130 us/op 2.8640 us/op 1.72
mainnet_e81889 - altair processRandaoMixesReset 4.2660 us/op 4.4560 us/op 0.96
mainnet_e81889 - altair processHistoricalRootsUpdate 1.0150 us/op 1.0610 us/op 0.96
mainnet_e81889 - altair processParticipationFlagUpdates 3.1650 us/op 2.0930 us/op 1.51
mainnet_e81889 - altair processSyncCommitteeUpdates 853.00 ns/op 800.00 ns/op 1.07
mainnet_e81889 - altair afterProcessEpoch 84.074 ms/op 80.468 ms/op 1.04
capella processEpoch - mainnet_e217614 1.8843 s/op 2.2908 s/op 0.82
mainnet_e217614 - capella beforeProcessEpoch 432.05 ms/op 493.64 ms/op 0.88
mainnet_e217614 - capella processJustificationAndFinalization 16.176 us/op 11.707 us/op 1.38
mainnet_e217614 - capella processInactivityUpdates 20.797 ms/op 16.809 ms/op 1.24
mainnet_e217614 - capella processRewardsAndPenalties 381.38 ms/op 408.24 ms/op 0.93
mainnet_e217614 - capella processRegistryUpdates 26.817 us/op 26.900 us/op 1.00
mainnet_e217614 - capella processSlashings 890.00 ns/op 834.00 ns/op 1.07
mainnet_e217614 - capella processEth1DataReset 740.00 ns/op 607.00 ns/op 1.22
mainnet_e217614 - capella processEffectiveBalanceUpdates 3.7184 ms/op 3.5460 ms/op 1.05
mainnet_e217614 - capella processSlashingsReset 4.2810 us/op 4.0820 us/op 1.05
mainnet_e217614 - capella processRandaoMixesReset 6.8130 us/op 6.3540 us/op 1.07
mainnet_e217614 - capella processHistoricalRootsUpdate 753.00 ns/op 740.00 ns/op 1.02
mainnet_e217614 - capella processParticipationFlagUpdates 1.5810 us/op 3.4750 us/op 0.45
mainnet_e217614 - capella afterProcessEpoch 255.98 ms/op 249.28 ms/op 1.03
phase0 processEpoch - mainnet_e58758 421.25 ms/op 481.82 ms/op 0.87
mainnet_e58758 - phase0 beforeProcessEpoch 123.99 ms/op 155.49 ms/op 0.80
mainnet_e58758 - phase0 processJustificationAndFinalization 16.881 us/op 17.263 us/op 0.98
mainnet_e58758 - phase0 processRewardsAndPenalties 44.584 ms/op 48.699 ms/op 0.92
mainnet_e58758 - phase0 processRegistryUpdates 13.056 us/op 10.676 us/op 1.22
mainnet_e58758 - phase0 processSlashings 1.0490 us/op 650.00 ns/op 1.61
mainnet_e58758 - phase0 processEth1DataReset 552.00 ns/op 918.00 ns/op 0.60
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 956.83 us/op 1.2024 ms/op 0.80
mainnet_e58758 - phase0 processSlashingsReset 4.3340 us/op 3.3100 us/op 1.31
mainnet_e58758 - phase0 processRandaoMixesReset 5.4670 us/op 4.5170 us/op 1.21
mainnet_e58758 - phase0 processHistoricalRootsUpdate 878.00 ns/op 808.00 ns/op 1.09
mainnet_e58758 - phase0 processParticipationRecordUpdates 4.6360 us/op 5.0270 us/op 0.92
mainnet_e58758 - phase0 afterProcessEpoch 65.338 ms/op 69.275 ms/op 0.94
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.0531 ms/op 1.1321 ms/op 0.93
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.1737 ms/op 1.1581 ms/op 1.01
altair processInactivityUpdates - 250000 normalcase 20.887 ms/op 24.925 ms/op 0.84
altair processInactivityUpdates - 250000 worstcase 24.629 ms/op 25.949 ms/op 0.95
phase0 processRegistryUpdates - 250000 normalcase 8.3330 us/op 11.290 us/op 0.74
phase0 processRegistryUpdates - 250000 badcase_full_deposits 423.67 us/op 454.13 us/op 0.93
phase0 processRegistryUpdates - 250000 worstcase 0.5 135.04 ms/op 112.40 ms/op 1.20
altair processRewardsAndPenalties - 250000 normalcase 47.569 ms/op 45.606 ms/op 1.04
altair processRewardsAndPenalties - 250000 worstcase 48.267 ms/op 55.275 ms/op 0.87
phase0 getAttestationDeltas - 250000 normalcase 5.6464 ms/op 6.6142 ms/op 0.85
phase0 getAttestationDeltas - 250000 worstcase 7.3949 ms/op 7.1375 ms/op 1.04
phase0 processSlashings - 250000 worstcase 92.545 us/op 90.993 us/op 1.02
altair processSyncCommitteeUpdates - 250000 124.84 ms/op 114.25 ms/op 1.09
BeaconState.hashTreeRoot - No change 438.00 ns/op 400.00 ns/op 1.09
BeaconState.hashTreeRoot - 1 full validator 126.67 us/op 99.395 us/op 1.27
BeaconState.hashTreeRoot - 32 full validator 1.3789 ms/op 1.2990 ms/op 1.06
BeaconState.hashTreeRoot - 512 full validator 13.446 ms/op 11.733 ms/op 1.15
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 164.72 us/op 115.72 us/op 1.42
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 1.8937 ms/op 1.5978 ms/op 1.19
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 25.081 ms/op 29.077 ms/op 0.86
BeaconState.hashTreeRoot - 1 balances 103.99 us/op 105.56 us/op 0.99
BeaconState.hashTreeRoot - 32 balances 1.0766 ms/op 1.0607 ms/op 1.01
BeaconState.hashTreeRoot - 512 balances 12.107 ms/op 10.568 ms/op 1.15
BeaconState.hashTreeRoot - 250000 balances 225.97 ms/op 198.88 ms/op 1.14
aggregationBits - 2048 els - zipIndexesInBitList 15.296 us/op 10.883 us/op 1.41
byteArrayEquals 32 65.462 ns/op 65.235 ns/op 1.00
Buffer.compare 32 37.836 ns/op 38.035 ns/op 0.99
byteArrayEquals 1024 1.7702 us/op 1.7410 us/op 1.02
Buffer.compare 1024 46.379 ns/op 44.052 ns/op 1.05
byteArrayEquals 16384 28.445 us/op 27.811 us/op 1.02
Buffer.compare 16384 244.88 ns/op 227.19 ns/op 1.08
byteArrayEquals 123687377 225.16 ms/op 207.50 ms/op 1.09
Buffer.compare 123687377 5.1134 ms/op 3.8142 ms/op 1.34
byteArrayEquals 32 - diff last byte 64.420 ns/op 61.457 ns/op 1.05
Buffer.compare 32 - diff last byte 43.776 ns/op 37.816 ns/op 1.16
byteArrayEquals 1024 - diff last byte 1.9521 us/op 1.7162 us/op 1.14
Buffer.compare 1024 - diff last byte 56.076 ns/op 45.785 ns/op 1.22
byteArrayEquals 16384 - diff last byte 29.963 us/op 27.584 us/op 1.09
Buffer.compare 16384 - diff last byte 221.08 ns/op 207.27 ns/op 1.07
byteArrayEquals 123687377 - diff last byte 250.75 ms/op 204.99 ms/op 1.22
Buffer.compare 123687377 - diff last byte 6.8349 ms/op 5.9454 ms/op 1.15
byteArrayEquals 32 - random bytes 5.9920 ns/op 4.7510 ns/op 1.26
Buffer.compare 32 - random bytes 42.003 ns/op 43.743 ns/op 0.96
byteArrayEquals 1024 - random bytes 5.8440 ns/op 4.7270 ns/op 1.24
Buffer.compare 1024 - random bytes 39.757 ns/op 38.155 ns/op 1.04
byteArrayEquals 16384 - random bytes 6.3310 ns/op 4.9570 ns/op 1.28
Buffer.compare 16384 - random bytes 43.634 ns/op 40.818 ns/op 1.07
byteArrayEquals 123687377 - random bytes 9.7400 ns/op 8.4600 ns/op 1.15
Buffer.compare 123687377 - random bytes 56.950 ns/op 41.250 ns/op 1.38
regular array get 100000 times 47.825 us/op 42.245 us/op 1.13
wrappedArray get 100000 times 46.470 us/op 42.612 us/op 1.09
arrayWithProxy get 100000 times 13.324 ms/op 10.620 ms/op 1.25
ssz.Root.equals 68.666 ns/op 58.258 ns/op 1.18
byteArrayEquals 63.549 ns/op 55.227 ns/op 1.15
Buffer.compare 11.199 ns/op 9.6700 ns/op 1.16
shuffle list - 16384 els 5.4774 ms/op 4.7282 ms/op 1.16
shuffle list - 250000 els 86.399 ms/op 69.112 ms/op 1.25
processSlot - 1 slots 18.339 us/op 17.592 us/op 1.04
processSlot - 32 slots 3.1515 ms/op 3.6608 ms/op 0.86
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 58.317 ms/op 53.320 ms/op 1.09
getCommitteeAssignments - req 1 vs - 250000 vc 2.5399 ms/op 2.2331 ms/op 1.14
getCommitteeAssignments - req 100 vs - 250000 vc 3.6263 ms/op 3.3350 ms/op 1.09
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1517 ms/op 3.6079 ms/op 1.15
findModifiedValidators - 10000 modified validators 585.47 ms/op 400.04 ms/op 1.46
findModifiedValidators - 1000 modified validators 445.20 ms/op 319.39 ms/op 1.39
findModifiedValidators - 100 modified validators 417.40 ms/op 330.01 ms/op 1.26
findModifiedValidators - 10 modified validators 409.17 ms/op 296.11 ms/op 1.38
findModifiedValidators - 1 modified validators 392.79 ms/op 302.66 ms/op 1.30
findModifiedValidators - no difference 436.50 ms/op 312.43 ms/op 1.40
compare ViewDUs 4.6089 s/op 4.2675 s/op 1.08
compare each validator Uint8Array 1.9861 s/op 1.8654 s/op 1.06
compare ViewDU to Uint8Array 1.1977 s/op 1.3267 s/op 0.90
migrate state 1000000 validators, 24 modified, 0 new 820.20 ms/op 716.96 ms/op 1.14
migrate state 1000000 validators, 1700 modified, 1000 new 1.0132 s/op 1.0339 s/op 0.98
migrate state 1000000 validators, 3400 modified, 2000 new 1.2957 s/op 1.3037 s/op 0.99
migrate state 1500000 validators, 24 modified, 0 new 732.31 ms/op 715.79 ms/op 1.02
migrate state 1500000 validators, 1700 modified, 1000 new 983.68 ms/op 1.0640 s/op 0.92
migrate state 1500000 validators, 3400 modified, 2000 new 1.2908 s/op 1.3849 s/op 0.93
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.7900 ns/op 5.5800 ns/op 0.86
state getBlockRootAtSlot - 250000 vs - 7PWei 427.09 ns/op 952.58 ns/op 0.45
computeProposers - vc 250000 6.2240 ms/op 7.2513 ms/op 0.86
computeEpochShuffling - vc 250000 76.074 ms/op 71.061 ms/op 1.07
getNextSyncCommittee - vc 250000 135.05 ms/op 133.71 ms/op 1.01
computeSigningRoot for AttestationData 30.342 us/op 27.532 us/op 1.10
hash AttestationData serialized data then Buffer.toString(base64) 1.4418 us/op 1.3210 us/op 1.09
toHexString serialized data 893.08 ns/op 868.66 ns/op 1.03
Buffer.toString(base64) 169.71 ns/op 213.98 ns/op 0.79

by benchmarkbot/action

@wemeetagain wemeetagain merged commit 8943ab6 into unstable Feb 22, 2024
19 of 20 checks passed
@wemeetagain wemeetagain deleted the nflaig/fix-sim-merge branch February 22, 2024 22:02
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.17.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nflaig @wemeetagain