Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update yarn links to point to classic yarn #6477

Merged

Conversation

har777
Copy link
Contributor

@har777 har777 commented Feb 24, 2024

Motivation

Lodestar uses classic yarn(1.x) but all the links in the README's point to the latest release of yarn(4.x).

Description

Yarn now points to https://classic.yarnpkg.com/lang/en/ instead of https://yarnpkg.com/

@har777 har777 requested a review from a team as a code owner February 24, 2024 06:28
@CLAassistant
Copy link

CLAassistant commented Feb 24, 2024

CLA assistant check
All committers have signed the CLA.

@nflaig nflaig changed the title fix: update yarn links to point to classic yarn chore: update yarn links to point to classic yarn Feb 24, 2024
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @har777

Copy link

codecov bot commented Feb 24, 2024

Codecov Report

Merging #6477 (98ec588) into unstable (8943ab6) will not change coverage.
Report is 1 commits behind head on unstable.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6477   +/-   ##
=========================================
  Coverage     61.72%   61.72%           
=========================================
  Files           555      555           
  Lines         58204    58204           
  Branches       1839     1839           
=========================================
  Hits          35925    35925           
  Misses        22240    22240           
  Partials         39       39           

@nflaig nflaig merged commit 06210ef into ChainSafe:unstable Feb 24, 2024
20 of 21 checks passed
@har777 har777 deleted the har777/update-yarn-installation-links branch February 24, 2024 15:09
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.17.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants