Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: pull block from peers after a cutoff if corresponding gossip blobs are seen #6534
feat: pull block from peers after a cutoff if corresponding gossip blobs are seen #6534
Changes from 1 commit
3f1024e
b87248c
79e2887
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in this case there are not enough blobs showing up, why do we
resolveBlock()
here? if it's needed in bothif
andelse
then let's put in common placeThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so that the waiting handler for blob can resolve and emit event to pull blobs (and add its peer over there)
For code cleanliness its ok to be replicated as the return follows this statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after block comes and there are not enough blobs, we already emit this event in
handleValidBeaconBlock()
, then we also emit it here. Is this a duplicate?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this is a duplicate aimed to add this peer to the peers for unknown blobs pull
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
now the block source
lodestar_import_block_by_source_total
is very tricky, it could be wrong for nowfor block, we want to know if it comes from gossip, or this function, or the above
beaconBlocksMaybeBlobsByRoot()
functionsame for blobs, we want to know % of them coming from 3 different places as above
if it's too much for this PR please have a follow up PR or track in another issue @g11tech
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes lets do a followup on this