Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add accept: application/json header to remote signer requests and improve invalid response handling #6587

Merged
merged 23 commits into from
Apr 4, 2024
Merged

fix: add accept: application/json header to remote signer requests and improve invalid response handling #6587

merged 23 commits into from
Apr 4, 2024

Commits on Mar 24, 2024

  1. fix: handle remote signer non "application/json" response content type

    @cnupy
    cnupy committed Mar 24, 2024
    Configuration menu
    Copy the full SHA
    e062c15 View commit details
    Browse the repository at this point in the history

Commits on Mar 25, 2024

  1. Merge branch 'ChainSafe:unstable' into unstable

    @cnupy
    cnupy committed Mar 25, 2024
    Configuration menu
    Copy the full SHA
    5f54826 View commit details
    Browse the repository at this point in the history

Commits on Mar 26, 2024

  1. Merge branch 'ChainSafe:unstable' into unstable

    @cnupy
    cnupy committed Mar 26, 2024
    Configuration menu
    Copy the full SHA
    b02f666 View commit details
    Browse the repository at this point in the history

Commits on Mar 27, 2024

  1. Merge branch 'ChainSafe:unstable' into unstable

    @cnupy
    cnupy committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    657caab View commit details
    Browse the repository at this point in the history

  2. restrict logger to minimal set and remove cast

    @cnupy
    cnupy committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    ecdcc6a View commit details
    Browse the repository at this point in the history

  3. Fix typo - minamal; refactor/inline response handling functions; re… 

    …move error logging and improve exception messaging for res != OK; fix content type parsing and handling of invalid content types;
    @cnupy
    cnupy committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    383b07b View commit details
    Browse the repository at this point in the history

  4. fix: exception message text

    @cnupy
    cnupy committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    23ca7ba View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Removed logger in externalSignerClient; Improved handling of response… 

    … media types;
    @cnupy
    cnupy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    8ce75ab View commit details
    Browse the repository at this point in the history

  2. fix: use response statusText as error message if response body is emp… 

    …ty (response error)
    @cnupy
    cnupy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    22f7131 View commit details
    Browse the repository at this point in the history

  3. fix: exception message text proper epmpty string check

    @cnupy
    cnupy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    6791ae3 View commit details
    Browse the repository at this point in the history

  4. fix: exception message text proper epmpty string check

    @cnupy
    cnupy committed Mar 28, 2024
    Configuration menu
    Copy the full SHA
    f36052c View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2024

  1. fix: lint errors

    @cnupy
    cnupy committed Mar 29, 2024
    Configuration menu
    Copy the full SHA
    6742089 View commit details
    Browse the repository at this point in the history

Commits on Apr 4, 2024

  1. reintroduce handleExternalSignerResponse generic function with better… 

    … error handling; add accept header to all requests;
    @cnupy
    cnupy committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    282cc86 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'ChainSafe:unstable' into unstable

    @cnupy
    cnupy committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    94580d5 View commit details
    Browse the repository at this point in the history

  3. fix: remove forgotten check in externalSignerUpCheck function

    @cnupy
    cnupy committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2b8e722 View commit details
    Browse the repository at this point in the history

  4. Simplify checking response media type

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    2696ea8 View commit details
    Browse the repository at this point in the history

  5. Include json parse error message in thrown Error

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    12b7bd9 View commit details
    Browse the repository at this point in the history

  6. Remove unnecessary string cast of err body

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    4364c8b View commit details
    Browse the repository at this point in the history

  7. Fix json parsing

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    bec5c5b View commit details
    Browse the repository at this point in the history

  8. More robust error handling

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    c3f1aa3 View commit details
    Browse the repository at this point in the history

  9. Formatting

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    3100d07 View commit details
    Browse the repository at this point in the history

  10. Simplify err body message parser

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    127909d View commit details
    Browse the repository at this point in the history

  11. Revert error handling changes

    @nflaig
    nflaig committed Apr 4, 2024
    Configuration menu
    Copy the full SHA
    facf88c View commit details
    Browse the repository at this point in the history