Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix spelling in comments #6588

Merged
merged 1 commit into from Mar 26, 2024
Merged

chore: fix spelling in comments #6588

merged 1 commit into from Mar 26, 2024

Conversation

matthewkeil
Copy link
Member

@matthewkeil matthewkeil commented Mar 25, 2024 •
edited

Description

Spelling errors submitted by @xiaoxianBoy in #6586

@matthewkeil matthewkeil requested a review from a team as a code owner March 25, 2024 05:29
@matthewkeil matthewkeil mentioned this pull request Mar 25, 2024
Closed
@codecov Codecov
Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Merging #6588 (ac0be62) into unstable (129f300) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files 
@@             Coverage Diff              @@
##           unstable    #6588      +/-   ##
============================================
- Coverage     61.49%   61.49%   -0.01%     
============================================
  Files           556      556              
  Lines         58895    58895              
  Branches       1856     1855       -1     
============================================
- Hits          36216    36215       -1     
- Misses        22638    22639       +1     
  Partials         41       41

@github-actions GitHub Actions
Copy link
Contributor

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: de8b95b Previous: 129f300 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 616.22 us/op 884.68 us/op 0.70
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 84.913 us/op 88.691 us/op 0.96
BLS verify - blst-native 1.2597 ms/op 1.2948 ms/op 0.97
BLS verifyMultipleSignatures 3 - blst-native 2.6352 ms/op 2.7264 ms/op 0.97
BLS verifyMultipleSignatures 8 - blst-native 5.9066 ms/op 5.9604 ms/op 0.99
BLS verifyMultipleSignatures 32 - blst-native 21.851 ms/op 22.190 ms/op 0.98
BLS verifyMultipleSignatures 64 - blst-native 42.548 ms/op 44.032 ms/op 0.97
BLS verifyMultipleSignatures 128 - blst-native 82.955 ms/op 86.103 ms/op 0.96
BLS deserializing 10000 signatures 910.32 ms/op 906.44 ms/op 1.00
BLS deserializing 100000 signatures 9.1093 s/op 9.5560 s/op 0.95
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.3155 ms/op 1.3686 ms/op 0.96
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.6029 ms/op 1.5428 ms/op 1.04
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.3051 ms/op 3.0066 ms/op 0.77
BLS verifyMultipleSignatures - same message - 64 - blst-native 4.3522 ms/op 4.5835 ms/op 0.95
BLS verifyMultipleSignatures - same message - 128 - blst-native 7.4255 ms/op 7.1006 ms/op 1.05
BLS aggregatePubkeys 32 - blst-native 26.958 us/op 28.288 us/op 0.95
BLS aggregatePubkeys 128 - blst-native 99.136 us/op 103.54 us/op 0.96
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 57.043 ms/op 68.533 ms/op 0.83
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 57.477 ms/op 65.038 ms/op 0.88
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 37.612 ms/op 43.175 ms/op 0.87
getSlashingsAndExits - default max 166.34 us/op 200.38 us/op 0.83
getSlashingsAndExits - 2k 501.09 us/op 443.12 us/op 1.13
proposeBlockBody type=full, size=empty 5.7136 ms/op 6.1705 ms/op 0.93
isKnown best case - 1 super set check 347.00 ns/op 407.00 ns/op 0.85
isKnown normal case - 2 super set checks 384.00 ns/op 388.00 ns/op 0.99
isKnown worse case - 16 super set checks 361.00 ns/op 406.00 ns/op 0.89
CheckpointStateCache - add get delete 6.2540 us/op 7.3520 us/op 0.85
validate api signedAggregateAndProof - struct 2.7639 ms/op 2.8548 ms/op 0.97
validate gossip signedAggregateAndProof - struct 2.7658 ms/op 2.8529 ms/op 0.97
validate gossip attestation - vc 640000 1.3130 ms/op 1.3884 ms/op 0.95
batch validate gossip attestation - vc 640000 - chunk 32 157.64 us/op 169.62 us/op 0.93
batch validate gossip attestation - vc 640000 - chunk 64 134.14 us/op 159.35 us/op 0.84
batch validate gossip attestation - vc 640000 - chunk 128 131.69 us/op 152.13 us/op 0.87
batch validate gossip attestation - vc 640000 - chunk 256 125.12 us/op 146.59 us/op 0.85
pickEth1Vote - no votes 1.1784 ms/op 1.3843 ms/op 0.85
pickEth1Vote - max votes 10.146 ms/op 15.887 ms/op 0.64
pickEth1Vote - Eth1Data hashTreeRoot value x2048 20.884 ms/op 23.449 ms/op 0.89
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 28.843 ms/op 36.142 ms/op 0.80
pickEth1Vote - Eth1Data fastSerialize value x2048 584.56 us/op 751.18 us/op 0.78
pickEth1Vote - Eth1Data fastSerialize tree x2048 7.3248 ms/op 8.7898 ms/op 0.83
bytes32 toHexString 476.00 ns/op 644.00 ns/op 0.74
bytes32 Buffer.toString(hex) 289.00 ns/op 321.00 ns/op 0.90
bytes32 Buffer.toString(hex) from Uint8Array 418.00 ns/op 530.00 ns/op 0.79
bytes32 Buffer.toString(hex) + 0x 284.00 ns/op 317.00 ns/op 0.90
Object access 1 prop 0.14900 ns/op 0.21600 ns/op 0.69
Map access 1 prop 0.13800 ns/op 0.15700 ns/op 0.88
Object get x1000 7.5010 ns/op 8.0900 ns/op 0.93
Map get x1000 0.71400 ns/op 0.87000 ns/op 0.82
Object set x1000 48.235 ns/op 68.984 ns/op 0.70
Map set x1000 37.639 ns/op 53.722 ns/op 0.70
Return object 10000 times 0.23010 ns/op 0.25390 ns/op 0.91
Throw Error 10000 times 3.8072 us/op 4.1914 us/op 0.91
fastMsgIdFn sha256 / 200 bytes 3.1970 us/op 3.4670 us/op 0.92
fastMsgIdFn h32 xxhash / 200 bytes 268.00 ns/op 352.00 ns/op 0.76
fastMsgIdFn h64 xxhash / 200 bytes 327.00 ns/op 408.00 ns/op 0.80
fastMsgIdFn sha256 / 1000 bytes 11.142 us/op 11.848 us/op 0.94
fastMsgIdFn h32 xxhash / 1000 bytes 389.00 ns/op 509.00 ns/op 0.76
fastMsgIdFn h64 xxhash / 1000 bytes 402.00 ns/op 496.00 ns/op 0.81
fastMsgIdFn sha256 / 10000 bytes 101.04 us/op 105.45 us/op 0.96
fastMsgIdFn h32 xxhash / 10000 bytes 1.8360 us/op 2.1040 us/op 0.87
fastMsgIdFn h64 xxhash / 10000 bytes 1.2700 us/op 1.3970 us/op 0.91
send data - 1000 256B messages 16.580 ms/op 22.322 ms/op 0.74
send data - 1000 512B messages 24.273 ms/op 31.646 ms/op 0.77
send data - 1000 1024B messages 40.295 ms/op 45.392 ms/op 0.89
send data - 1000 1200B messages 37.402 ms/op 46.334 ms/op 0.81
send data - 1000 2048B messages 46.286 ms/op 62.053 ms/op 0.75
send data - 1000 4096B messages 40.782 ms/op 55.827 ms/op 0.73
send data - 1000 16384B messages 109.38 ms/op 130.54 ms/op 0.84
send data - 1000 65536B messages 410.63 ms/op 523.45 ms/op 0.78
enrSubnets - fastDeserialize 64 bits 1.2470 us/op 1.9470 us/op 0.64
enrSubnets - ssz BitVector 64 bits 403.00 ns/op 556.00 ns/op 0.72
enrSubnets - fastDeserialize 4 bits 158.00 ns/op 226.00 ns/op 0.70
enrSubnets - ssz BitVector 4 bits 398.00 ns/op 524.00 ns/op 0.76
prioritizePeers score -10:0 att 32-0.1 sync 2-0 98.528 us/op 129.49 us/op 0.76
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 120.99 us/op 160.00 us/op 0.76
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 153.17 us/op 185.01 us/op 0.83
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 276.81 us/op 372.12 us/op 0.74
prioritizePeers score 0:0 att 64-1 sync 4-1 329.64 us/op 425.41 us/op 0.77
array of 16000 items push then shift 1.5910 us/op 1.7265 us/op 0.92
LinkedList of 16000 items push then shift 8.7490 ns/op 10.250 ns/op 0.85
array of 16000 items push then pop 72.625 ns/op 143.18 ns/op 0.51
LinkedList of 16000 items push then pop 8.5280 ns/op 10.221 ns/op 0.83
array of 24000 items push then shift 2.3445 us/op 2.7407 us/op 0.86
LinkedList of 24000 items push then shift 8.7440 ns/op 14.257 ns/op 0.61
array of 24000 items push then pop 100.97 ns/op 173.28 ns/op 0.58
LinkedList of 24000 items push then pop 8.5060 ns/op 10.081 ns/op 0.84
intersect bitArray bitLen 8 5.6120 ns/op 6.1110 ns/op 0.92
intersect array and set length 8 60.676 ns/op 76.997 ns/op 0.79
intersect bitArray bitLen 128 34.751 ns/op 36.974 ns/op 0.94
intersect array and set length 128 835.13 ns/op 1.1100 us/op 0.75
bitArray.getTrueBitIndexes() bitLen 128 1.4030 us/op 1.7920 us/op 0.78
bitArray.getTrueBitIndexes() bitLen 248 2.4170 us/op 3.1370 us/op 0.77
bitArray.getTrueBitIndexes() bitLen 512 4.6080 us/op 6.9830 us/op 0.66
Buffer.concat 32 items 924.00 ns/op 1.2120 us/op 0.76
Uint8Array.set 32 items 1.9970 us/op 2.2680 us/op 0.88
Set add up to 64 items then delete first 4.2722 us/op 5.1193 us/op 0.83
OrderedSet add up to 64 items then delete first 5.3774 us/op 6.8430 us/op 0.79
Set add up to 64 items then delete last 4.3375 us/op 5.6020 us/op 0.77
OrderedSet add up to 64 items then delete last 5.4145 us/op 7.2970 us/op 0.74
Set add up to 64 items then delete middle 4.3079 us/op 5.4789 us/op 0.79
OrderedSet add up to 64 items then delete middle 6.8919 us/op 7.9979 us/op 0.86
Set add up to 128 items then delete first 9.0818 us/op 11.510 us/op 0.79
OrderedSet add up to 128 items then delete first 12.125 us/op 14.549 us/op 0.83
Set add up to 128 items then delete last 8.9521 us/op 11.177 us/op 0.80
OrderedSet add up to 128 items then delete last 11.450 us/op 13.841 us/op 0.83
Set add up to 128 items then delete middle 8.9048 us/op 11.534 us/op 0.77
OrderedSet add up to 128 items then delete middle 16.533 us/op 19.779 us/op 0.84
Set add up to 256 items then delete first 18.391 us/op 24.287 us/op 0.76
OrderedSet add up to 256 items then delete first 24.635 us/op 32.914 us/op 0.75
Set add up to 256 items then delete last 17.110 us/op 22.366 us/op 0.77
OrderedSet add up to 256 items then delete last 21.886 us/op 26.031 us/op 0.84
Set add up to 256 items then delete middle 17.192 us/op 20.230 us/op 0.85
OrderedSet add up to 256 items then delete middle 42.636 us/op 54.724 us/op 0.78
transfer serialized Status (84 B) 1.5630 us/op 1.8670 us/op 0.84
copy serialized Status (84 B) 1.1800 us/op 1.3970 us/op 0.84
transfer serialized SignedVoluntaryExit (112 B) 1.7730 us/op 2.0630 us/op 0.86
copy serialized SignedVoluntaryExit (112 B) 1.3220 us/op 1.5130 us/op 0.87
transfer serialized ProposerSlashing (416 B) 2.0960 us/op 2.4140 us/op 0.87
copy serialized ProposerSlashing (416 B) 2.0030 us/op 2.0480 us/op 0.98
transfer serialized Attestation (485 B) 2.3680 us/op 2.6220 us/op 0.90
copy serialized Attestation (485 B) 1.9920 us/op 2.1020 us/op 0.95
transfer serialized AttesterSlashing (33232 B) 2.6910 us/op 2.2320 us/op 1.21
copy serialized AttesterSlashing (33232 B) 5.8830 us/op 7.5990 us/op 0.77
transfer serialized Small SignedBeaconBlock (128000 B) 2.8960 us/op 2.6090 us/op 1.11
copy serialized Small SignedBeaconBlock (128000 B) 14.084 us/op 17.361 us/op 0.81
transfer serialized Avg SignedBeaconBlock (200000 B) 3.2290 us/op 3.2510 us/op 0.99
copy serialized Avg SignedBeaconBlock (200000 B) 22.428 us/op 28.212 us/op 0.79
transfer serialized BlobsSidecar (524380 B) 2.8300 us/op 4.1760 us/op 0.68
copy serialized BlobsSidecar (524380 B) 85.097 us/op 115.85 us/op 0.73
transfer serialized Big SignedBeaconBlock (1000000 B) 2.9440 us/op 4.1420 us/op 0.71
copy serialized Big SignedBeaconBlock (1000000 B) 147.37 us/op 285.92 us/op 0.52
pass gossip attestations to forkchoice per slot 4.2642 ms/op 4.8584 ms/op 0.88
forkChoice updateHead vc 100000 bc 64 eq 0 676.83 us/op 735.41 us/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 0 4.6025 ms/op 4.8409 ms/op 0.95
forkChoice updateHead vc 1000000 bc 64 eq 0 7.1622 ms/op 7.7559 ms/op 0.92
forkChoice updateHead vc 600000 bc 320 eq 0 4.1079 ms/op 4.3787 ms/op 0.94
forkChoice updateHead vc 600000 bc 1200 eq 0 4.2282 ms/op 4.5008 ms/op 0.94
forkChoice updateHead vc 600000 bc 7200 eq 0 5.3313 ms/op 5.9784 ms/op 0.89
forkChoice updateHead vc 600000 bc 64 eq 1000 11.052 ms/op 11.781 ms/op 0.94
forkChoice updateHead vc 600000 bc 64 eq 10000 11.640 ms/op 12.712 ms/op 0.92
forkChoice updateHead vc 600000 bc 64 eq 300000 15.744 ms/op 18.691 ms/op 0.84
computeDeltas 500000 validators 300 proto nodes 6.4597 ms/op 6.9080 ms/op 0.94
computeDeltas 500000 validators 1200 proto nodes 6.4226 ms/op 7.0293 ms/op 0.91
computeDeltas 500000 validators 7200 proto nodes 6.2978 ms/op 7.0365 ms/op 0.90
computeDeltas 750000 validators 300 proto nodes 9.3347 ms/op 10.312 ms/op 0.91
computeDeltas 750000 validators 1200 proto nodes 9.4103 ms/op 10.538 ms/op 0.89
computeDeltas 750000 validators 7200 proto nodes 9.4880 ms/op 10.458 ms/op 0.91
computeDeltas 1400000 validators 300 proto nodes 18.163 ms/op 18.862 ms/op 0.96
computeDeltas 1400000 validators 1200 proto nodes 18.030 ms/op 19.320 ms/op 0.93
computeDeltas 1400000 validators 7200 proto nodes 18.408 ms/op 20.263 ms/op 0.91
computeDeltas 2100000 validators 300 proto nodes 28.314 ms/op 30.584 ms/op 0.93
computeDeltas 2100000 validators 1200 proto nodes 29.007 ms/op 31.010 ms/op 0.94
computeDeltas 2100000 validators 7200 proto nodes 28.851 ms/op 30.405 ms/op 0.95
altair processAttestation - 250000 vs - 7PWei normalcase 2.6737 ms/op 3.0873 ms/op 0.87
altair processAttestation - 250000 vs - 7PWei worstcase 3.6676 ms/op 5.3567 ms/op 0.68
altair processAttestation - setStatus - 1/6 committees join 190.66 us/op 158.29 us/op 1.20
altair processAttestation - setStatus - 1/3 committees join 348.97 us/op 315.68 us/op 1.11
altair processAttestation - setStatus - 1/2 committees join 474.99 us/op 403.04 us/op 1.18
altair processAttestation - setStatus - 2/3 committees join 594.09 us/op 533.65 us/op 1.11
altair processAttestation - setStatus - 4/5 committees join 815.23 us/op 738.25 us/op 1.10
altair processAttestation - setStatus - 100% committees join 940.25 us/op 909.33 us/op 1.03
altair processBlock - 250000 vs - 7PWei normalcase 10.707 ms/op 9.8579 ms/op 1.09
altair processBlock - 250000 vs - 7PWei normalcase hashState 34.937 ms/op 45.426 ms/op 0.77
altair processBlock - 250000 vs - 7PWei worstcase 40.434 ms/op 45.065 ms/op 0.90
altair processBlock - 250000 vs - 7PWei worstcase hashState 95.802 ms/op 117.38 ms/op 0.82
phase0 processBlock - 250000 vs - 7PWei normalcase 2.8482 ms/op 4.2100 ms/op 0.68
phase0 processBlock - 250000 vs - 7PWei worstcase 31.761 ms/op 32.959 ms/op 0.96
altair processEth1Data - 250000 vs - 7PWei normalcase 488.27 us/op 538.14 us/op 0.91
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 9.0210 us/op 19.446 us/op 0.46
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 66.542 us/op 99.374 us/op 0.67
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 17.617 us/op 18.016 us/op 0.98
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 15.567 us/op 21.598 us/op 0.72
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 181.72 us/op 199.16 us/op 0.91
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.1638 ms/op 2.0617 ms/op 0.56
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.5987 ms/op 2.2621 ms/op 0.71
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.6171 ms/op 2.3909 ms/op 0.68
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.3548 ms/op 4.9861 ms/op 0.67
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.7563 ms/op 3.0791 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 5.5938 ms/op 6.8306 ms/op 0.82
Tree 40 250000 create 372.28 ms/op 444.06 ms/op 0.84
Tree 40 250000 get(125000) 208.59 ns/op 220.07 ns/op 0.95
Tree 40 250000 set(125000) 1.1432 us/op 1.1092 us/op 1.03
Tree 40 250000 toArray() 24.783 ms/op 25.064 ms/op 0.99
Tree 40 250000 iterate all - toArray() + loop 21.909 ms/op 30.181 ms/op 0.73
Tree 40 250000 iterate all - get(i) 69.650 ms/op 104.99 ms/op 0.66
MutableVector 250000 create 13.849 ms/op 28.625 ms/op 0.48
MutableVector 250000 get(125000) 6.5660 ns/op 11.723 ns/op 0.56
MutableVector 250000 set(125000) 287.01 ns/op 1.0377 us/op 0.28
MutableVector 250000 toArray() 3.7024 ms/op 6.9044 ms/op 0.54
MutableVector 250000 iterate all - toArray() + loop 4.0575 ms/op 5.3611 ms/op 0.76
MutableVector 250000 iterate all - get(i) 1.5857 ms/op 1.8621 ms/op 0.85
Array 250000 create 3.3708 ms/op 3.7447 ms/op 0.90
Array 250000 clone - spread 1.4274 ms/op 1.3586 ms/op 1.05
Array 250000 get(125000) 1.1020 ns/op 1.2160 ns/op 0.91
Array 250000 set(125000) 4.2100 ns/op 5.3110 ns/op 0.79
Array 250000 iterate all - loop 165.72 us/op 176.13 us/op 0.94
effectiveBalanceIncrements clone Uint8Array 300000 36.123 us/op 48.602 us/op 0.74
effectiveBalanceIncrements clone MutableVector 300000 417.00 ns/op 395.00 ns/op 1.06
effectiveBalanceIncrements rw all Uint8Array 300000 204.28 us/op 211.57 us/op 0.97
effectiveBalanceIncrements rw all MutableVector 300000 94.734 ms/op 110.23 ms/op 0.86
phase0 afterProcessEpoch - 250000 vs - 7PWei 113.45 ms/op 127.16 ms/op 0.89
phase0 beforeProcessEpoch - 250000 vs - 7PWei 35.800 ms/op 75.182 ms/op 0.48
altair processEpoch - mainnet_e81889 481.97 ms/op 676.79 ms/op 0.71
mainnet_e81889 - altair beforeProcessEpoch 83.816 ms/op 102.57 ms/op 0.82
mainnet_e81889 - altair processJustificationAndFinalization 14.640 us/op 22.584 us/op 0.65
mainnet_e81889 - altair processInactivityUpdates 5.3459 ms/op 7.5669 ms/op 0.71
mainnet_e81889 - altair processRewardsAndPenalties 53.698 ms/op 87.094 ms/op 0.62
mainnet_e81889 - altair processRegistryUpdates 2.0210 us/op 2.7030 us/op 0.75
mainnet_e81889 - altair processSlashings 546.00 ns/op 608.00 ns/op 0.90
mainnet_e81889 - altair processEth1DataReset 513.00 ns/op 1.0820 us/op 0.47
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.3114 ms/op 2.0144 ms/op 0.65
mainnet_e81889 - altair processSlashingsReset 3.4030 us/op 6.1360 us/op 0.55
mainnet_e81889 - altair processRandaoMixesReset 3.9030 us/op 5.4860 us/op 0.71
mainnet_e81889 - altair processHistoricalRootsUpdate 643.00 ns/op 1.1110 us/op 0.58
mainnet_e81889 - altair processParticipationFlagUpdates 1.5440 us/op 3.1610 us/op 0.49
mainnet_e81889 - altair processSyncCommitteeUpdates 665.00 ns/op 1.3010 us/op 0.51
mainnet_e81889 - altair afterProcessEpoch 116.11 ms/op 127.17 ms/op 0.91
capella processEpoch - mainnet_e217614 1.9666 s/op 2.1819 s/op 0.90
mainnet_e217614 - capella beforeProcessEpoch 447.20 ms/op 529.85 ms/op 0.84
mainnet_e217614 - capella processJustificationAndFinalization 13.554 us/op 24.296 us/op 0.56
mainnet_e217614 - capella processInactivityUpdates 21.030 ms/op 24.232 ms/op 0.87
mainnet_e217614 - capella processRewardsAndPenalties 528.43 ms/op 619.63 ms/op 0.85
mainnet_e217614 - capella processRegistryUpdates 29.380 us/op 28.487 us/op 1.03
mainnet_e217614 - capella processSlashings 706.00 ns/op 968.00 ns/op 0.73
mainnet_e217614 - capella processEth1DataReset 513.00 ns/op 447.00 ns/op 1.15
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.2399 ms/op 4.5321 ms/op 0.94
mainnet_e217614 - capella processSlashingsReset 3.6750 us/op 3.9290 us/op 0.94
mainnet_e217614 - capella processRandaoMixesReset 5.0510 us/op 6.8370 us/op 0.74
mainnet_e217614 - capella processHistoricalRootsUpdate 644.00 ns/op 800.00 ns/op 0.81
mainnet_e217614 - capella processParticipationFlagUpdates 1.3620 us/op 2.3120 us/op 0.59
mainnet_e217614 - capella afterProcessEpoch 338.37 ms/op 310.23 ms/op 1.09
phase0 processEpoch - mainnet_e58758 438.49 ms/op 479.19 ms/op 0.92
mainnet_e58758 - phase0 beforeProcessEpoch 142.67 ms/op 147.95 ms/op 0.96
mainnet_e58758 - phase0 processJustificationAndFinalization 14.565 us/op 16.762 us/op 0.87
mainnet_e58758 - phase0 processRewardsAndPenalties 55.513 ms/op 69.046 ms/op 0.80
mainnet_e58758 - phase0 processRegistryUpdates 14.446 us/op 9.5220 us/op 1.52
mainnet_e58758 - phase0 processSlashings 540.00 ns/op 726.00 ns/op 0.74
mainnet_e58758 - phase0 processEth1DataReset 395.00 ns/op 689.00 ns/op 0.57
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.0818 ms/op 2.0642 ms/op 0.52
mainnet_e58758 - phase0 processSlashingsReset 2.9250 us/op 4.0190 us/op 0.73
mainnet_e58758 - phase0 processRandaoMixesReset 3.9590 us/op 6.3460 us/op 0.62
mainnet_e58758 - phase0 processHistoricalRootsUpdate 525.00 ns/op 686.00 ns/op 0.77
mainnet_e58758 - phase0 processParticipationRecordUpdates 2.7930 us/op 5.8770 us/op 0.48
mainnet_e58758 - phase0 afterProcessEpoch 97.941 ms/op 96.144 ms/op 1.02
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.2941 ms/op 1.2874 ms/op 1.01
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 1.4619 ms/op 1.3839 ms/op 1.06
altair processInactivityUpdates - 250000 normalcase 23.109 ms/op 26.659 ms/op 0.87
altair processInactivityUpdates - 250000 worstcase 23.039 ms/op 34.819 ms/op 0.66
phase0 processRegistryUpdates - 250000 normalcase 10.276 us/op 14.023 us/op 0.73
phase0 processRegistryUpdates - 250000 badcase_full_deposits 337.13 us/op 619.61 us/op 0.54
phase0 processRegistryUpdates - 250000 worstcase 0.5 146.32 ms/op 160.00 ms/op 0.91
altair processRewardsAndPenalties - 250000 normalcase 66.785 ms/op 90.815 ms/op 0.74
altair processRewardsAndPenalties - 250000 worstcase 68.812 ms/op 84.533 ms/op 0.81
phase0 getAttestationDeltas - 250000 normalcase 8.7845 ms/op 9.2495 ms/op 0.95
phase0 getAttestationDeltas - 250000 worstcase 8.8912 ms/op 9.7389 ms/op 0.91
phase0 processSlashings - 250000 worstcase 80.128 us/op 127.62 us/op 0.63
altair processSyncCommitteeUpdates - 250000 147.14 ms/op 162.29 ms/op 0.91
BeaconState.hashTreeRoot - No change 289.00 ns/op 402.00 ns/op 0.72
BeaconState.hashTreeRoot - 1 full validator 142.18 us/op 143.14 us/op 0.99
BeaconState.hashTreeRoot - 32 full validator 1.2465 ms/op 1.6458 ms/op 0.76
BeaconState.hashTreeRoot - 512 full validator 16.219 ms/op 19.913 ms/op 0.81
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 189.27 us/op 205.64 us/op 0.92
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.4737 ms/op 2.8011 ms/op 0.88
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 28.409 ms/op 36.626 ms/op 0.78
BeaconState.hashTreeRoot - 1 balances 119.71 us/op 163.87 us/op 0.73
BeaconState.hashTreeRoot - 32 balances 1.1862 ms/op 1.4083 ms/op 0.84
BeaconState.hashTreeRoot - 512 balances 13.123 ms/op 9.5393 ms/op 1.38
BeaconState.hashTreeRoot - 250000 balances 195.69 ms/op 198.96 ms/op 0.98
aggregationBits - 2048 els - zipIndexesInBitList 26.225 us/op 27.359 us/op 0.96
byteArrayEquals 32 72.728 ns/op 74.462 ns/op 0.98
Buffer.compare 32 54.278 ns/op 55.523 ns/op 0.98
byteArrayEquals 1024 1.9793 us/op 2.0373 us/op 0.97
Buffer.compare 1024 69.420 ns/op 70.010 ns/op 0.99
byteArrayEquals 16384 31.528 us/op 32.399 us/op 0.97
Buffer.compare 16384 260.88 ns/op 244.38 ns/op 1.07
byteArrayEquals 123687377 236.96 ms/op 240.08 ms/op 0.99
Buffer.compare 123687377 6.0068 ms/op 6.8846 ms/op 0.87
byteArrayEquals 32 - diff last byte 68.985 ns/op 74.869 ns/op 0.92
Buffer.compare 32 - diff last byte 54.221 ns/op 57.588 ns/op 0.94
byteArrayEquals 1024 - diff last byte 1.9685 us/op 2.0709 us/op 0.95
Buffer.compare 1024 - diff last byte 69.313 ns/op 73.397 ns/op 0.94
byteArrayEquals 16384 - diff last byte 31.361 us/op 32.787 us/op 0.96
Buffer.compare 16384 - diff last byte 261.47 ns/op 250.53 ns/op 1.04
byteArrayEquals 123687377 - diff last byte 237.15 ms/op 248.08 ms/op 0.96
Buffer.compare 123687377 - diff last byte 6.0676 ms/op 7.1863 ms/op 0.84
byteArrayEquals 32 - random bytes 5.2110 ns/op 5.8830 ns/op 0.89
Buffer.compare 32 - random bytes 58.704 ns/op 62.984 ns/op 0.93
byteArrayEquals 1024 - random bytes 4.9890 ns/op 5.9210 ns/op 0.84
Buffer.compare 1024 - random bytes 58.257 ns/op 62.314 ns/op 0.93
byteArrayEquals 16384 - random bytes 4.9940 ns/op 5.6590 ns/op 0.88
Buffer.compare 16384 - random bytes 58.105 ns/op 62.837 ns/op 0.92
byteArrayEquals 123687377 - random bytes 8.0500 ns/op 8.9100 ns/op 0.90
Buffer.compare 123687377 - random bytes 61.210 ns/op 65.310 ns/op 0.94
regular array get 100000 times 42.533 us/op 45.211 us/op 0.94
wrappedArray get 100000 times 42.553 us/op 45.655 us/op 0.93
arrayWithProxy get 100000 times 14.520 ms/op 15.133 ms/op 0.96
ssz.Root.equals 53.000 ns/op 55.820 ns/op 0.95
byteArrayEquals 52.009 ns/op 54.787 ns/op 0.95
Buffer.compare 10.625 ns/op 11.070 ns/op 0.96
shuffle list - 16384 els 8.3210 ms/op 8.7412 ms/op 0.95
shuffle list - 250000 els 122.31 ms/op 128.51 ms/op 0.95
processSlot - 1 slots 15.703 us/op 18.650 us/op 0.84
processSlot - 32 slots 3.4346 ms/op 4.1080 ms/op 0.84
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 57.561 ms/op 63.761 ms/op 0.90
getCommitteeAssignments - req 1 vs - 250000 vc 2.6163 ms/op 2.7392 ms/op 0.96
getCommitteeAssignments - req 100 vs - 250000 vc 3.7834 ms/op 4.1114 ms/op 0.92
getCommitteeAssignments - req 1000 vs - 250000 vc 4.1500 ms/op 4.3784 ms/op 0.95
findModifiedValidators - 10000 modified validators 500.16 ms/op 568.42 ms/op 0.88
findModifiedValidators - 1000 modified validators 428.65 ms/op 492.33 ms/op 0.87
findModifiedValidators - 100 modified validators 433.04 ms/op 511.00 ms/op 0.85
findModifiedValidators - 10 modified validators 386.71 ms/op 449.30 ms/op 0.86
findModifiedValidators - 1 modified validators 397.62 ms/op 461.83 ms/op 0.86
findModifiedValidators - no difference 375.55 ms/op 423.11 ms/op 0.89
compare ViewDUs 4.3211 s/op 4.9739 s/op 0.87
compare each validator Uint8Array 1.5029 s/op 2.0090 s/op 0.75
compare ViewDU to Uint8Array 1.1332 s/op 1.1577 s/op 0.98
migrate state 1000000 validators, 24 modified, 0 new 777.18 ms/op 848.38 ms/op 0.92
migrate state 1000000 validators, 1700 modified, 1000 new 1.0727 s/op 1.2413 s/op 0.86
migrate state 1000000 validators, 3400 modified, 2000 new 1.2909 s/op 1.4387 s/op 0.90
migrate state 1500000 validators, 24 modified, 0 new 765.57 ms/op 946.09 ms/op 0.81
migrate state 1500000 validators, 1700 modified, 1000 new 1.0361 s/op 1.1460 s/op 0.90
migrate state 1500000 validators, 3400 modified, 2000 new 1.3109 s/op 1.4824 s/op 0.88
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 4.0900 ns/op 5.0100 ns/op 0.82
state getBlockRootAtSlot - 250000 vs - 7PWei 615.33 ns/op 792.77 ns/op 0.78
computeProposers - vc 250000 9.5065 ms/op 13.244 ms/op 0.72
computeEpochShuffling - vc 250000 122.17 ms/op 155.00 ms/op 0.79
getNextSyncCommittee - vc 250000 148.34 ms/op 190.29 ms/op 0.78
computeSigningRoot for AttestationData 26.310 us/op 34.144 us/op 0.77
hash AttestationData serialized data then Buffer.toString(base64) 2.1733 us/op 2.7187 us/op 0.80
toHexString serialized data 1.0080 us/op 1.5747 us/op 0.64
Buffer.toString(base64) 206.95 ns/op 311.67 ns/op 0.66

by benchmarkbot/action

@twoeths twoeths merged commit 59a49ff into unstable Mar 26, 2024
19 of 21 checks passed
@twoeths twoeths deleted the mkeil/fix-spelling-xiaoxianboy branch March 26, 2024 06:35
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nflaig nflaig nflaig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@matthewkeil @wemeetagain @nflaig @twoeths