Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: allow to pass extra args to dev scripts #6600

Merged
merged 1 commit into from Mar 27, 2024

Conversation

jeluard
Copy link
Member

@jeluard jeluard commented Mar 27, 2024

Motivation

Allow to pass extra args to node scripts

Description

Allows the following:

./scripts/dev/node1.sh --blindedLocal

@jeluard jeluard requested a review from a team as a code owner March 27, 2024 08:39
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

Merging #6600 (ec381bf) into unstable (ba57d4b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6600   +/-   ##
=========================================
  Coverage     61.49%   61.49%           
=========================================
  Files           556      556           
  Lines         58895    58895           
  Branches       1856     1856           
=========================================
  Hits          36216    36216           
  Misses        22638    22638           
  Partials         41       41           

@nflaig nflaig changed the title chore: allow to pass extra args to scripts chore: allow to pass extra args to dev scripts Mar 27, 2024
@jeluard jeluard merged commit 971871e into unstable Mar 27, 2024
18 of 21 checks passed
@jeluard jeluard deleted the jeluard/extra-node-args branch March 27, 2024 09:41
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants