Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: make sure the docker container stopped #6642

Merged
merged 1 commit into from Apr 5, 2024
Merged

test: make sure the docker container stopped #6642

merged 1 commit into from Apr 5, 2024

Conversation

nazarhussain
Copy link
Contributor

Motivation

Cleanup the resources.

Description

In some edge cases noticed that killing the process was not exiting the docker container. Reverting the logic and stopping the container works for both container and process which is running it.

Steps to test or reproduce

  • Run all tests

@nazarhussain nazarhussain requested a review from a team as a code owner April 5, 2024 13:53
@nazarhussain nazarhussain self-assigned this Apr 5, 2024
@nflaig nflaig changed the title fix: make sure the docker container stopped test: make sure the docker container stopped Apr 5, 2024
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #6642 (10b26d4) into unstable (898cd90) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files 
@@            Coverage Diff            @@
##           unstable    #6642   +/-   ##
=========================================
  Coverage     61.69%   61.69%           
=========================================
  Files           556      556           
  Lines         58820    58820           
  Branches       1887     1887           
=========================================
  Hits          36287    36287           
  Misses        22492    22492           
  Partials         41       41

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 5, 2024

Performance Report

✔️ no performance regression detected

Full benchmark results
Benchmark suite Current: 73e6369 Previous: e202592 Ratio
getPubkeys - index2pubkey - req 1000 vs - 250000 vc 933.92 us/op 580.47 us/op 1.61
getPubkeys - validatorsArr - req 1000 vs - 250000 vc 95.339 us/op 106.08 us/op 0.90
BLS verify - blst-native 1.3414 ms/op 1.3251 ms/op 1.01
BLS verifyMultipleSignatures 3 - blst-native 2.8109 ms/op 2.7329 ms/op 1.03
BLS verifyMultipleSignatures 8 - blst-native 6.4769 ms/op 6.2065 ms/op 1.04
BLS verifyMultipleSignatures 32 - blst-native 23.849 ms/op 22.360 ms/op 1.07
BLS verifyMultipleSignatures 64 - blst-native 46.306 ms/op 43.503 ms/op 1.06
BLS verifyMultipleSignatures 128 - blst-native 96.012 ms/op 85.514 ms/op 1.12
BLS deserializing 10000 signatures 904.28 ms/op 908.72 ms/op 1.00
BLS deserializing 100000 signatures 9.3873 s/op 9.5040 s/op 0.99
BLS verifyMultipleSignatures - same message - 3 - blst-native 1.4790 ms/op 1.3670 ms/op 1.08
BLS verifyMultipleSignatures - same message - 8 - blst-native 1.7065 ms/op 1.7009 ms/op 1.00
BLS verifyMultipleSignatures - same message - 32 - blst-native 2.7227 ms/op 2.8853 ms/op 0.94
BLS verifyMultipleSignatures - same message - 64 - blst-native 3.7849 ms/op 4.7312 ms/op 0.80
BLS verifyMultipleSignatures - same message - 128 - blst-native 6.2779 ms/op 5.6790 ms/op 1.11
BLS aggregatePubkeys 32 - blst-native 28.102 us/op 25.955 us/op 1.08
BLS aggregatePubkeys 128 - blst-native 118.86 us/op 102.09 us/op 1.16
notSeenSlots=1 numMissedVotes=1 numBadVotes=10 77.207 ms/op 59.524 ms/op 1.30
notSeenSlots=1 numMissedVotes=0 numBadVotes=4 76.259 ms/op 61.654 ms/op 1.24
notSeenSlots=2 numMissedVotes=1 numBadVotes=10 55.923 ms/op 49.807 ms/op 1.12
getSlashingsAndExits - default max 201.32 us/op 452.97 us/op 0.44
getSlashingsAndExits - 2k 554.76 us/op 874.70 us/op 0.63
proposeBlockBody type=full, size=empty 6.6225 ms/op 7.5664 ms/op 0.88
isKnown best case - 1 super set check 349.00 ns/op 715.00 ns/op 0.49
isKnown normal case - 2 super set checks 321.00 ns/op 768.00 ns/op 0.42
isKnown worse case - 16 super set checks 596.00 ns/op 749.00 ns/op 0.80
InMemoryCheckpointStateCache - add get delete 7.7170 us/op 8.7650 us/op 0.88
validate api signedAggregateAndProof - struct 2.8950 ms/op 3.5039 ms/op 0.83
validate gossip signedAggregateAndProof - struct 2.8564 ms/op 3.2698 ms/op 0.87
validate gossip attestation - vc 640000 1.4208 ms/op 1.6311 ms/op 0.87
batch validate gossip attestation - vc 640000 - chunk 32 175.35 us/op 178.50 us/op 0.98
batch validate gossip attestation - vc 640000 - chunk 64 164.98 us/op 148.23 us/op 1.11
batch validate gossip attestation - vc 640000 - chunk 128 163.27 us/op 145.10 us/op 1.13
batch validate gossip attestation - vc 640000 - chunk 256 150.78 us/op 135.25 us/op 1.11
pickEth1Vote - no votes 1.5179 ms/op 1.1855 ms/op 1.28
pickEth1Vote - max votes 11.428 ms/op 11.089 ms/op 1.03
pickEth1Vote - Eth1Data hashTreeRoot value x2048 21.338 ms/op 20.518 ms/op 1.04
pickEth1Vote - Eth1Data hashTreeRoot tree x2048 29.964 ms/op 26.096 ms/op 1.15
pickEth1Vote - Eth1Data fastSerialize value x2048 784.86 us/op 695.64 us/op 1.13
pickEth1Vote - Eth1Data fastSerialize tree x2048 5.8386 ms/op 5.1475 ms/op 1.13
bytes32 toHexString 823.00 ns/op 594.00 ns/op 1.39
bytes32 Buffer.toString(hex) 363.00 ns/op 308.00 ns/op 1.18
bytes32 Buffer.toString(hex) from Uint8Array 558.00 ns/op 433.00 ns/op 1.29
bytes32 Buffer.toString(hex) + 0x 338.00 ns/op 312.00 ns/op 1.08
Object access 1 prop 0.23200 ns/op 0.17900 ns/op 1.30
Map access 1 prop 0.16000 ns/op 0.16100 ns/op 0.99
Object get x1000 8.0050 ns/op 7.5710 ns/op 1.06
Map get x1000 0.92400 ns/op 0.81900 ns/op 1.13
Object set x1000 71.626 ns/op 55.818 ns/op 1.28
Map set x1000 56.610 ns/op 43.577 ns/op 1.30
Return object 10000 times 0.27950 ns/op 0.24480 ns/op 1.14
Throw Error 10000 times 4.3884 us/op 3.9267 us/op 1.12
fastMsgIdFn sha256 / 200 bytes 3.5430 us/op 3.3330 us/op 1.06
fastMsgIdFn h32 xxhash / 200 bytes 376.00 ns/op 321.00 ns/op 1.17
fastMsgIdFn h64 xxhash / 200 bytes 445.00 ns/op 375.00 ns/op 1.19
fastMsgIdFn sha256 / 1000 bytes 12.000 us/op 11.565 us/op 1.04
fastMsgIdFn h32 xxhash / 1000 bytes 520.00 ns/op 464.00 ns/op 1.12
fastMsgIdFn h64 xxhash / 1000 bytes 511.00 ns/op 449.00 ns/op 1.14
fastMsgIdFn sha256 / 10000 bytes 108.43 us/op 104.07 us/op 1.04
fastMsgIdFn h32 xxhash / 10000 bytes 2.2070 us/op 1.9870 us/op 1.11
fastMsgIdFn h64 xxhash / 10000 bytes 1.4820 us/op 1.3880 us/op 1.07
send data - 1000 256B messages 22.653 ms/op 21.571 ms/op 1.05
send data - 1000 512B messages 28.696 ms/op 27.478 ms/op 1.04
send data - 1000 1024B messages 45.545 ms/op 44.634 ms/op 1.02
send data - 1000 1200B messages 29.292 ms/op 37.665 ms/op 0.78
send data - 1000 2048B messages 58.080 ms/op 45.750 ms/op 1.27
send data - 1000 4096B messages 46.167 ms/op 25.463 ms/op 1.81
send data - 1000 16384B messages 130.01 ms/op 105.33 ms/op 1.23
send data - 1000 65536B messages 475.05 ms/op 449.21 ms/op 1.06
enrSubnets - fastDeserialize 64 bits 1.6280 us/op 1.2970 us/op 1.26
enrSubnets - ssz BitVector 64 bits 558.00 ns/op 428.00 ns/op 1.30
enrSubnets - fastDeserialize 4 bits 243.00 ns/op 168.00 ns/op 1.45
enrSubnets - ssz BitVector 4 bits 584.00 ns/op 417.00 ns/op 1.40
prioritizePeers score -10:0 att 32-0.1 sync 2-0 127.83 us/op 100.97 us/op 1.27
prioritizePeers score 0:0 att 32-0.25 sync 2-0.25 147.60 us/op 143.78 us/op 1.03
prioritizePeers score 0:0 att 32-0.5 sync 2-0.5 222.33 us/op 192.85 us/op 1.15
prioritizePeers score 0:0 att 64-0.75 sync 4-0.75 356.55 us/op 338.25 us/op 1.05
prioritizePeers score 0:0 att 64-1 sync 4-1 452.51 us/op 371.42 us/op 1.22
array of 16000 items push then shift 1.8429 us/op 1.6295 us/op 1.13
LinkedList of 16000 items push then shift 10.783 ns/op 8.9980 ns/op 1.20
array of 16000 items push then pop 111.28 ns/op 96.010 ns/op 1.16
LinkedList of 16000 items push then pop 9.6430 ns/op 8.5290 ns/op 1.13
array of 24000 items push then shift 2.5977 us/op 2.5381 us/op 1.02
LinkedList of 24000 items push then shift 10.126 ns/op 8.9420 ns/op 1.13
array of 24000 items push then pop 165.71 ns/op 119.62 ns/op 1.39
LinkedList of 24000 items push then pop 9.3040 ns/op 8.5660 ns/op 1.09
intersect bitArray bitLen 8 6.1680 ns/op 5.7410 ns/op 1.07
intersect array and set length 8 79.530 ns/op 60.075 ns/op 1.32
intersect bitArray bitLen 128 39.044 ns/op 34.064 ns/op 1.15
intersect array and set length 128 1.0889 us/op 867.90 ns/op 1.25
bitArray.getTrueBitIndexes() bitLen 128 1.7180 us/op 1.6110 us/op 1.07
bitArray.getTrueBitIndexes() bitLen 248 3.1160 us/op 2.8630 us/op 1.09
bitArray.getTrueBitIndexes() bitLen 512 6.4980 us/op 5.0820 us/op 1.28
Buffer.concat 32 items 1.0810 us/op 1.0030 us/op 1.08
Uint8Array.set 32 items 2.0060 us/op 1.7380 us/op 1.15
Set add up to 64 items then delete first 5.3415 us/op 4.4463 us/op 1.20
OrderedSet add up to 64 items then delete first 6.8975 us/op 5.5699 us/op 1.24
Set add up to 64 items then delete last 5.6748 us/op 4.8303 us/op 1.17
OrderedSet add up to 64 items then delete last 7.3015 us/op 6.2230 us/op 1.17
Set add up to 64 items then delete middle 5.5873 us/op 4.6384 us/op 1.20
OrderedSet add up to 64 items then delete middle 8.5307 us/op 7.2445 us/op 1.18
Set add up to 128 items then delete first 10.954 us/op 9.8545 us/op 1.11
OrderedSet add up to 128 items then delete first 15.361 us/op 13.442 us/op 1.14
Set add up to 128 items then delete last 11.339 us/op 9.6281 us/op 1.18
OrderedSet add up to 128 items then delete last 15.655 us/op 11.895 us/op 1.32
Set add up to 128 items then delete middle 11.472 us/op 9.3376 us/op 1.23
OrderedSet add up to 128 items then delete middle 20.373 us/op 17.104 us/op 1.19
Set add up to 256 items then delete first 22.758 us/op 18.781 us/op 1.21
OrderedSet add up to 256 items then delete first 32.335 us/op 25.978 us/op 1.24
Set add up to 256 items then delete last 22.159 us/op 19.221 us/op 1.15
OrderedSet add up to 256 items then delete last 29.293 us/op 23.155 us/op 1.27
Set add up to 256 items then delete middle 20.697 us/op 18.829 us/op 1.10
OrderedSet add up to 256 items then delete middle 53.194 us/op 46.916 us/op 1.13
transfer serialized Status (84 B) 2.1370 us/op 1.6900 us/op 1.26
copy serialized Status (84 B) 1.5440 us/op 1.2790 us/op 1.21
transfer serialized SignedVoluntaryExit (112 B) 2.2500 us/op 1.9240 us/op 1.17
copy serialized SignedVoluntaryExit (112 B) 1.6540 us/op 1.4740 us/op 1.12
transfer serialized ProposerSlashing (416 B) 2.5350 us/op 1.9740 us/op 1.28
copy serialized ProposerSlashing (416 B) 2.2130 us/op 1.9680 us/op 1.12
transfer serialized Attestation (485 B) 2.4580 us/op 2.7810 us/op 0.88
copy serialized Attestation (485 B) 2.0650 us/op 1.9790 us/op 1.04
transfer serialized AttesterSlashing (33232 B) 2.2490 us/op 2.0870 us/op 1.08
copy serialized AttesterSlashing (33232 B) 7.9580 us/op 7.2200 us/op 1.10
transfer serialized Small SignedBeaconBlock (128000 B) 2.6480 us/op 3.3580 us/op 0.79
copy serialized Small SignedBeaconBlock (128000 B) 25.012 us/op 19.035 us/op 1.31
transfer serialized Avg SignedBeaconBlock (200000 B) 3.4490 us/op 3.2320 us/op 1.07
copy serialized Avg SignedBeaconBlock (200000 B) 44.911 us/op 24.561 us/op 1.83
transfer serialized BlobsSidecar (524380 B) 5.3350 us/op 3.4530 us/op 1.55
copy serialized BlobsSidecar (524380 B) 108.60 us/op 102.81 us/op 1.06
transfer serialized Big SignedBeaconBlock (1000000 B) 4.8600 us/op 3.8580 us/op 1.26
copy serialized Big SignedBeaconBlock (1000000 B) 211.61 us/op 168.69 us/op 1.25
pass gossip attestations to forkchoice per slot 4.5626 ms/op 4.3173 ms/op 1.06
forkChoice updateHead vc 100000 bc 64 eq 0 708.88 us/op 715.62 us/op 0.99
forkChoice updateHead vc 600000 bc 64 eq 0 4.7686 ms/op 5.0178 ms/op 0.95
forkChoice updateHead vc 1000000 bc 64 eq 0 7.4477 ms/op 7.1896 ms/op 1.04
forkChoice updateHead vc 600000 bc 320 eq 0 4.3560 ms/op 4.3475 ms/op 1.00
forkChoice updateHead vc 600000 bc 1200 eq 0 4.5270 ms/op 4.6396 ms/op 0.98
forkChoice updateHead vc 600000 bc 7200 eq 0 5.5774 ms/op 5.4306 ms/op 1.03
forkChoice updateHead vc 600000 bc 64 eq 1000 11.641 ms/op 11.449 ms/op 1.02
forkChoice updateHead vc 600000 bc 64 eq 10000 12.038 ms/op 12.221 ms/op 0.98
forkChoice updateHead vc 600000 bc 64 eq 300000 17.096 ms/op 16.691 ms/op 1.02
computeDeltas 500000 validators 300 proto nodes 7.0154 ms/op 6.7785 ms/op 1.03
computeDeltas 500000 validators 1200 proto nodes 6.7383 ms/op 6.8662 ms/op 0.98
computeDeltas 500000 validators 7200 proto nodes 6.6235 ms/op 6.5255 ms/op 1.02
computeDeltas 750000 validators 300 proto nodes 9.9663 ms/op 9.8621 ms/op 1.01
computeDeltas 750000 validators 1200 proto nodes 9.6374 ms/op 9.9350 ms/op 0.97
computeDeltas 750000 validators 7200 proto nodes 9.9401 ms/op 10.390 ms/op 0.96
computeDeltas 1400000 validators 300 proto nodes 18.303 ms/op 20.013 ms/op 0.91
computeDeltas 1400000 validators 1200 proto nodes 19.053 ms/op 20.339 ms/op 0.94
computeDeltas 1400000 validators 7200 proto nodes 18.971 ms/op 20.732 ms/op 0.92
computeDeltas 2100000 validators 300 proto nodes 27.666 ms/op 30.790 ms/op 0.90
computeDeltas 2100000 validators 1200 proto nodes 28.126 ms/op 29.483 ms/op 0.95
computeDeltas 2100000 validators 7200 proto nodes 28.283 ms/op 29.520 ms/op 0.96
altair processAttestation - 250000 vs - 7PWei normalcase 2.7753 ms/op 2.4745 ms/op 1.12
altair processAttestation - 250000 vs - 7PWei worstcase 4.7549 ms/op 3.3977 ms/op 1.40
altair processAttestation - setStatus - 1/6 committees join 199.22 us/op 194.33 us/op 1.03
altair processAttestation - setStatus - 1/3 committees join 371.33 us/op 381.16 us/op 0.97
altair processAttestation - setStatus - 1/2 committees join 494.36 us/op 490.48 us/op 1.01
altair processAttestation - setStatus - 2/3 committees join 623.39 us/op 611.96 us/op 1.02
altair processAttestation - setStatus - 4/5 committees join 838.86 us/op 871.79 us/op 0.96
altair processAttestation - setStatus - 100% committees join 984.86 us/op 978.89 us/op 1.01
altair processBlock - 250000 vs - 7PWei normalcase 8.6577 ms/op 8.7717 ms/op 0.99
altair processBlock - 250000 vs - 7PWei normalcase hashState 39.732 ms/op 35.961 ms/op 1.10
altair processBlock - 250000 vs - 7PWei worstcase 42.813 ms/op 47.877 ms/op 0.89
altair processBlock - 250000 vs - 7PWei worstcase hashState 93.792 ms/op 95.943 ms/op 0.98
phase0 processBlock - 250000 vs - 7PWei normalcase 2.2880 ms/op 2.7448 ms/op 0.83
phase0 processBlock - 250000 vs - 7PWei worstcase 29.926 ms/op 31.784 ms/op 0.94
altair processEth1Data - 250000 vs - 7PWei normalcase 475.62 us/op 494.76 us/op 0.96
getExpectedWithdrawals 250000 eb:1,eth1:1,we:0,wn:0,smpl:15 16.018 us/op 13.911 us/op 1.15
getExpectedWithdrawals 250000 eb:0.95,eth1:0.1,we:0.05,wn:0,smpl:219 82.145 us/op 47.913 us/op 1.71
getExpectedWithdrawals 250000 eb:0.95,eth1:0.3,we:0.05,wn:0,smpl:42 14.268 us/op 18.359 us/op 0.78
getExpectedWithdrawals 250000 eb:0.95,eth1:0.7,we:0.05,wn:0,smpl:18 9.6360 us/op 15.890 us/op 0.61
getExpectedWithdrawals 250000 eb:0.1,eth1:0.1,we:0,wn:0,smpl:1020 199.11 us/op 243.84 us/op 0.82
getExpectedWithdrawals 250000 eb:0.03,eth1:0.03,we:0,wn:0,smpl:11777 1.5097 ms/op 1.3522 ms/op 1.12
getExpectedWithdrawals 250000 eb:0.01,eth1:0.01,we:0,wn:0,smpl:16384 1.6263 ms/op 1.7781 ms/op 0.91
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,smpl:16384 1.5991 ms/op 1.7730 ms/op 0.90
getExpectedWithdrawals 250000 eb:0,eth1:0,we:0,wn:0,nocache,smpl:16384 3.4226 ms/op 3.2835 ms/op 1.04
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,smpl:16384 2.4696 ms/op 2.8917 ms/op 0.85
getExpectedWithdrawals 250000 eb:0,eth1:1,we:0,wn:0,nocache,smpl:16384 4.7385 ms/op 5.4212 ms/op 0.87
Tree 40 250000 create 362.94 ms/op 369.11 ms/op 0.98
Tree 40 250000 get(125000) 202.17 ns/op 208.11 ns/op 0.97
Tree 40 250000 set(125000) 1.0371 us/op 1.0653 us/op 0.97
Tree 40 250000 toArray() 23.536 ms/op 24.575 ms/op 0.96
Tree 40 250000 iterate all - toArray() + loop 23.418 ms/op 26.735 ms/op 0.88
Tree 40 250000 iterate all - get(i) 72.173 ms/op 77.973 ms/op 0.93
MutableVector 250000 create 15.404 ms/op 17.607 ms/op 0.87
MutableVector 250000 get(125000) 6.5090 ns/op 6.7400 ns/op 0.97
MutableVector 250000 set(125000) 299.99 ns/op 528.49 ns/op 0.57
MutableVector 250000 toArray() 3.9251 ms/op 4.7756 ms/op 0.82
MutableVector 250000 iterate all - toArray() + loop 3.9406 ms/op 4.2648 ms/op 0.92
MutableVector 250000 iterate all - get(i) 1.5309 ms/op 1.5496 ms/op 0.99
Array 250000 create 3.4485 ms/op 3.8098 ms/op 0.91
Array 250000 clone - spread 1.4037 ms/op 1.4657 ms/op 0.96
Array 250000 get(125000) 1.1610 ns/op 1.8060 ns/op 0.64
Array 250000 set(125000) 4.4820 ns/op 5.7530 ns/op 0.78
Array 250000 iterate all - loop 167.39 us/op 173.65 us/op 0.96
effectiveBalanceIncrements clone Uint8Array 300000 38.300 us/op 56.900 us/op 0.67
effectiveBalanceIncrements clone MutableVector 300000 447.00 ns/op 444.00 ns/op 1.01
effectiveBalanceIncrements rw all Uint8Array 300000 211.44 us/op 209.71 us/op 1.01
effectiveBalanceIncrements rw all MutableVector 300000 94.693 ms/op 117.48 ms/op 0.81
phase0 afterProcessEpoch - 250000 vs - 7PWei 120.79 ms/op 116.87 ms/op 1.03
phase0 beforeProcessEpoch - 250000 vs - 7PWei 56.115 ms/op 51.862 ms/op 1.08
altair processEpoch - mainnet_e81889 529.38 ms/op 525.42 ms/op 1.01
mainnet_e81889 - altair beforeProcessEpoch 89.495 ms/op 97.397 ms/op 0.92
mainnet_e81889 - altair processJustificationAndFinalization 14.785 us/op 17.703 us/op 0.84
mainnet_e81889 - altair processInactivityUpdates 5.8667 ms/op 6.9630 ms/op 0.84
mainnet_e81889 - altair processRewardsAndPenalties 72.096 ms/op 74.450 ms/op 0.97
mainnet_e81889 - altair processRegistryUpdates 2.7490 us/op 4.0050 us/op 0.69
mainnet_e81889 - altair processSlashings 653.00 ns/op 539.00 ns/op 1.21
mainnet_e81889 - altair processEth1DataReset 1.2630 us/op 651.00 ns/op 1.94
mainnet_e81889 - altair processEffectiveBalanceUpdates 1.4114 ms/op 1.4178 ms/op 1.00
mainnet_e81889 - altair processSlashingsReset 5.0140 us/op 3.5190 us/op 1.42
mainnet_e81889 - altair processRandaoMixesReset 6.2490 us/op 5.7510 us/op 1.09
mainnet_e81889 - altair processHistoricalRootsUpdate 684.00 ns/op 1.1230 us/op 0.61
mainnet_e81889 - altair processParticipationFlagUpdates 3.6440 us/op 2.4360 us/op 1.50
mainnet_e81889 - altair processSyncCommitteeUpdates 681.00 ns/op 669.00 ns/op 1.02
mainnet_e81889 - altair afterProcessEpoch 119.61 ms/op 124.20 ms/op 0.96
capella processEpoch - mainnet_e217614 2.0636 s/op 2.2937 s/op 0.90
mainnet_e217614 - capella beforeProcessEpoch 498.60 ms/op 511.93 ms/op 0.97
mainnet_e217614 - capella processJustificationAndFinalization 14.858 us/op 17.357 us/op 0.86
mainnet_e217614 - capella processInactivityUpdates 19.542 ms/op 23.704 ms/op 0.82
mainnet_e217614 - capella processRewardsAndPenalties 537.02 ms/op 602.62 ms/op 0.89
mainnet_e217614 - capella processRegistryUpdates 26.936 us/op 38.558 us/op 0.70
mainnet_e217614 - capella processSlashings 560.00 ns/op 1.1340 us/op 0.49
mainnet_e217614 - capella processEth1DataReset 563.00 ns/op 1.7680 us/op 0.32
mainnet_e217614 - capella processEffectiveBalanceUpdates 4.5536 ms/op 5.0577 ms/op 0.90
mainnet_e217614 - capella processSlashingsReset 3.6830 us/op 5.9320 us/op 0.62
mainnet_e217614 - capella processRandaoMixesReset 4.6090 us/op 5.6510 us/op 0.82
mainnet_e217614 - capella processHistoricalRootsUpdate 621.00 ns/op 1.0050 us/op 0.62
mainnet_e217614 - capella processParticipationFlagUpdates 1.5960 us/op 2.1810 us/op 0.73
mainnet_e217614 - capella afterProcessEpoch 316.42 ms/op 404.11 ms/op 0.78
phase0 processEpoch - mainnet_e58758 462.26 ms/op 549.37 ms/op 0.84
mainnet_e58758 - phase0 beforeProcessEpoch 160.43 ms/op 141.56 ms/op 1.13
mainnet_e58758 - phase0 processJustificationAndFinalization 18.417 us/op 18.539 us/op 0.99
mainnet_e58758 - phase0 processRewardsAndPenalties 66.669 ms/op 48.246 ms/op 1.38
mainnet_e58758 - phase0 processRegistryUpdates 14.384 us/op 12.212 us/op 1.18
mainnet_e58758 - phase0 processSlashings 523.00 ns/op 759.00 ns/op 0.69
mainnet_e58758 - phase0 processEth1DataReset 619.00 ns/op 846.00 ns/op 0.73
mainnet_e58758 - phase0 processEffectiveBalanceUpdates 1.1500 ms/op 1.2134 ms/op 0.95
mainnet_e58758 - phase0 processSlashingsReset 2.9530 us/op 4.7670 us/op 0.62
mainnet_e58758 - phase0 processRandaoMixesReset 4.3050 us/op 5.9630 us/op 0.72
mainnet_e58758 - phase0 processHistoricalRootsUpdate 854.00 ns/op 703.00 ns/op 1.21
mainnet_e58758 - phase0 processParticipationRecordUpdates 9.5860 us/op 4.3410 us/op 2.21
mainnet_e58758 - phase0 afterProcessEpoch 108.05 ms/op 104.30 ms/op 1.04
phase0 processEffectiveBalanceUpdates - 250000 normalcase 1.7461 ms/op 1.3524 ms/op 1.29
phase0 processEffectiveBalanceUpdates - 250000 worstcase 0.5 2.8211 ms/op 1.5484 ms/op 1.82
altair processInactivityUpdates - 250000 normalcase 31.444 ms/op 33.894 ms/op 0.93
altair processInactivityUpdates - 250000 worstcase 35.916 ms/op 34.717 ms/op 1.03
phase0 processRegistryUpdates - 250000 normalcase 13.492 us/op 14.222 us/op 0.95
phase0 processRegistryUpdates - 250000 badcase_full_deposits 647.72 us/op 404.40 us/op 1.60
phase0 processRegistryUpdates - 250000 worstcase 0.5 157.60 ms/op 172.60 ms/op 0.91
altair processRewardsAndPenalties - 250000 normalcase 72.401 ms/op 83.652 ms/op 0.87
altair processRewardsAndPenalties - 250000 worstcase 72.357 ms/op 79.911 ms/op 0.91
phase0 getAttestationDeltas - 250000 normalcase 12.215 ms/op 10.729 ms/op 1.14
phase0 getAttestationDeltas - 250000 worstcase 10.637 ms/op 12.070 ms/op 0.88
phase0 processSlashings - 250000 worstcase 125.44 us/op 116.04 us/op 1.08
altair processSyncCommitteeUpdates - 250000 168.02 ms/op 169.29 ms/op 0.99
BeaconState.hashTreeRoot - No change 459.00 ns/op 674.00 ns/op 0.68
BeaconState.hashTreeRoot - 1 full validator 125.39 us/op 148.41 us/op 0.84
BeaconState.hashTreeRoot - 32 full validator 1.3008 ms/op 1.7343 ms/op 0.75
BeaconState.hashTreeRoot - 512 full validator 14.518 ms/op 22.923 ms/op 0.63
BeaconState.hashTreeRoot - 1 validator.effectiveBalance 153.17 us/op 240.88 us/op 0.64
BeaconState.hashTreeRoot - 32 validator.effectiveBalance 2.0862 ms/op 2.5162 ms/op 0.83
BeaconState.hashTreeRoot - 512 validator.effectiveBalance 27.321 ms/op 33.428 ms/op 0.82
BeaconState.hashTreeRoot - 1 balances 119.42 us/op 144.32 us/op 0.83
BeaconState.hashTreeRoot - 32 balances 1.0749 ms/op 1.5551 ms/op 0.69
BeaconState.hashTreeRoot - 512 balances 10.738 ms/op 15.880 ms/op 0.68
BeaconState.hashTreeRoot - 250000 balances 187.65 ms/op 220.23 ms/op 0.85
aggregationBits - 2048 els - zipIndexesInBitList 32.200 us/op 30.397 us/op 1.06
byteArrayEquals 32 78.343 ns/op 76.028 ns/op 1.03
Buffer.compare 32 58.491 ns/op 55.889 ns/op 1.05
byteArrayEquals 1024 2.1200 us/op 2.0765 us/op 1.02
Buffer.compare 1024 73.705 ns/op 71.254 ns/op 1.03
byteArrayEquals 16384 33.876 us/op 33.015 us/op 1.03
Buffer.compare 16384 264.96 ns/op 267.61 ns/op 0.99
byteArrayEquals 123687377 250.77 ms/op 250.18 ms/op 1.00
Buffer.compare 123687377 7.5674 ms/op 7.2844 ms/op 1.04
byteArrayEquals 32 - diff last byte 79.075 ns/op 72.920 ns/op 1.08
Buffer.compare 32 - diff last byte 61.384 ns/op 57.348 ns/op 1.07
byteArrayEquals 1024 - diff last byte 2.1193 us/op 2.0793 us/op 1.02
Buffer.compare 1024 - diff last byte 75.277 ns/op 73.793 ns/op 1.02
byteArrayEquals 16384 - diff last byte 33.801 us/op 32.791 us/op 1.03
Buffer.compare 16384 - diff last byte 282.96 ns/op 269.07 ns/op 1.05
byteArrayEquals 123687377 - diff last byte 260.49 ms/op 262.72 ms/op 0.99
Buffer.compare 123687377 - diff last byte 9.2136 ms/op 9.5225 ms/op 0.97
byteArrayEquals 32 - random bytes 7.4970 ns/op 6.5280 ns/op 1.15
Buffer.compare 32 - random bytes 66.063 ns/op 63.029 ns/op 1.05
byteArrayEquals 1024 - random bytes 6.6720 ns/op 6.7140 ns/op 0.99
Buffer.compare 1024 - random bytes 65.961 ns/op 64.714 ns/op 1.02
byteArrayEquals 16384 - random bytes 6.6620 ns/op 6.7560 ns/op 0.99
Buffer.compare 16384 - random bytes 65.285 ns/op 64.585 ns/op 1.01
byteArrayEquals 123687377 - random bytes 11.050 ns/op 12.290 ns/op 0.90
Buffer.compare 123687377 - random bytes 78.430 ns/op 78.280 ns/op 1.00
regular array get 100000 times 48.898 us/op 47.978 us/op 1.02
wrappedArray get 100000 times 50.094 us/op 47.320 us/op 1.06
arrayWithProxy get 100000 times 15.540 ms/op 15.131 ms/op 1.03
ssz.Root.equals 58.238 ns/op 57.365 ns/op 1.02
byteArrayEquals 57.190 ns/op 55.515 ns/op 1.03
Buffer.compare 12.885 ns/op 12.490 ns/op 1.03
shuffle list - 16384 els 9.2142 ms/op 9.3073 ms/op 0.99
shuffle list - 250000 els 136.03 ms/op 136.83 ms/op 0.99
processSlot - 1 slots 19.123 us/op 19.877 us/op 0.96
processSlot - 32 slots 3.5935 ms/op 3.6167 ms/op 0.99
getEffectiveBalanceIncrementsZeroInactive - 250000 vs - 7PWei 62.365 ms/op 63.741 ms/op 0.98
getCommitteeAssignments - req 1 vs - 250000 vc 2.8296 ms/op 2.7890 ms/op 1.01
getCommitteeAssignments - req 100 vs - 250000 vc 4.1401 ms/op 4.0366 ms/op 1.03
getCommitteeAssignments - req 1000 vs - 250000 vc 4.4275 ms/op 4.4190 ms/op 1.00
findModifiedValidators - 10000 modified validators 355.95 ms/op 387.63 ms/op 0.92
findModifiedValidators - 1000 modified validators 243.69 ms/op 233.15 ms/op 1.05
findModifiedValidators - 100 modified validators 200.11 ms/op 210.04 ms/op 0.95
findModifiedValidators - 10 modified validators 207.19 ms/op 232.89 ms/op 0.89
findModifiedValidators - 1 modified validators 207.09 ms/op 215.68 ms/op 0.96
findModifiedValidators - no difference 191.44 ms/op 313.93 ms/op 0.61
compare ViewDUs 4.9007 s/op 4.9613 s/op 0.99
compare each validator Uint8Array 1.5857 s/op 1.8057 s/op 0.88
compare ViewDU to Uint8Array 1.5523 s/op 1.4496 s/op 1.07
migrate state 1000000 validators, 24 modified, 0 new 905.10 ms/op 821.38 ms/op 1.10
migrate state 1000000 validators, 1700 modified, 1000 new 1.5251 s/op 1.1055 s/op 1.38
migrate state 1000000 validators, 3400 modified, 2000 new 1.7096 s/op 1.3048 s/op 1.31
migrate state 1500000 validators, 24 modified, 0 new 1.0756 s/op 752.09 ms/op 1.43
migrate state 1500000 validators, 1700 modified, 1000 new 1.1611 s/op 1.0388 s/op 1.12
migrate state 1500000 validators, 3400 modified, 2000 new 1.5623 s/op 1.2635 s/op 1.24
RootCache.getBlockRootAtSlot - 250000 vs - 7PWei 5.3200 ns/op 4.2900 ns/op 1.24
state getBlockRootAtSlot - 250000 vs - 7PWei 878.13 ns/op 867.42 ns/op 1.01
computeProposers - vc 250000 10.779 ms/op 9.6279 ms/op 1.12
computeEpochShuffling - vc 250000 133.63 ms/op 127.56 ms/op 1.05
getNextSyncCommittee - vc 250000 181.52 ms/op 164.83 ms/op 1.10
computeSigningRoot for AttestationData 34.344 us/op 24.798 us/op 1.38
hash AttestationData serialized data then Buffer.toString(base64) 2.6166 us/op 2.3016 us/op 1.14
toHexString serialized data 1.5886 us/op 1.0486 us/op 1.51
Buffer.toString(base64) 277.17 ns/op 208.46 ns/op 1.33

by benchmarkbot/action

matthewkeil
matthewkeil approved these changes Apr 5, 2024
View reviewed changes
Copy link
Member

@matthewkeil matthewkeil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch dude!! You 🪨 thoroughly!!! 🎸

@nazarhussain nazarhussain merged commit f2ec0d4 into unstable Apr 5, 2024
21 checks passed
@nazarhussain nazarhussain deleted the nh/sim-docker-fix branch April 5, 2024 15:37
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewkeil matthewkeil matthewkeil approved these changes

Assignees

@nazarhussain nazarhussain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nazarhussain @wemeetagain @matthewkeil