Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add list of public endpoints to getting started page #6644

Merged
merged 1 commit into from Apr 8, 2024

Conversation

wakamex
Copy link
Contributor

@wakamex wakamex commented Apr 5, 2024

Motivation

I found it frustrating not being able to start up a Lodestar node without having to google for public endpoints, which actually sent me to the docs of another CL client. Having to do that is much more error-prone than following a link from your docs.

Description

I added a link to the same public endpoints page linked from the docs of another major CL client.
I don't think an additional at your own risk is necessary here, since this link is already in the warning block that starts off with Please use this option very carefully (and at your own risk).

@wakamex wakamex requested a review from a team as a code owner April 5, 2024 22:22
@CLAassistant
Copy link

CLAassistant commented Apr 5, 2024

CLA assistant check
All committers have signed the CLA.

@wakamex wakamex changed the title add list of public endpoints to getting started docs feat: add list of public endpoints to getting started docs Apr 5, 2024
@nflaig nflaig changed the title feat: add list of public endpoints to getting started docs docs: add list of public endpoints to getting started docs Apr 5, 2024
@nflaig nflaig changed the title docs: add list of public endpoints to getting started docs docs: add list of public endpoints to getting started page Apr 5, 2024
Copy link
Member

@nflaig nflaig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to add this link, much better than having people use google to find it.

Thanks @wakamex

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Merging #6644 (c9ca2a0) into unstable (f2ec0d4) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #6644   +/-   ##
=========================================
  Coverage     61.69%   61.69%           
=========================================
  Files           556      556           
  Lines         58820    58820           
  Branches       1887     1887           
=========================================
  Hits          36287    36287           
  Misses        22492    22492           
  Partials         41       41           

@nflaig nflaig merged commit d450cce into ChainSafe:unstable Apr 8, 2024
22 of 23 checks passed
@wemeetagain
Copy link
Member

🎉 This PR is included in v1.18.0 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants