Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement execution layer exits eip 7002 #6651

Merged
merged 4 commits into from
Apr 22, 2024
Merged

feat: implement execution layer exits eip 7002 #6651

merged 4 commits into from
Apr 22, 2024

Conversation

g11tech
Copy link
Contributor

@g11tech g11tech commented Apr 8, 2024

@g11tech g11tech requested a review from a team as a code owner April 8, 2024 14:21
@philknows philknows mentioned this pull request Apr 9, 2024
Open
31 tasks
@codecov Codecov
Copy link

codecov bot commented Apr 10, 2024 •
edited

Codecov Report

❗ No coverage uploaded for pull request base (electra-fork@5808ddb). Click here to learn what that means.
The diff coverage is 43.61%.

Additional details and impacted files 
@@               Coverage Diff               @@
##             electra-fork    #6651   +/-   ##
===============================================
  Coverage                ?   61.94%           
===============================================
  Files                   ?      563           
  Lines                   ?    59935           
  Branches                ?     1905           
===============================================
  Hits                    ?    37128           
  Misses                  ?    22766           
  Partials                ?       41

@g11tech g11tech force-pushed the electra-fork branch 2 times, most recently from 8a4f66e to 473a04f Compare April 11, 2024 11:12
ensi321
ensi321 reviewed Apr 13, 2024
View reviewed changes
Copy link
Contributor

@ensi321 ensi321 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#6646 should already fixed some of the CI issues in blockRewards.test.ts and electra-interop.test.ts. Please pull the latest changes from electra-fork branch

wemeetagain
wemeetagain reviewed Apr 15, 2024
View reviewed changes
Copy link
Member

@wemeetagain wemeetagain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed with @tuyennhv 's comments, otherwise LGTM 🚀

@g11tech
Copy link
Contributor Author

g11tech commented Apr 22, 2024

merging with electra fork for now any other changes could be addressed later

@g11tech g11tech merged commit 4828e06 into electra-fork Apr 22, 2024
14 of 17 checks passed
@g11tech g11tech deleted the elexits-7002 branch April 22, 2024 13:48
g11tech added a commit that referenced this pull request May 4, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
30bdac7 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
g11tech added a commit that referenced this pull request May 24, 2024
@g11tech
feat: implement execution layer exits eip 7002 (#6651)
851b7c9 
* feat: implement execution layer exits eip 7002

* lint and tsc fix

* apply feedback

* improve comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wemeetagain wemeetagain wemeetagain left review comments

@twoeths twoeths twoeths left review comments

@ensi321 ensi321 ensi321 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@g11tech @wemeetagain @twoeths @ensi321