chore: reuse setup action #6659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested changes
Apr 11, 2024
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: 20 | ||
| check-latest: true |
There was a problem hiding this comment.
Only thing missing would be this check. Could you pass this down to the action as well.
There was a problem hiding this comment.
Sorry I didn't remember if build-setup action already have check-latest. Please ignore this comment.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6659 +/- ##
=========================================
Coverage 61.67% 61.67%
=========================================
Files 556 556
Lines 58834 58834
Branches 1888 1888
=========================================
Hits 36288 36288
Misses 22505 22505
Partials 41 41 |
nazarhussain
approved these changes
Apr 11, 2024
|
🎉 This PR is included in v1.18.0 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Reuse existing GitHub action to reduce boilerplate duplication