New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: unify blockStateCache naming convention #6695
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #6695 +/- ##
============================================
- Coverage 61.87% 61.87% -0.01%
============================================
Files 557 557
Lines 59200 59201 +1
Branches 1915 1915
============================================
Hits 36628 36628
- Misses 22529 22530 +1
Partials 43 43 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
approved these changes
Apr 22, 2024
🎉 This PR is included in v1.18.0 🎉 |
nflaig
added a commit
that referenced
this pull request
Apr 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
StateContextCache
is quite general and it does not tell this is a cache of block statesDescription
BlockStateCacheImpl
blockStateCache
every where instead ofstateCache
, this differentiatesblockStateCache
vscheckpointStateCache
part of #5968