Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add arm64 binary support #6707

Merged
merged 4 commits into from
Apr 26, 2024
Merged

feat: add arm64 binary support #6707

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7cd32a9
feat: add arm64 binary support
jeluard Apr 25, 2024
46ada0a
chore: workaround yarn
jeluard Apr 25, 2024
5da8959
chore: add comment
jeluard Apr 25, 2024
52de601
chore: workaround runner limitations
jeluard Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions .github/workflows/binaries.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,19 +19,31 @@ jobs:
matrix:
include:
- os: ubuntu-latest
build: |
npx caxa -m "Unpacking Lodestar binary, please wait..." -e "dashboards/**" -e "docs/**" -D -p "yarn install --frozen-lockfile --production" --input . --output "lodestar" -- "{{caxa}}/node_modules/.bin/node" "--max-old-space-size=8192" "{{caxa}}/node_modules/.bin/lodestar"
tar -czf "dist/lodestar-${{ inputs.version }}-linux-amd64.tar.gz" "lodestar"
platform: linux
arch: amd64
- os: lodestar-arm64-runner
platform: linux
arch: arm64
runs-on: ${{matrix.os}}
steps:
- uses: actions/checkout@v4
# Install yarn for arm64 as currently it's not part of the provided image
# See https://github.com/github-early-access/arm-runners-beta/issues/5
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have access to this link, just getting a 404

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, you have to be part of the private beta. Keeping it here for future reference.
Once it moves out of beta I would expect yarn to be installed by default.

- name: Install yarn
if: matrix.arch == 'arm64'
run: |-
curl -fsSL --create-dirs -o $HOME/bin/yarn \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this required for arm64?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a limitation of the current arm64 runner image

https://github.com/yarnpkg/yarn/releases/download/v1.22.22/yarn-1.22.22.js
chmod +x $HOME/bin/yarn
echo "$HOME/bin" >> $GITHUB_PATH
- uses: "./.github/actions/setup-and-build"
with:
node: 20
- run: |
mkdir -p dist
yarn global add caxa@3.0.1
${{ matrix.build }}
npx caxa -m "Unpacking Lodestar binary, please wait..." -e "dashboards/**" -e "docs/**" -D -p "yarn install --frozen-lockfile --production" --input . --output "lodestar" -- "{{caxa}}/node_modules/.bin/node" "--max-old-space-size=8192" "{{caxa}}/node_modules/.bin/lodestar"
tar -czf "dist/lodestar-${{ inputs.version }}-${{ matrix.platform }}-${{ matrix.arch }}.tar.gz" "lodestar"
- name: Upload binaries
uses: actions/upload-artifact@v4
with:
Expand Down
Loading