fix: publish electra attestations / aggregates through api #6759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nflaig
force-pushed
the
nflaig/electra-publish-apis
branch
from
0ed6efc
to
5b7a048
Compare
nflaig
commented
May 10, 2024
| }; | ||
| }, | ||
| parseReq: ({body, headers}) => [ | ||
| ArrayOf(ssz.allForks[headers["eth-consensus-version"]].SignedAggregateAndProof).fromJson(body), |
There was a problem hiding this comment.
header must be lower case as Fastify will convert all headers to lower case, this is much better handled on the refactor branch but I think we are fine with skipping input validation here
ensi321
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes publishing of electra attestations and aggregates through api
Description
Make publish apis fork aware to correctly de-/serialize electra attestations and aggregates.
NOTE: This is not a long-term approach we can use, a proper solution requires to add new v2 apis which are fork aware