feat: handle exited/exiting validators during top up #6880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
reviewed
Jun 18, 2024
wemeetagain
approved these changes
Jun 18, 2024
twoeths
reviewed
Jun 19, 2024
| if (processedAmount + amount > availableForProcessing) { | ||
| break; | ||
| const {amount, index: depositIndex} = deposit; | ||
| const validator = state.validators.get(depositIndex); |
There was a problem hiding this comment.
Suggested change
| const validator = state.validators.get(depositIndex); | |
| const validator = state.validators.getReadOnly(depositIndex); |
twoeths
approved these changes
Jun 20, 2024
ensi321
force-pushed
the
nc/exit-validator
branch
from
70483b6
to
4d389e1
Compare
ensi321
force-pushed
the
nc/exit-validator
branch
from
4d389e1
to
9d37448
Compare
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Handle exiting validataor * lint * Add todo
g11tech
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Handle exiting validataor * lint * Add todo
g11tech
pushed a commit
that referenced
this pull request
Jul 1, 2024
* Handle exiting validataor * lint * Add todo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle deposit for exiting and exited validators:
state.pendingBalanceDepositsviadepositsToPostponestate.depositBalanceToConsume)Spec PR: ethereum/consensus-specs#3776