Greg/initial state && The Great Refactor #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
ansermino
requested changes
Jan 7, 2019
GregTheGreek
changed the title
wemeetagain
reviewed
Jan 19, 2019
Merged
ansermino
approved these changes
Jan 22, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was to establish the base functions for getting the initial state, which is the next step for #71
Due to some discussion around the testing I put this together to kill time and move the spec further.
In this PR:
Potential caveats:
EMPTY_SIGNATURE- (beaconChain/constants/constants.ts, Line 16) may not have been implemented correctly. I'm still wrapping my head around the Uint8Array / bytes related material. If this changes a few things will need to be adjusted within a few of the helpers inlib/index.tsbut won't be a major issue.