lodecli beacon init / run #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
mpetrunic
reviewed
Apr 28, 2020
| } | ||
|
|
||
| process.on("SIGTERM", cleanup); | ||
| process.on("SIGINT", cleanup); |
There was a problem hiding this comment.
Maybe we should use https://github.com/jtlapp/node-cleanup/blob/master/node-cleanup.js as it handles all signals and exceptions
|
Looks great. Do we want to start moving some e2e tests to lodecli? |
|
@tuyennhv Yes! I'll add the beacon e2e test. (and update lodecli to include the work in #843) |
|
I added some sanity unit tests, but the beacon node is currently not stable enough to run in a meaningful e2e test. I'll make an issue for this |
mpetrunic
approved these changes
May 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.