Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize types and add consistency tests #91

Merged
merged 1 commit into from
Feb 7, 2019

Conversation

wemeetagain
Copy link
Member

Resolves #83 and the first part of #84

The added tests compare our interface definitions against our variable definitions to ensure that:

  1. For every interface, a "runtime type" variable of the same name exists
  2. For every field (in every interface), the same field name and type is defined in the corresponding "runtime type" variable's field

As part of this, the types have been reorganized:

  • to be in dependency order (eg: if interface A relies on interface B, A has been moved before interface B)
  • primitive types (eg: bytes, uint64, etc) have been moved into their own file
  • attestation types have been moved into their own file

Also, all var runtime types have been turned into consts.

Copy link
Member

@GregTheGreek GregTheGreek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this, also much needed refactor 👍

@GregTheGreek GregTheGreek mentioned this pull request Feb 7, 2019
2 tasks
@GregTheGreek GregTheGreek merged commit edb9959 into master Feb 7, 2019
@ChainSafeSystems ChainSafeSystems deleted the 83-test-interface-consistency branch February 11, 2019 18:53
wemeetagain pushed a commit that referenced this pull request Aug 2, 2019
signing root should hash truncated type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants