Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: verify ts type defs with eslint #15

Merged
merged 2 commits into from
Jul 27, 2022
Merged

chore: verify ts type defs with eslint #15

merged 2 commits into from
Jul 27, 2022

Conversation

hanabi1224
Copy link
Contributor

@hanabi1224 hanabi1224 commented Jul 20, 2022 •
edited
Loading

Changes:

  • Convert integration test to typescript
  • Run eslint to verify generated type definations
  • Fix cargo clippy warnings

mpetrunic
mpetrunic reviewed Jul 26, 2022
View reviewed changes
examples/integration_tests/.eslintrc.cjs Outdated
@@ -0,0 +1,11 @@
module.exports = {
root: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe use chainsafe configuration: https://engineering-handbook.onrender.com/development/tech-stack/typescript#linting ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@mpetrunic mpetrunic merged commit 48286bd into ChainSafe:main Jul 27, 2022
@hanabi1224 hanabi1224 deleted the ts-e2e-tests branch July 27, 2022 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpetrunic mpetrunic mpetrunic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hanabi1224 @mpetrunic