Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProviderResolver is not minification safe #2484

Closed
bwasty opened this issue Mar 11, 2019 · 0 comments · Fixed by #2521
Closed

ProviderResolver is not minification safe #2484

bwasty opened this issue Mar 11, 2019 · 0 comments · Fixed by #2521
Labels
Bug Addressing a bug

Comments

@bwasty
Copy link

bwasty commented Mar 11, 2019

I got weird RPC errors when building for production (using Parcel), which I tracked down to this:
https://github.com/ethereum/web3.js/blob/970d837768f924febe377df39824d2ab9e13a55a/packages/web3-providers/src/resolvers/ProviderResolver.js#L97-L108
Constructor names are not available in minified code, so I end up with a CustomProvider (see resolve method above isWeb3Provider).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Addressing a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ProviderResolver is now minification save web3/web3.js
2 participants
@bwasty @nivida