Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

this.getGasPrice is not a function; GasPriceMethod vs GetGasPriceMethod #2558

Closed
Fang- opened this issue Mar 22, 2019 · 1 comment · Fixed by #2566
Closed

this.getGasPrice is not a function; GasPriceMethod vs GetGasPriceMethod #2558

Fang- opened this issue Mar 22, 2019 · 1 comment · Fixed by #2566
Labels
Bug Addressing a bug

Comments

@Fang-
Copy link

Fang- commented Mar 22, 2019

This is on version 1.0.0-beta.50. Trying to sign a transaction fails with:

(node:87086) UnhandledPromiseRejectionWarning: TypeError: this.getGasPrice is not a function
    at Proxy._callee$ (/path/to/node_modules/web3-eth-accounts/dist/web3-eth-accounts.cjs.js:387:29)

I looked into the code that stack trace is pointing to, and it seems getGasPrice is indeed undefined there. I found a fix for it, but it feels a bit too straight-forward, so I'm suspicious I'm just doing something dumb. If someone could do a sanity check on the below that'd be great.

Shouldn't this say GetGasPriceMethod instead, in line with this?

@nivida nivida added the Bug Addressing a bug label Mar 23, 2019
@nivida
Copy link
Contributor

nivida commented Mar 23, 2019

Thanks for opening this issue! I'll fix it tomorrow and will release it asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants