Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ContractModuleFactory expects only three arguments, receives four. #2670

Closed
levino opened this issue Apr 12, 2019 · 1 comment · Fixed by #2702
Closed

ContractModuleFactory expects only three arguments, receives four. #2670

levino opened this issue Apr 12, 2019 · 1 comment · Fixed by #2702
Labels
Bug Addressing a bug
Projects

Comments

@levino
Copy link
Contributor

levino commented Apr 12, 2019

https://github.com/ethereum/web3.js/blob/441c309d3304ffbc36fca4ef483adf314b5f4801/packages/web3-eth-contract/src/factories/ContractModuleFactory.js#L41-L49

https://github.com/ethereum/web3.js/blob/441c309d3304ffbc36fca4ef483adf314b5f4801/packages/web3-eth-contract/src/index.js#L49

I came across this because my IDE is screaming at me "This makes no sense" (static code analysis):
Selection_108

Should not be very difficult to add some sort of static code analysis for this kind of stuff.

@princesinha19
Copy link
Contributor

@levino Yes, I think accounts is unnecessary parameter over there. we will remove it.

@nivida nivida added the Bug Addressing a bug label Apr 14, 2019
@nivida nivida added this to To do in 1.0 Apr 15, 2019
@nivida nivida moved this from Proposed To Do's to Accepted To Do's in 1.0 Apr 15, 2019
1.0 automation moved this from Accepted To Do's to Done Apr 17, 2019
@nivida nivida mentioned this issue Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
No open projects
1.0
  
Done
Development

Successfully merging a pull request may close this issue.

3 participants