Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename sha3 to keccak256 #2707

Closed
1 task done
princesinha19 opened this issue Apr 18, 2019 · 0 comments · Fixed by #2710
Closed
1 task done

Rename sha3 to keccak256 #2707

princesinha19 opened this issue Apr 18, 2019 · 0 comments · Fixed by #2710
Labels
Enhancement Includes improvements or optimizations
Projects
1.0

Comments

@princesinha19
Copy link
Contributor

princesinha19 commented Apr 18, 2019 •
edited

As per EIP56, I think we should rename sha3 to keccak256.
https://web3js.readthedocs.io/en/1.0/web3-utils.html?highlight=sha3#sha3

We can still put sha3, an alias of keccak256 if someone wants.

  • Enhancement
@princesinha19 princesinha19 changed the title Rename sha3 to keccack256 Rename sha3 to keccak256 Apr 19, 2019
@princesinha19 princesinha19 mentioned this issue Apr 19, 2019
Merged
12 tasks
@nivida nivida added the Enhancement Includes improvements or optimizations label Apr 19, 2019
@nivida nivida added this to Proposed To Do's in 1.0 Apr 19, 2019
1.0 automation moved this from Proposed To Do's to Done Apr 23, 2019
@nivida nivida mentioned this issue Apr 29, 2019
Merged
12 tasks
@alcuadrado alcuadrado mentioned this issue Sep 16, 2019
Closed
@snyk-bot snyk-bot mentioned this issue Feb 4, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement Includes improvements or optimizations
Projects
No open projects
1.0
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Renaming sha3 to keccak256 princesinha19/web3.js
2 participants
@nivida @princesinha19