Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error handling of subscriptions #2731

Closed
alejagapatrick opened this issue Apr 25, 2019 · 1 comment · Fixed by #2737
Closed

Improve error handling of subscriptions #2731

alejagapatrick opened this issue Apr 25, 2019 · 1 comment · Fixed by #2737
Labels
Bug Addressing a bug
Projects

Comments

@alejagapatrick
Copy link

@nivida That's it, thank you. 🤦‍♂️ Looks like I copied https endpoint and changed to wss, missing the /ws.

Is it the correct behavior for web3.eth.subscribe to not log an error when the provider is responding with 404 errors? If the callback for web3.eth.subscribe isn't the place to catch the 404, where would be the correct place?

Originally posted by @carterbrett in #2706 (comment)

@nivida
Copy link
Contributor

nivida commented Apr 25, 2019

Thanks for opening this issue!
No this isn't the correct behavior. I will add the socket error handling here.

@nivida nivida changed the title @nivida That's it, thank you. 🤦‍♂️ Looks like I copied https endpoint and changed to wss, missing the /ws. Improve error handling of subscriptions Apr 25, 2019
@nivida nivida added the Bug Addressing a bug label Apr 25, 2019
@nivida nivida added this to Accepted To Do's in 1.0 Apr 25, 2019
1.0 automation moved this from Accepted To Do's to Done Apr 26, 2019
@nivida nivida mentioned this issue Apr 29, 2019
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Addressing a bug
Projects
No open projects
1.0
  
Done
Development

Successfully merging a pull request may close this issue.

2 participants