-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EIP-838 Error Codes #4235
Comments
This will be addressed in the 4.x rewrite. |
@philknows Is there a timeline for that? 🙂 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Still important. OpenZeppelin Contracts is blocked from adopting custom errors until Web3.js supports them. |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Not stale! Waiting patiently. 😁 |
Seems like they plan to release version 4.x in April: RELEASE.md#long-term-support-lts |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
gm. Dear bot remove the stale label. 😃 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
@TomiOhl is this issue still active |
Yes, it very much is.Haven't tried the one on the 4.x branch yet, but it isn't addressed in the latest 1.x release afaik |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment. |
Well, 4.x definitely wasn't released in April. Waiting |
Hey @TomiOhl, we recently released 4.x Alpha last week. Still working diligently now on our Beta release for later this year. |
Please @Muhammad-Altabba 🙏🙏🙏 |
Sorry I got busy with other tasks and was also sick for a couple of days 🥲 . However, I will start working on it very soon 😊... |
Any progress on this? |
|
Expected behavior
It would be nice to be able to get the new, custom error codes with their arguments, introduced in Solidity 0.8.4.
Ethers.js already supports them: https://github.com/shapeshift/ethers.js/blob/master/packages/tests/src.ts/test-contract-interface.ts#L636
Actual behavior
If I try to catch the error as in the link above, I get the following error message:
Error: Returned error: VM Exception while processing transaction: revert
Error code, error name, etc. are all undefined
Steps to reproduce the behavior
Environment
Web3.js v1.5.1
Node v12.18.4
elementary OS 5.1.7
The text was updated successfully, but these errors were encountered: