Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a MissingRole custom error in AccessControl #2725

Closed
wants to merge 4 commits into from
Closed

Add a MissingRole custom error in AccessControl #2725

wants to merge 4 commits into from

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Jun 17, 2021 •
edited

Use the custom errors introduced in 0.8.4 to reduce gas cost and improve clarity of revert reasons.

Next steps:

  • Identify which reasons to replace
  • Define custom error format
  • Decide where/how to declare the errors
  • Update tests

PR Checklist

  • Tests
  • Documentation
  • Changelog entry

@Amxx Amxx marked this pull request as draft June 17, 2021 13:03
@frangio frangio added the on hold Put on hold for some reason that must be specified in a comment. label Sep 2, 2021
@frangio
Copy link
Contributor

frangio commented Sep 2, 2021

Waiting for Web3.js support. web3/web3.js#4235

@Amxx Amxx mentioned this pull request Aug 12, 2022
Closed
3 tasks
@frangio frangio removed the on hold Put on hold for some reason that must be specified in a comment. label Jul 3, 2023
@frangio
Copy link
Contributor

frangio commented Jul 3, 2023

Fixed in #4261

@frangio frangio closed this Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Amxx @frangio