Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics fix #342

Merged
merged 4 commits into from
Feb 27, 2023
Merged

analytics fix #342

merged 4 commits into from
Feb 27, 2023

Conversation

sneakzttv
Copy link
Contributor

analytics fix

@sneakzttv
analytics fix
d9540ab 
analytics fix
KBryan
KBryan reviewed Feb 24, 2023
View reviewed changes
Copy link
Contributor

@KBryan KBryan left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm looking at this, and you are missing getters and setters for the values. You may also want to add [SerializeField] to your properties if you are not already doing so in your update.

public string projectId
{
get { return ProjectID; }
set { ProjectID = value; }
}

Or something to that effect, taking into account the syntax you provided.

@sneakzttv
Copy link
Contributor Author

fixed @KBryan @juans-chainsafe

juans-chainsafe
juans-chainsafe approved these changes Feb 27, 2023
View reviewed changes
Copy link
Contributor

@juans-chainsafe juans-chainsafe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on WebGL build and transition scenes is working as well!

@juans-chainsafe juans-chainsafe merged commit 2c12afb into main Feb 27, 2023
@sneakzttv sneakzttv deleted the analytics-fix branch February 27, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KBryan KBryan KBryan approved these changes

@juans-chainsafe juans-chainsafe juans-chainsafe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sneakzttv @KBryan @juans-chainsafe