-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web3GL Template - Onboard.js Overhaul #348
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The following wallets are not working:
- Crypto.com
- Wallet3
- Exodus
- Bobablocks
- Verso
Example error:Failed to launch 'cryptowallet://wc?uri=wc%3A2babb67a-2f0d-4d04-a285-a04a6c2d5bf8%401%3Fbridge%3Dhttps%253A%252F%252Fx.bridge.walletconnect.org%26key%3D73ecfb1cf0a8ad4796d41257cbf1308d871d14684ca698510e3e897e729779bf' because the scheme does not have a registered handler.
Also, Wallet3 is repeated in page 1 and page 2
gj @juans-chainsafe i didn't even think to check the alternate wallets, i just checked metamask and wc, my fault there. |
@juans-chainsafe Thanks for the rigorous testing, though I'm unsure if thats within the scope of what I can do in this code base. Like wallet connect is a standard, so if those wallets dont implement it, then I'm not sure, it says we need a registered handler, but as far as onboard is concerned, wallet connect is wallet connect and I just specify a bridge if I want. @FSM1 ever seen this? |
This is the reference set up config |
So those links you were trying to open appear to be for opening up apps on mobile. The apps name as the protocol portion should normally deep link open the specific app. You make reference to |
@juans-chainsafe Ahh ok, so thats wallet connects specific pages. Wallet connect is for connecting wallets that aren't installed on the local machine via a QR code or deep linking. You're clicking |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
due that the above errors are not on our side, I approve this PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets light this bad boy up
Changelog