Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support web3js patch 2: fix email testing #3

Conversation

Muhammad-Altabba
Copy link
Member

@Muhammad-Altabba Muhammad-Altabba commented Apr 30, 2024

Breaking Changes

N/A

Changes

  • feat: add and use env variable EMAIL_DOMAIN
  • fix: ensure email testing passes at apps/laboratory

Associated Issues

closes web3/web3.js#6995

@Muhammad-Altabba Muhammad-Altabba marked this pull request as ready for review April 30, 2024 16:49
@Muhammad-Altabba
Copy link
Member Author

Email testing is working
image

Note: locally had to comment the line that ignore the email tests: testIgnore: /(?:email\.spec\.ts|smart-account\.spec\.ts).*$/u,

@Muhammad-Altabba Muhammad-Altabba merged commit d1baf4c into feat/support-web3js Apr 30, 2024
1 check passed
@Muhammad-Altabba Muhammad-Altabba deleted the feat/support-web3js-patch-2-fix-email-testing branch April 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant