Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navbar #13

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Navbar #13

merged 2 commits into from
Oct 17, 2023

Conversation

Harsh06-afk
Copy link
Contributor

@Harsh06-afk Harsh06-afk commented Oct 15, 2023 •
edited
Loading

I have added a navbar and initial text similar to https://ip-api.com/ mention.
Fixes #5

ChakshuGautam
ChakshuGautam reviewed Oct 15, 2023
View reviewed changes
Copy link
Owner

@ChakshuGautam ChakshuGautam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a screenshot of this? Unless I link Vercel would be difficult to visualize this.

public/assest/logo.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's create a logo for us using Bing AI (dall-e)

Copy link
Contributor Author

@Harsh06-afk Harsh06-afk Oct 15, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to create a logo/favicon for some geolocation IP site like https://ip-api.com/ right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

these are 4 bing AI generated logo, what's your thought on this (personally I find bottom left logo apt)

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see a pencil in all four of them. Is that part of the prompt. Right now it show the exercise of designing it as well (by a person) or could be something else that I am reading.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It wasn't a prompt, just AI things

public/assest/bg.png
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this asset and use something original.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide me a basic overview of what we are building upon which I'll find something original

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this for now. Even without it, it's a lot of improvement over what we have right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay sure

@Harsh06-afk
Copy link
Contributor Author

Harsh06-afk commented Oct 15, 2023 •
edited
Loading

image

Here is something I built roughly to raise the PR

@Harsh06-afk Harsh06-afk changed the title NAVBAR Navbar Oct 15, 2023
@ChakshuGautam ChakshuGautam merged commit 875e796 into ChakshuGautam:master Oct 17, 2023
1 check passed
@Harsh06-afk
Copy link
Contributor Author

@ChakshuGautam I can create that whole site if you can guide me through your requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChakshuGautam ChakshuGautam ChakshuGautam left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup Home and Documentation Pages
2 participants
@Harsh06-afk @ChakshuGautam