-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue: 138 | Migrated project JS architecture to NestJS #143
base: master
Are you sure you want to change the base?
Issue: 138 | Migrated project JS architecture to NestJS #143
Conversation
Hey @Abhinav-Saxena-dev this is brilliant!!! Give me a couple of days to review this. I was swamped earlier. Will start reviewing today onwards. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's make these change first before I review this further.
server/geojson-data/indian_villages_boundaries.zip/andaman_and_nicobar/NICOBAR.zip
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests need to be migrated too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test cases have been updated
#138
Description
Project Structure
Testing Screenshots
1. /city/{ip}
cURL:
curl --location --request GET 'http://localhost:3000/city/2401:4900:1c82:377e:bb89:dfc9:28a1:1e06'
2. /city/batch
cURL:
curl --location --request POST 'http://localhost:3000/city/batch' \ --header 'Content-Type: application/json' \ --data-raw '{ "ips": ["128.101.101.101", "2401:4900:1c82:377e:bb89:dfc9:28a1:1e06"] }'
3. /georev
cURL:
curl --location --request GET 'http://localhost:3000/georev?lat=28.7041&lon=77.1025 ' \ --header 'Content-Type: application/json' \ --data-raw '{ "ips": ["128.101.101.101", "2401:4900:1c82:377e:bb89:dfc9:28a1:1e06"] }'
4. /location/{locationlevel}/centroid
cURL:
curl --location --request GET 'http://localhost:3000/location/DISTRICT/centroid?query=lucknow'
5. /location/{locationlevel}/fuzzysearch
cURL:
curl --location --request POST 'http://localhost:3000/location/VILLAGE/fuzzysearch' \ --header 'Content-Type: application/json' \ --data-raw '{ "query": "Arong", "filter": { "STATE": "Andaman & Nicobar Islands", "DISTRICT": "Nicobars" } }'
Tasks / Sequence of task completion