Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate to bun #6

Merged
merged 2 commits into from
Oct 15, 2023
Merged

Conversation

AhsanAyaz
Copy link
Contributor

added a Dockerfile
migrated to bun with bun.lockb

fixes #3

added a Dockerfile
migrated to bun with bun.lockb
@ChakshuGautam
Copy link
Owner

Can you please add bun.serve as part of this PR too?

@AhsanAyaz
Copy link
Contributor Author

@ChakshuGautam take a look.

@ChakshuGautam
Copy link
Owner

Hey @AhsanAyaz great job!!! 👍🏻

can you please share your steps on how to deploy this to render as part of first message (this will act as documentation for someone trying to deploy this) + additional screenshot of home page + working curl.

Planning to add all of this to a section in readme - which would be the next step.

@AhsanAyaz
Copy link
Contributor Author

I think we're saturating this PR too much to become a big one. I would suggest merging this one and then adding another one that works on deploying to render. The intent of the task (migrating to bun) has been done so far. I usually avoid huge PRs myself as well.
Can we create a new ticket for the render.com part? I can pick that when i get the chance.

@ChakshuGautam
Copy link
Owner

Makes sense.

The coupling of CD and code is causing issues here. There is no feedback loop if the code is deployable to an infra (being render here). Will create a ticket on how to test that + make it available as part of CI on PR (another issue).

Let me know your thoughts on the same. Don't want to to review PRs blind but should be fine at an early stage project.

@ChakshuGautam ChakshuGautam merged commit 511a138 into ChakshuGautam:master Oct 15, 2023
1 check passed
@ChakshuGautam
Copy link
Owner

@AhsanAyaz related issue opened for Docs - #10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate server to Bun
2 participants