Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add script to parse gdb to geoJSONs #86

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

35C4n0r
Copy link
Collaborator

@35C4n0r 35C4n0r commented Feb 5, 2024

Closes #30
Added the script for converting the .gdb filed to .geoJSON
Added two new dependencies

  • "fgdb": "^1.0.0"
  • "jszip": "^3.10.1"

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 5, 2024

@dhruv-1001 @ChakshuGautam kindly give it a review.

@dhruv-1001
Copy link
Collaborator

Hey, @35C4n0r, any update on this?

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 9, 2024

@dhruv-1001 the script is already ready for review, is there anything else that needs to be added?
Edit: Oh, do I need to add it to the ./setup.sh?

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 9, 2024

@dhruv-1001 also indian_villages_boundaries.zip is not a zip, it's just named as .zip, is it supposed to be like that ?

@dhruv-1001
Copy link
Collaborator

@dhruv-1001 the script is already ready for review, is there anything else that needs to be added? Edit: Oh, do I need to add it to the ./setup.sh?

Yeah, can you do that, and test it out.

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 12, 2024

@dhruv-1001 also indian_villages_boundaries.zip is not a zip, it's just named as .zip, is it supposed to be like that ?

What about this?

@dhruv-1001
Copy link
Collaborator

@dhruv-1001 also indian_villages_boundaries.zip is not a zip, it's just named as .zip, is it supposed to be like that ?

What about this?

Yeah, that's right.

@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 12, 2024

@dhruv-1001 updated the script accordingly.
Also I request you to merge it with latest main from your side, this is because I have ok Internet not too fast, not too slow, but for some reason cloning or ferching this repo has become almost impossible for me. If you have any resolution for it let me know @dhruv-1001 @ChakshuGautam . I have tried cloning it with --depth=0 that works, but I don't know how to fetch only after the cloned part of history.

@dhruv-1001
Copy link
Collaborator

dhruv-1001 commented Feb 14, 2024

Hey @35C4n0r. Inside of server/geojson-data we have 2 directories indian_villages_boundaries.zip & indian_village_boundaries. We are collecting data for different states explained in this issue, and storing that data in indian_villages_boundaries.zip. What we want is to move gdb data from indian_villages_boundaries.zip to indian_village_boundaries after converting it to geojson format. Can you go through that data, and checkout on how it's organised, and modify the script that you wrote accordingly.

How did you check if this script is working or not? Did you test this out?

ref: refactored output destination
@35C4n0r
Copy link
Collaborator Author

35C4n0r commented Feb 14, 2024

@dhruv-1001 Done! The code already has safety features in place such that we can be versatile with where we output things, Just had to remove one 's' from the output_dir.
I have been testing all this while on GitHub Codespaces.

@dhruv-1001
Copy link
Collaborator

LGTM.

@dhruv-1001 dhruv-1001 merged commit 5969109 into ChakshuGautam:master Feb 19, 2024
1 of 2 checks passed
35C4n0r pushed a commit that referenced this pull request Jun 5, 2024
feat: add script to parse gdb to geoJSONs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Script to convert .gdb to geoJSON
2 participants