Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update isValidJSON.md #439

Merged
merged 2 commits into from
Dec 31, 2017
Merged

Update isValidJSON.md #439

merged 2 commits into from
Dec 31, 2017

Conversation

rohitanwar
Copy link
Contributor

Description

Update isValidJSON.md so isValidJSON(null) returns false

What does your PR belong to?

  • Website
  • Snippets
  • General / Things regarding the repository (like CI Integration)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a snippet)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Lodash Backlog

  • I added the prefix [UPDATE: method.md] or [ADD: method.md]
  • I have referenced the method to the lodash backlog.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

@Chalarangelo Chalarangelo merged commit e772c9e into Chalarangelo:master Dec 31, 2017
@rohitanwar rohitanwar deleted the patch-2 branch December 31, 2017 13:21
@lock
Copy link

lock bot commented Dec 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Chalarangelo pushed a commit that referenced this pull request May 1, 2023
@Trinityyi
Update combine_values.md
ac0e57c 
Fixes #439
Chalarangelo added a commit that referenced this pull request May 1, 2023
@Chalarangelo
Merge pull request #441 from 30-seconds/Trinityyi-patch-1
4d7e262 
Update combine_values.md
Fixes #439
Closes #440
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rohitanwar @Chalarangelo