Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ADD: defer.md] defer #454

Merged
merged 3 commits into from Jan 2, 2018
Merged

[ADD: defer.md] defer #454

merged 3 commits into from Jan 2, 2018

Conversation

atomiks
Copy link
Contributor

@atomiks atomiks commented Jan 1, 2018

Description

Lodash[ADD defer.md] #100 -> https://lodash.com/docs/4.17.4#defer

What does your PR belong to?

  • Website
  • Snippets
  • General / Things regarding the repository (like CI Integration)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a snippet)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Lodash Backlog

  • I added the prefix [UPDATE: method.md] or [ADD: method.md]
  • I have referenced the method to the lodash backlog.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

skatcat31
skatcat31 reviewed Jan 1, 2018
View reviewed changes
snippets/defer.md Outdated
operator to supply the function with an arbitrary number of arguments.

```js
const defer = (fn, ...args) => setTimeout(fn, 1, ...args);

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

skatcat31
skatcat31 approved these changes Jan 2, 2018
View reviewed changes
Copy link
Contributor

@skatcat31 skatcat31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either 1ms or 0ms both work. Upon checking deeper the only reason I can think of for 1ms is possible compatibility, which isn't such a bad thing with this function due to how it works

Chalarangelo
Chalarangelo approved these changes Jan 2, 2018
View reviewed changes
Copy link
Owner

@Chalarangelo Chalarangelo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing yet again!

@Chalarangelo Chalarangelo merged commit a8b1994 into Chalarangelo:master Jan 2, 2018
@kingdavidmartins kingdavidmartins mentioned this pull request Jan 2, 2018
Closed
@atomiks atomiks deleted the defer branch January 2, 2018 12:09
@lock
Copy link

lock bot commented Dec 18, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Chalarangelo Chalarangelo Chalarangelo approved these changes

@skatcat31 skatcat31 skatcat31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@atomiks @Chalarangelo @skatcat31