Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][ADD] Add forOwn and forOwnRight #559

Merged
merged 1 commit into from Jan 19, 2018
Merged

[FEATURE][ADD] Add forOwn and forOwnRight #559

merged 1 commit into from Jan 19, 2018

Conversation

Chalarangelo
Copy link
Owner

Description

Two methods for objects from lodash.

Lodash[ADD] #100 -> https://lodash.com/docs/4.17.4#forOwn
Lodash[ADD] #100 -> https://lodash.com/docs/4.17.4#forOwnRight

What does your PR belong to?

  • Website
  • Snippets
  • General / Things regarding the repository (like CI Integration)
  • Tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (non-breaking improvement of a snippet)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Lodash Backlog

  • I added the prefix [UPDATE: method.md] or [ADD: method.md]
  • I have referenced the method to the lodash backlog.

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have checked that the changes are working properly
  • I have checked that there isn't any PR doing the same
  • I have read the CONTRIBUTING document.

@skatcat31
Copy link
Contributor

@skatcat31
Copy link
Contributor

Should we call this forOwn or should we make it an object copier that is more akin to a mapObj? Or should we do a mapObj function alongside/at all?

@Chalarangelo
Copy link
Owner Author

Chalarangelo commented Jan 18, 2018

I'm thinking a mapObj function alongside this could be worthwhile as a matter of fact. While we're at it, maybe we should ditch the forIn and forInRight ones, as they are too much trouble and I do not see any reason to really add those very specific functions to begin with.

@skatcat31
Copy link
Contributor

skatcat31 commented Jan 18, 2018

Although to be fair map object is a slightly more advanced and somewhat confusing snippet

Copy link
Contributor

@skatcat31 skatcat31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Significantly different and simpler than how you would create a mapObj function

@skatcat31 skatcat31 merged commit 6a20967 into master Jan 19, 2018
@skatcat31 skatcat31 deleted the forOwn branch January 19, 2018 01:06
@lock
Copy link

lock bot commented Dec 19, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for any follow-up tasks.

@lock lock bot locked as resolved and limited conversation to collaborators Dec 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants