Usage enforcement upstream #31
Conversation
jakecoll
force-pushed
the
usage-enforcement-upstream
branch
14 times, most recently
from
9b90a6e
to
8ebb6d3
Compare
There was a problem hiding this comment.
This is looking very nice. Smart to move much of the base plugin stuff into a base class; that will really help in the future. Left some comments. The main thing that I am anticipating this needing is unit test coverage for the filter mechanism and the filters themselves. I'd start with that, and then we can see what to do about the base plugin and the new functions this adds to all the plugins.
| def get_reservation_allocations_by_fip_ids(fip_ids, start_date, end_date, | ||
| lease_id=None, reservation_id=None): | ||
| session = get_session() | ||
| border0 = start_date <= models.Lease.end_date |
There was a problem hiding this comment.
What is the type of start_date? I'm surprised this works; I would have thought that you'd need to do it like:
models.Lease.end_date >= start_date... because this looks like it has to be an operator overload, the way it's working here. And I thought those used the implementation defined by the first item's type.
There was a problem hiding this comment.
Yea, I was never too sure myself. Upstream uses this border implementation for get_reservation_allocations_by_host_ids and I implemented it this way for floating ips for consistency.
| start = datetime.datetime.utcnow() | ||
| end = datetime.date.max | ||
|
|
||
| # To reduce overhead, this method only executes one query |
There was a problem hiding this comment.
I don't quite get this comment - what is the alternative?
There was a problem hiding this comment.
This was a comment left over from a copy and paste from query_host_allocations to implement query_fip_allocations. I believe it's referring to the query in the db layer.
jakecoll
force-pushed
the
usage-enforcement-upstream
branch
3 times, most recently
from
0c0e345
to
7a62f4c
Compare
jakecoll
force-pushed
the
usage-enforcement-upstream
branch
from
7a62f4c
to
09c5afb
Compare
Implements filter based architexture for usage enforcement. Two filters are included initially. MaxReservationsLengthFilter allows operators to define the maximum reservation length of a lease in seconds. The ExternalServiceFilter sends lease values and allocation candidates to an external HTTP service where policies can be defined. All filters must be enabled in blazar.conf in an enforcement group.
jakecoll
force-pushed
the
usage-enforcement-upstream
branch
from
09c5afb
to
bf60900
Compare
No description provided.