Seekable stream reader #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry about the thousand commits :P The testing is not working in my computer and I had to develop it somehow. |
|
I can't review this because the diff is unreadable. It looks like you've changed all line endings. |
|
Sorry about the EOL. Now it is fine. I included a test with 7zip reading entries (it requires the seek callback) |
alxchk
pushed a commit
to alxchk/python-libarchive-c
that referenced
this pull request
Dec 8, 2021
Co-authored-by: Julio Martin-Hidalgo <julio.martin-hidalgo@airbus.com> Co-authored-by: Charly C <changaco@changaco.oy.lc>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the stream reader with a 7zip file, and retrieving only the entries, I received the error that the client is not seekable.
This can be solved by setting up the seek call back in the libarchive archive. Then the open function can be called as usual which set-ups the other call-backs.