Allow timestamps for add_file_from_memory #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any comment on this PR? |
Changaco
force-pushed
the
mff-enhance-add-file-from-memory
branch
from
09e262b
to
2bc6ab0
Compare
Changaco
force-pushed
the
mff-enhance-add-file-from-memory
branch
from
2bc6ab0
to
b2c8768
Compare
|
Thank you for getting this merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, any file entry added using
add_file_from_memory()is saved with uninformative epoch-zero timestamps.This is a backward-compatible enhancement designed to allow the user to add timestamps of their choosing to archives created with this method, without cumbersome workarounds, patches, or code forks.
Closes #73