Common Logging 3 Basic Support

[richardlawley]

I can't find much in the way of documentation about the changes to Common.Logging 3, presumably documentation of the new release is forthcoming at some point. From what I can see, the only significant change is the introduction of Global and Thread variables context, which to my understanding are incompatible with Serilog's way of doing things (pushing onto a stack).

Hence this change simply includes a copy of the changes made to AbstractLogger. The contexts will be ignored.

Fixes #7

[Jaben]

The issue is that Serilog supports "Global" and "Thread" scoped variables. This is a quick fix -- but it doesn't support that feature.

[richardlawley]

Serilog supports these in a different way which is incompatible (in my opinion) with the Common Logging implementation. For example, to add this information in Serilog:

using (LogContext.PushProperty("A", 1))
{
    log.Information("Carries property A = 1");
}

To do this in Common.Logging...

ILog log = LogManager.GetLogger(...);
log.GlobalVariables.Set("A", 1);
log.Information("Carries property A = 1");
log.GlobalVariables.Remove("A");

I don't think it's going to be easy to map these together?

[Jaben]

I agree with you -- it's rather unfortunate leaky abstraction by Common.Logging API. Not easy to map. But that's why I didn't want to commit right now... would rather circle back and do it right. That might even include a pull request to Serilog to get the current enrichers, etc.