Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internalize Pagination in API and hide pagination complexity #5

Open
brachetti opened this issue Jul 24, 2018 · 1 comment
Open

Internalize Pagination in API and hide pagination complexity #5

brachetti opened this issue Jul 24, 2018 · 1 comment

Comments

@brachetti
Copy link
Contributor

Let's internalise pagination, so instead of calling getProducts(int Page) one could call getProducts()

I would like to get your vote, on whether you prefer getProducts() 1️⃣ or getAllProducts() 2️⃣?

Expected Behaviour:
For every paginated call to get a list of entities, there is a method to get all of the underlying collection.

@ryankazokas
Copy link
Member

I think as to not introduce breaking changes, we should probably leave the paginated methods and just add another overloaded method with the same name just without the paginated paramaters. So i think [1] is fine.

rjdavis3 pushed a commit that referenced this issue Jul 27, 2018
Additional metadata for categories
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants