Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds weight to Shopify Variant #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hackjiyi
Copy link

weight

Copy link
Member

@ryankazokas ryankazokas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change looks good, but please read our contribution docs:
https://github.com/ChannelApe/shopify-sdk/blob/master/CONTRIBUTING.md

We need test coverage on new code that is added. Should be fairly simple to add for this change.

Also, the target branch should be the develop branch for new changes

@ryankazokas ryankazokas changed the title Update ShopifyVariant.java Adds weight to Shopify Variant Nov 18, 2020
@ryankazokas
Copy link
Member

ryankazokas commented Nov 18, 2020

@hackjiyi any chance you can update the above changes this week? We are working on the next release and can include this in there.

One other thing that might be useful for this PR, would be to add the Weight Units attribute. Looks like not all variants have the same interpretation of weight.
https://shopify.dev/docs/admin-api/rest/reference/products/product-variant

The unit of measurement that applies to the product variant's weight. If you don't specify a value for weight_unit, then the shop's default unit of measurement is applied. Valid values: g, kg, oz, and lb.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants