Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ci #80

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix ci #80

wants to merge 3 commits into from

Conversation

jacomago
Copy link
Contributor

@jacomago jacomago commented Apr 3, 2024

Update the client ci scripts to align with the recsync client submodule ci.
Make sure all the builds pass

@jacomago jacomago force-pushed the fix-ci branch 5 times, most recently from 7eeb4a8 to 90ce57e Compare April 3, 2024 13:04
@jeonghanlee
Copy link
Contributor

jeonghanlee commented Apr 3, 2024

@jacomago could you describe your merge request in more specific way in your comment? This is not the personal repository, and not the ESS specific repository. All other facilities should know what you are trying to do through this merge.

We don't have the template, but you can find another pull request as your example which Michael did in this repository.

@jacomago
Copy link
Contributor Author

jacomago commented Apr 4, 2024

@mdavidsaver Do you know why the macos12 ones are flaky? They seem to pass on reruns...

@mdavidsaver
Copy link
Collaborator

@mdavidsaver Do you know why the macos12 ones are flaky? They seem to pass on reruns...

I have probably encoded some Linux specific assumption into that test. I don't immediately see what though. 100 second really should be long enough for even the slowest GHA runner. It might be helpful for someone with a mac to try running this test locally.

@jacomago
Copy link
Contributor Author

@mdavidsaver Locally I'm getting a failure on 100 seconds but not on 110, and flaky inbetween. Shall I just bump the number? I don't know if this is to do with cpu seconds vs real time seconds...

@jacomago jacomago marked this pull request as ready for review April 17, 2024 09:07
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jacomago jacomago self-assigned this May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants