Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Фикс командного канала..." #4

Merged
merged 1 commit into from
Sep 19, 2020
Merged

Revert "Фикс командного канала..." #4

merged 1 commit into from
Sep 19, 2020

Conversation

xmaebx
Copy link
Contributor

@xmaebx xmaebx commented Sep 19, 2020

Reverts #3

Жру говно

@xmaebx
Revert "Update radio.dm"
858e118 
This reverts commit 5cfa44d.
@MC-003B
Copy link
Collaborator

MC-003B commented Sep 19, 2020

ну ты сука.

@MC-003B MC-003B merged commit 2fade3f into ChaoticOnyx:master Sep 19, 2020
kreeperHLC pushed a commit to kreeperHLC/BeeStation that referenced this pull request Dec 15, 2020
@park66665 @ike709
Random Processing Reviews: Part 1 (#2962)
3b2bc65 
* /obj/Destroy

* Actually does the long overdue TODO
* SA

* 2020-11-10 commit #1

Case #1:
/obj/item/tk_grab
- Unproblematic, fastprocess → icon_update; Do we really need this tho?
- Focus = null for safety
Case ChaoticOnyx#2:
/obj/screen/alert/bloodsense/process()
- (will be repathed to /atom/movable/screen)
- SSprocessing → long-ass process()
    → GUI stuff; do we really need animate()?
- left unchanged
Case ChaoticOnyx#3:
/obj/screen/alert/clockwork/clocksense/process()
- SSprocessing → short-ish process() → Basic desc
- (creation and removal is sane)
- Wrap-up: /obj/screen/alert/Destroy()
  * Removed duplicated `master = null`
  * Proper return ..() position on
    * /obj/screen/alert/clockwork/clocksense/Destroy() &
    * /obj/screen/alert/Destroy()
Case ChaoticOnyx#4:
/datum/proc/process()
- automatic killer for aimless START_PROCESS
- obviously left unchanged
Case ChaoticOnyx#5:
/datum/action/proc/Process()
- A proc to be overriden? Why?
- Removed; we already have /datum/proc/process()
Case ChaoticOnyx#6:
/datum/action/cooldown/process()
- return PROCESS_KILL
Case ChaoticOnyx#7:
/datum/action/item_action/chameleon/change/process()
- return PROCESS_KILL
Case ChaoticOnyx#8:
/datum/forced_movement
- Looks alright
Case ChaoticOnyx#9:
/datum/point/vector/processed
- Is this shit even used???
- Left as is since it might be used in the future
(inb4 staying unused til 2025)

* 2020-11-12

Case 10:
/datum/radiation_wave/process()
- Literally the centerpiece of radiation
- Each process step progresses radiation wave by one tile
  * … and the place it used be is then filled by subsequent wave
- Kat requested fix of tgstation/tgstation#42572
  * I will start working on it soon(tm)
- The code seems fine otherwise

Case 11:
/obj/effect/hallucination/simple/securitron
- Responsible for making securitron hallucination lifelike
- Too simple to review, IMO
- victim = null for safety

Case 12:
/datum/component/chasm/process()
- Responsible for “dropping” things every now and then, very greedily
- I am not going to refactor this obviously
- START_PROCESSING actually has sanity check,
   no problem with double START_PROCESSING
- return PROCESS_KILL

Case 13:
/datum/component/lockon_aiming/process()
- Responsible for keeping locks sane
- Looks sane, left as is

Case 14:
/datum/component/manual_blinking/process()
- Adminbus shit for now
- Responsible for warnings and damage
- Looks sane, left as is
- *Even checks for life and eye-ness of parent*

Case 15:
/datum/component/manual_breathing/process()
- Mostly ditto

Case 16:
/datum/component/mood/process()
- Responsible for sanity, nutrition, and hygiene’s miasma production
- NO MORE INFINITE SANITY AHHHHH

* 2020-11-18 Commit 1

Case 17:
/datum/component/nanites/process()
- Responsible for nanites.
- Is its own family; the /datum/nanite_program/proc/on_process()
  * Handles so much but only one on_process()
  * Things are generally good except some fuzzy cases where
    * Host is ded
    * Host is invalid as hell
    * etc etc
  * But I don’t care; LGTM

Case 18:
/datum/component/radioactive/process()
- Responsible for making irradiating objects irradiate
- THE GODDAMN prob(50)
  * wontfix
- We don’t need return PROCESS_KILL here since it qdels anyway
  * … and Destroy() shouldn’t meaninglessly STOP_PROCESSING

Case 19:
/datum/component/rot/process()
- Responsible for miasma production for whatever that rots
- For the love of god, write actual real Destroy()

Case 20:
/datum/component/rot/corpse/process()
- Special handling for corpse rots
- Seems good

Case 21:
/datum/component/spawner/process()
- Spawns mobs, yay
- stop_spawning(force) is in lieu of Destroy, mostly
  * Are we sure that the spawner never dies otherwise? I don’t know.

Case 22:
/datum/component/wet_floor/process()
- time_left_list doesn’t look sane; will investigate further
  * Nah, everything works as intended
  * I am not sure if we need bitflag and assoc list tortures

Case 23:
/datum/component/plumbing/process()
- return PROCESS_KILL
  * IMO it shouldn’t be reachable in the first place
  * Hey does this work well with GC? (probably yes)
- STOP_PROCESSING in disable() is alright

* Update code/game/objects/objs.dm

For clarity...! Parenthesis FTW

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* 2020-11-21 Commit 1

Case 24:
/datum/component/plumbing/acclimator/process()
- Makes acclimator do nothing when empyting
- LGTM

Case 25:
/obj/structure/alien/flesh/node/process()
- Hey, it is that weird pink skin stuff
- Controls flesh expansion through expand()
- LGTM

Case 26:
/datum/element/earhealing/process()
- Only used by earmuffs
- I think we have enough tickchecks
- I should stop before looking at every CHECK_TICK usage and
  * just walk away AHHHHHHHHHHHHHH

Case 27:
/datum/status_effect/process()
- Responsible for qdeling status effects as needed
- LGTM

Case 28:
/datum/quirk/process()
- It too is its own family: on_process()
- /datum/quirk/jolly/on_process()
  * Sends positive mood event really really rarely:
  * once per avg. 2000 seconds, yet the mood effect only lasts 2 minutes
  * Seems a bit too rare for me, but now isn’t a time for that
- /datum/quirk/spiritual/on_process()
  * Actually really loops through every *living thing* nearby
  * ‘Holy people’ here is chaplain, inquisitor ERT chaplain & commander
  * … and people who used syndicate bible on themselves
  * From now on only real human can appear holy to spiritual people
  * Like, don’t be comforted by holy monkeys or roaches or something
- /datum/quirk/neet/on_process()
  * Checks hygiene for NEET stuff
  * I think I should start considering hygiene signals
- /datum/quirk/badback/on_process()
  * I want to replace this with signal but quirks aren’t components
  * So it gets to live
- /datum/quirk/blooddeficiency/on_process()
  * Just removes blood from the holder, oof
  * LGTM
- /datum/quirk/brainproblems/on_process()
  * Just damages brain over time
  * LGTM
- /datum/quirk/family_heirloom/on_process()
  * Constantly checks whether the holder has the heirloom
  * LGTM
- /datum/quirk/nyctophobia/on_process()
  * Oh boy can’t we just change the type of the quirk_holder?
  * Handles nyctophobia mood and makes nyctophboes walk in the dark (?!)
  * LGTM
- /datum/quirk/insanity/on_process()
  * Makes holder go mad when they have no mindbreaker toxin
  * Feels like madness() call is unnecessary
- /datum/quirk/social_anxiety/on_process()
  * Ah yes, the *thing*
  * Code is a l r i g h t , t r u s t m e
- /datum/quirk/junkie/on_process()
  * Piggybacks on addiction mechanics
  * Mostly just keeps persistent addiction going
  * LGTM
- /datum/quirk/junkie/smoker/on_process()
  * Picky smokers...
  * LGTM
- /datum/quirk/neat/on_process()
  * NEET, but… much less asocial
  * LGTM

* 2020-11-22 Commit 1

Case 29:
/area/process()
- OwO wats dis, Cyberboss?
- tgstation/tgstation#23566
- Saner placement of START_PROCESSING and STOP_PROCESSING

Case 30:
/datum/game_mode/process()
- Base proc for game_mode process()s
- Not that necessary but I am leaving this for doc
  * I should consider giving game mode process()s a new name
- We shouldn’t return; return value isn’t even used lmao

Case 31:
/obj/item/clothing/shoes/clown_shoes/banana_shoes/combat/process()
- Responsible recharging the combat bananium shoes
- I think I can refactor this away but I am too lazy
  * TODO
- Don’t forget the Destroy()

Case 32:
/datum/game_mode/dynamic/process()
- I am not touching this since
  * people are tinkering with dynamic gamemode
  * and I don't like dynamemes
- LGTM(?) anyway

Case 33:
/obj/machinery/dominator/process()
- WHY ..()
- Breaking kills process anyway
- return PROCESS_KILL is actually more important for machines

Case 34:
/datum/game_mode/meteor/process()
- I'll tell you about the cursed thing about compile time optimizations
  * (var * 10 * 10) is *slower* than (var * (10 * 10))
- I have no idea why it looks like this, but I am leaving this
  * for posterity? Idk

Case 35:
/datum/game_mode/revolution/process()
- Culls unnecessary returns; let’s not confuse coders
- Removes != 0
- return values are a batshit. I need to take care of this…
  * in another PR, probably, soon-ish

Case 36:
/datum/game_mode/revolution/speedy/process()
- We don’t return

Case 37:
/obj/machinery/process()
- Automatic killer a la /datum/process
- The truth is, we don’t need this
  * Postmortem: This code is a ridiculous heap of legacy
  * This automatic killer is actually older(8 y/o)
    * ...than the killer at datum(5 y/o)
  * This thing should’ve been phased out 5 years ago
- Proper STOP_PROCESSING
- Guess it would be good to unify normal processing and SSmachines more

Postscript: I will Signal-lize badback quirk next commit

* 2020-11-24 Commit 1

Important:
- Bad back on_process won’t be signalized away since
  * there aren’t appropriate signals
  * and I don’t want to write another signal (COMSIG_MOB_EQUIP?)
    * …unless I somehow find a few other probable use cases
- porting tgstation/tgstation#51392 should be a different PR
- game_mode process() should be left alone

Case 38:
/obj/machinery/airlock_sensor/process()
- responsible for constant input of air info… like a good sensor
- DOES THIS GET TURNED OFF IN THE FIRST PLACE
- update_icon() on demand

Case 39:
/obj/machinery/advanced_airlock_controller/process()
- ..() in process() IS NOT A GOOD IDEA MOST OF THE TIME
  * In this case it kills the process, rendering this process moot
- BeeStation/BeeStation-Hornet#2059 ← how did this happen to Bee
- yogstation13/Yogstation#7906 ← the culprit
- Oh god oh fuck I am in pain why are doing this to me monster860
- Every time I review through a handful of cases to prepare a commit
  * I am subjected to a constant pain
- Trilemma ensues:
  * Keep doing this really slowly
  * Stop this shit right now
  * Be masochist
- This fix is going to create a tiny(?) bit of lag

Case 40:
/obj/machinery/computer/bank_machine/process()
- /obj/machinery/computer/process() is a whole new kind of weird shit
  * It is to be used to check whether it should run process() or not but
  * This proc doesn’t follow that lmao
- More and more I investigate the machine code
  * more and more I lose hope in humanity
- This process is responsible for siphoning process
- Early return for having no power; who didn’t think of this?

Okay, let’s wrap up this batshit:
- Currently, BROKEN flag is misused
  * The checks are all over the place
  * BROKENness prevents interaction whilst it still eats energy
  * Probably other shits will be dug up once I take a serious look
- Power consumption depends on process()
  * I am not joking they really do
  * So idle machines still get process()ed
  * And power consumption isn’t very well controlled in general
- The technical debt here is damn too high just kill me
- So things won’t be fixed in this PR
  * This PR then will focus on mis-codings on machinery process()s
  * FOR THE LOVE OF GIT STOP CALLING ..() EVERYWHERE AHHHHH

* 2020-11-25 Commit 1

Case 41:
/obj/machinery/bluespace_beacon/process()
- Responsible for… beacon?
- Plz keep icon updates sane
- The only thing that changes invisibility is hide()
  * and hide() obviously is sane
  * yet it always calls it
  * faded version isn't vital in the first place so I am doing this
  * See /obj/machinery/navbeacon code for more doc

Case 42:
/obj/machinery/cell_charger/process()
- Responsible for actual charging
- Problems in power usage and BROKEN check are present but,
  * as I said, I am not touching that now
- LGTM otherwise; update_icon here is necessary

Case 43:
/obj/machinery/clonepod/process()
- Responsible for cloning; oh god oh fuck
- Surprisingly LGTM

Case 44:
/obj/machinery/cryopod/process()
- Responsible for freezing people away (read: qdel)
- Proper Destroy()
- Otherwise LGTM

Case 45:
/obj/machinery/jukebox/process()
- Responsible playing and stopping music as needed
- Order of addition and removal can be reversed
  * so I am going to reduce the amount of list iteration
- return PROCESS_KILL
- SSobj bad, use SSmachines

Case 46:
/obj/machinery/jukebox/disco/process()
- Does the same as above except it also bops a lot
- LGTM

Case 47:
/obj/machinery/defibrillator_mount/process()
- Cell charger is 100%
  * I am not touching the balance here
- update_icon is sane and needed

Case 48:
/obj/machinery/dish_drive/process()
- Responsible for constant suction and occasional beaming
- Suction code doesn’t check for other nearby drives but I don’t care
- LGTM

Case 49:
/obj/machinery/droneDispenser/process()
- power_change code is duplicated
- Responsible for drone production; cycles through three modes
- Except the useless parent call, the code LGTM

Case 50:
/obj/machinery/fat_sucker/process()
- Responsible fat sucking and random trivia
- Oh boy powered() situation is a bit deranged
  * /obj/machinery/proc/power_change() handles NOPOWER flag nicely
    * ... and powered() isn’t to be used everywhere
  * But so many machinery codes to
  * Arghhh I will deal with this in a different PR
  * For now it’ll only be dealt with on process()
  * So this powered() will be is_operational()

* Simplifies meteor gamemode number

* Replaced lagacy with a shiny new comment

Co-authored-by: ike709 <ike709@users.noreply.github.com>
MC-003B pushed a commit that referenced this pull request Dec 16, 2020
@kreeperHLC @Victor239
@ss13-beebot @PowerfulBacon @ike709 @Archanial @jupyterkat @MNarath1 @Agameofscones @Chessus @park66665 @EdgeLordExe @francinum @TheFakeElon @eeSPee @SmArtKar @qwertyquerty @Cenrus @LastCrusader105 @Sinestia @Jakecantcode @super12pl @bloons3 @TiviPlus @Rohesie @ninjanomnom @That0nePerson @Crossedfall @Naevii @Kmc2000 @Vasily2013 @MCterra10 @Blueturbo47 @Sinmero @Kerbin-Fiber @Isy232 @haukeschuemann
Merge (#45)
b1b58fb 
* THICKMATERIAL fixes (#2811)

* THICKMATERIAL fix

* THICKMATERIAL fix 2

* Removed commented code

* Typo


Typo2

* Automatic changelog generation for PR #2811 [ci skip]

* Automatic changelog compile [ci skip]

* Nar'sie and Rat'var don't like each other (#2938)

* Based

* Shakes the screens of everyone in the game

* Target becomminga clockie counts as being sacced

* Update code/modules/antagonists/clock_cult/clockwork_massive.dm

* Update code/modules/power/singularity/narsie.dm

Co-authored-by: PowerfulBacon <>
Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #2938 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes removing syringes while dead (#2975)

* fix

* good_idea

* Update code/datums/status_effects/debuffs.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #2975 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Update radiation.dm (#3002)

* Automatic changelog generation for PR #3002 [ci skip]

* Automatic changelog compile [ci skip]

* fixes the invisible crate spawning (#3009)

* Automatic changelog generation for PR #3009 [ci skip]

* Automatic changelog compile [ci skip]

* Adds 16 random maintenance rooms (#2842)

* Auto stash before rebase of "origin/master"

* adds temp holding map

* adds 16 new maintenance rooms

* removes template map, whoops

* removes actual tesla ball gen

* Removes brown tiles from some random maints map idk

Co-authored-by: Triiodinegb <garryrobinson@freemail.com>

* Automatic changelog generation for PR #2842 [ci skip]

* Automatic changelog compile [ci skip]

* Update medicine.dm (#3012)

* Automatic changelog generation for PR #3012 [ci skip]

* Automatic changelog compile [ci skip]

* Proper QDEL_NULL for looping_sound (#3015)

* Automatic changelog generation for PR #3015 [ci skip]

* Automatic changelog compile [ci skip]

* Removes linkify from chat unless its manually turned on in to_chat (#3018)

* Update all_nodes.dm

* Removes linkify

* Revert "Update all_nodes.dm"

This reverts commit 1af4cfdeb2e5dad994518e31ae703ebb50552fc8.

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3018 [ci skip]

* Automatic changelog compile [ci skip]

* [Bounty] Crystalized Crossbreeds (Adamantine) (#2946)

* oh damn

* E

* E

* E

* E

E

* e

* fixes bluepsace

* rainbows now also relay their thingy

* E

* E

* E

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/crystalized.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* E

* E

* E

* E

* Apply suggestions from code review

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #2946 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes admanantine crossbreeds (#3022)

* oh damn

* E

* E

* E

* E

E

* e

* fixes bluepsace

* rainbows now also relay their thingy

* E

* E

* E

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/crystalized.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* E

* E

* E

* E

* Apply suggestions from code review

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/modules/research/xenobiology/crossbreeding/_structures.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* E

* works now

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #3022 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Stack max amount check (#3028)

* Automatic changelog generation for PR #3028 [ci skip]

* Automatic changelog compile [ci skip]

* fixes some bugs with adamantines (#3029)

* fixes

* E

* E

* Automatic changelog generation for PR #3029 [ci skip]

* Automatic changelog compile [ci skip]

* [GOON] Mob properties (#3001)

* [GOON] Mob properties

* Revert some of the macro abuse to the original PR's state

* Add the list to mobs

* Automatic changelog compile [ci skip]

* [s] XSS via invalid keypress protection (#3035)

* [PORT] restart votes check for deadmins (#3036)

* Update vote.dm

* Update vote.dm

Co-Authored-By: LatteKat <56778689+jupyterkat@users.noreply.github.com>

Co-authored-by: LatteKat <56778689+jupyterkat@users.noreply.github.com>

* oh god (#3034)

* Automatic changelog generation for PR #3036 [ci skip]

* Automatic changelog compile [ci skip]

* Service Speciality Modules, but it's working and tested (#2862)

* Revert "Automatic changelog compile [ci skip]"

This reverts commit 7402445.

* pull

* fixes

* they say I overcompensate

* small fix

* This one was just bothering me.

* fixed conflicts

* fix conflicts 2

* Medsec Hybrid Hud

Adds recipe to make Med/Sec Hybrid HUD. Also allows you to disassemble said medsec hud with a skrewdriver into sec+med hud.

* Revert "Medsec Hybrid Hud"

This reverts commit 31fe61b32d568ee631c6563941f5d39d4b879d7a.

* Revert "This one was just bothering me."

This reverts commit 4dcdd6d1874a9510a655dece30f5cbdabbb5614f.

* again

* again

* again

* Delete AutoChangeLog-pr-2858.yml

* Update changelog.html

* whoops

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/robot/robot_upgrades.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/robot/robot_upgrades.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* small fixes

* :)

* :)

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* html fix in toys.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Sound fading subsystem, ambience fading. (#2680)

* very cool

* push

* Addresses qwerty's comments

* Update sound.dm

* Update sound.dm

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #2680 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes fucking floors (#2834)

* MarkSuckerberg and qwertyquerty did an oopsie

* h

* hh

Co-authored-by: Isaac <qwertytrogi@gmail.com>

* Automatic changelog generation for PR #2834 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes Obsessed photo objective (#2875)

* Automatic changelog compile [ci skip]

* picture fixer (#51650)

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>

* fixes chapels mail and fixes mining disposals (#2914)

* fixes chapels mail and fixes minings disposals

* fixes deltas viro mail

* Automatic changelog generation for PR #2914 [ci skip]

* Make dangerous shuttles unbuyable + emags & hacking (#2920)

* Merge branch 'emag_shuttles' of https://github.com/Archanial/BeeStation-Hornet into emag-shuttles

* Shuttle buy msg prints auth id instead of real name

* More shuttle stuff

Adds arena to illegal, separates the naughty shuttles, changes text to be more fitting and generalized, changes the title to add an indication.

* Circuit board can now be hacked.

* comms circuit now has default description

* Update code/game/objects/items/circuitboards/computer_circuitboards.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/circuitboards/computer_circuitboards.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/objects/items/circuitboards/computer_circuitboards.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Update code/game/machinery/computer/communications.dm

* Update code/game/machinery/computer/communications.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #2920 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* removes crashchem (#3037)

* Automatic changelog generation for PR #3037 [ci skip]

* Automatic changelog compile [ci skip]

* Adds a craftable charcoal pen (#3039)

* Automatic changelog generation for PR #3039 [ci skip]

* [PORT] Blob Minor Buffs (#2843)

* InitialPORT

* Remove Zombifying_pods.dm and adjust beestation.dme

* Removes Distributed Neurons and keep old Zombifying pods

* Remove a accidental line that was added

* Fixes and actually removes ability to take control of Blob spores

* Implementing all suggested changes from ike709

* Automatic changelog generation for PR #2843 [ci skip]

* Automatic changelog compile [ci skip]

* Removes monkey from rotation(again) (#3005)

* Automatic changelog generation for PR #3005 [ci skip]

* Automatic changelog compile [ci skip]

* it (#3044)

* Adds coordinate logging to admin spawn commands (#3043)

makes it easier to determine where items were spawned in at

* Automatic changelog generation for PR #3043 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* adds msg (#3056)

Adds a new admin message in case a borg or ai decides to delete the crew mainfest of someone.

* Automatic changelog generation for PR #3056 [ci skip]

* Microoptimizes isnum_safe() (#3055)

* Automatic changelog compile [ci skip]

* Revert "Microoptimizes isnum_safe() (#3055)" (#3058)

This reverts commit d2b0c1e.

* Miscellaneous Mob Improvements (#3053)

* Automatic changelog generation for PR #3053 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Crate animation fixes and refractoring (#3040)

* fixes and sphere coordinates

fixing a small sprite oversight of mine and switches from this patchwork coordinates to an actual spherical coordinate system

* removal of unneeded code and small tweak

* forgot to move that var override

* small tweak

* oops

moves the accidentally misplaced z axis from translation to scew

* lets keep this small

* ok lets leave this out

* ooops no idea how i missed that one

* Replaces /obj/screen with /atom/movable/screen (#2894)

* Automatic changelog generation for PR #3040 [ci skip]

* Adds a traitor spawn minor antagonist role, allows traitors to spawn on some gamemodes. (#2833)

* plop

* Update incursion.dm

* Update code/game/gamemodes/clock_cult/clockcult.dm

* Update code/game/gamemodes/cult/cult.dm

Co-authored-by: PowerfulBacon <>

* [PORT] Smooth Doors from Yogstation (#2987)

* Port+somefixes

* Speeds up animation and fixes some stuff

speeded up to 3.5 and adds a cut_overlays() to make sure access indicator overlayer don't stack also fixes some stuff with shuttle airlocks

* fixes notes pin overlayer

* change the sleep() from 4 to 2.5 to match the animation more

* Implement suggested changes and fixes

Removing the unneeded support for 512 implementing some suggested changes by ike and fixing a missing airlock icon bug for the external_arrival airlocks

* Removes an unneeded var and uses an already existing instead

Making an entire new var seems silly if i can just override an already existing var that actually is for this very reason instead

* Converts decals from components to elements (but it works this time) (#3046)

* Refactors decals to an element (#53922)

* Fixes

* Fixes decals (#53954)

* fixes

* moved

* Fixes decals causing 20k runtimes and blood not cleaning (#53967)

decals will unregister signals and wont try to clean twice

* Fixes

* Removes a duplicate decal from Box

* Ports core parts of tgstation/tgstation#47199

Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>

* Refactors pre-existing update_overlay()s

* defib icon update code has been facelifted
* customizable food code has been just... "put aside"

* I am going to suppress this for now,
because blood decal is applied more than once

* This comment is a bit long but whatever

Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Unknown <epicmail709@yahoo.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #2894 [ci skip]

* Automatic changelog generation for PR #2833 [ci skip]

* Automatic changelog generation for PR #2987 [ci skip]

* Automatic changelog generation for PR #3046 [ci skip]

* Automatic changelog compile [ci skip]

* fix white ling icons (#3063)

* Automatic changelog generation for PR #3063 [ci skip]

* Fixes a records runtime (#3061)

* fix (#2999)

* Automatic changelog compile [ci skip]

* Gives Blood Brothers a good way to communicate (#3023)

* adds comm implant, gives comm implant to bb

* updates BB instruction text

* fixes typepath

* filter check, formatting, simplifies logic

* Automatic changelog generation for PR #3023 [ci skip]

* Automatic changelog compile [ci skip]

* fix (#3065)

* Automatic changelog generation for PR #3065 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic TGS DMAPI Update (#3074)

* make list reject illegals (#3076)

* Automatic changelog generation for PR #3076 [ci skip]

* Automatic changelog compile [ci skip]

* Sanitize tips (#3077)

* Update names.dm (#3081)

* Automatic changelog generation for PR #3081 [ci skip]

* Automatic changelog compile [ci skip]

* Update layermanifold.dm (#3082)

I have no idea why layer manifolds have worked

* Automatic changelog generation for PR #3082 [ci skip]

* Automatic changelog compile [ci skip]

* you can now VV atoms with invalid icons (#3083)

* Automatic changelog generation for PR #3083 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Mechs will now knock people down on melee, rather than make them unconcious. (#2785)

* Update

* Adds knockdown

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #2785 [ci skip]

* Automatic changelog compile [ci skip]

* damp rag can clean microwave (#3068)

* Automatic changelog generation for PR #3068 [ci skip]

* fixes radiation filter breaking airlock filter (#3066)

* fixes radiation breaking airlock filter

* removes some now unneeded code

* small change regarding an honestly useless var define

* removing unneeded codeline

* Automatic changelog generation for PR #3066 [ci skip]

* Limbsnakes properly disember limbs (#2990)

* Update regenerate.dm

* costfix

* fix

* Automatic changelog generation for PR #2990 [ci skip]

* Automatic changelog compile [ci skip]

* Atmos components now nullifies node properly (#3089)

* Automatic changelog generation for PR #3089 [ci skip]

* Automatic changelog compile [ci skip]

* Update components_base.dm (#3090)

Prevents potential (read: probable) runtimes at qdel

* Random Processing Reviews: Part 1 (#2962)

* /obj/Destroy

* Actually does the long overdue TODO
* SA

* 2020-11-10 commit #1

Case #1:
/obj/item/tk_grab
- Unproblematic, fastprocess → icon_update; Do we really need this tho?
- Focus = null for safety
Case #2:
/obj/screen/alert/bloodsense/process()
- (will be repathed to /atom/movable/screen)
- SSprocessing → long-ass process()
    → GUI stuff; do we really need animate()?
- left unchanged
Case #3:
/obj/screen/alert/clockwork/clocksense/process()
- SSprocessing → short-ish process() → Basic desc
- (creation and removal is sane)
- Wrap-up: /obj/screen/alert/Destroy()
  * Removed duplicated `master = null`
  * Proper return ..() position on
    * /obj/screen/alert/clockwork/clocksense/Destroy() &
    * /obj/screen/alert/Destroy()
Case #4:
/datum/proc/process()
- automatic killer for aimless START_PROCESS
- obviously left unchanged
Case #5:
/datum/action/proc/Process()
- A proc to be overriden? Why?
- Removed; we already have /datum/proc/process()
Case #6:
/datum/action/cooldown/process()
- return PROCESS_KILL
Case #7:
/datum/action/item_action/chameleon/change/process()
- return PROCESS_KILL
Case #8:
/datum/forced_movement
- Looks alright
Case #9:
/datum/point/vector/processed
- Is this shit even used???
- Left as is since it might be used in the future
(inb4 staying unused til 2025)

* 2020-11-12

Case 10:
/datum/radiation_wave/process()
- Literally the centerpiece of radiation
- Each process step progresses radiation wave by one tile
  * … and the place it used be is then filled by subsequent wave
- Kat requested fix of tgstation/tgstation#42572
  * I will start working on it soon(tm)
- The code seems fine otherwise

Case 11:
/obj/effect/hallucination/simple/securitron
- Responsible for making securitron hallucination lifelike
- Too simple to review, IMO
- victim = null for safety

Case 12:
/datum/component/chasm/process()
- Responsible for “dropping” things every now and then, very greedily
- I am not going to refactor this obviously
- START_PROCESSING actually has sanity check,
   no problem with double START_PROCESSING
- return PROCESS_KILL

Case 13:
/datum/component/lockon_aiming/process()
- Responsible for keeping locks sane
- Looks sane, left as is

Case 14:
/datum/component/manual_blinking/process()
- Adminbus shit for now
- Responsible for warnings and damage
- Looks sane, left as is
- *Even checks for life and eye-ness of parent*

Case 15:
/datum/component/manual_breathing/process()
- Mostly ditto

Case 16:
/datum/component/mood/process()
- Responsible for sanity, nutrition, and hygiene’s miasma production
- NO MORE INFINITE SANITY AHHHHH

* 2020-11-18 Commit 1

Case 17:
/datum/component/nanites/process()
- Responsible for nanites.
- Is its own family; the /datum/nanite_program/proc/on_process()
  * Handles so much but only one on_process()
  * Things are generally good except some fuzzy cases where
    * Host is ded
    * Host is invalid as hell
    * etc etc
  * But I don’t care; LGTM

Case 18:
/datum/component/radioactive/process()
- Responsible for making irradiating objects irradiate
- THE GODDAMN prob(50)
  * wontfix
- We don’t need return PROCESS_KILL here since it qdels anyway
  * … and Destroy() shouldn’t meaninglessly STOP_PROCESSING

Case 19:
/datum/component/rot/process()
- Responsible for miasma production for whatever that rots
- For the love of god, write actual real Destroy()

Case 20:
/datum/component/rot/corpse/process()
- Special handling for corpse rots
- Seems good

Case 21:
/datum/component/spawner/process()
- Spawns mobs, yay
- stop_spawning(force) is in lieu of Destroy, mostly
  * Are we sure that the spawner never dies otherwise? I don’t know.

Case 22:
/datum/component/wet_floor/process()
- time_left_list doesn’t look sane; will investigate further
  * Nah, everything works as intended
  * I am not sure if we need bitflag and assoc list tortures

Case 23:
/datum/component/plumbing/process()
- return PROCESS_KILL
  * IMO it shouldn’t be reachable in the first place
  * Hey does this work well with GC? (probably yes)
- STOP_PROCESSING in disable() is alright

* Update code/game/objects/objs.dm

For clarity...! Parenthesis FTW

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* 2020-11-21 Commit 1

Case 24:
/datum/component/plumbing/acclimator/process()
- Makes acclimator do nothing when empyting
- LGTM

Case 25:
/obj/structure/alien/flesh/node/process()
- Hey, it is that weird pink skin stuff
- Controls flesh expansion through expand()
- LGTM

Case 26:
/datum/element/earhealing/process()
- Only used by earmuffs
- I think we have enough tickchecks
- I should stop before looking at every CHECK_TICK usage and
  * just walk away AHHHHHHHHHHHHHH

Case 27:
/datum/status_effect/process()
- Responsible for qdeling status effects as needed
- LGTM

Case 28:
/datum/quirk/process()
- It too is its own family: on_process()
- /datum/quirk/jolly/on_process()
  * Sends positive mood event really really rarely:
  * once per avg. 2000 seconds, yet the mood effect only lasts 2 minutes
  * Seems a bit too rare for me, but now isn’t a time for that
- /datum/quirk/spiritual/on_process()
  * Actually really loops through every *living thing* nearby
  * ‘Holy people’ here is chaplain, inquisitor ERT chaplain & commander
  * … and people who used syndicate bible on themselves
  * From now on only real human can appear holy to spiritual people
  * Like, don’t be comforted by holy monkeys or roaches or something
- /datum/quirk/neet/on_process()
  * Checks hygiene for NEET stuff
  * I think I should start considering hygiene signals
- /datum/quirk/badback/on_process()
  * I want to replace this with signal but quirks aren’t components
  * So it gets to live
- /datum/quirk/blooddeficiency/on_process()
  * Just removes blood from the holder, oof
  * LGTM
- /datum/quirk/brainproblems/on_process()
  * Just damages brain over time
  * LGTM
- /datum/quirk/family_heirloom/on_process()
  * Constantly checks whether the holder has the heirloom
  * LGTM
- /datum/quirk/nyctophobia/on_process()
  * Oh boy can’t we just change the type of the quirk_holder?
  * Handles nyctophobia mood and makes nyctophboes walk in the dark (?!)
  * LGTM
- /datum/quirk/insanity/on_process()
  * Makes holder go mad when they have no mindbreaker toxin
  * Feels like madness() call is unnecessary
- /datum/quirk/social_anxiety/on_process()
  * Ah yes, the *thing*
  * Code is a l r i g h t , t r u s t m e
- /datum/quirk/junkie/on_process()
  * Piggybacks on addiction mechanics
  * Mostly just keeps persistent addiction going
  * LGTM
- /datum/quirk/junkie/smoker/on_process()
  * Picky smokers...
  * LGTM
- /datum/quirk/neat/on_process()
  * NEET, but… much less asocial
  * LGTM

* 2020-11-22 Commit 1

Case 29:
/area/process()
- OwO wats dis, Cyberboss?
- tgstation/tgstation#23566
- Saner placement of START_PROCESSING and STOP_PROCESSING

Case 30:
/datum/game_mode/process()
- Base proc for game_mode process()s
- Not that necessary but I am leaving this for doc
  * I should consider giving game mode process()s a new name
- We shouldn’t return; return value isn’t even used lmao

Case 31:
/obj/item/clothing/shoes/clown_shoes/banana_shoes/combat/process()
- Responsible recharging the combat bananium shoes
- I think I can refactor this away but I am too lazy
  * TODO
- Don’t forget the Destroy()

Case 32:
/datum/game_mode/dynamic/process()
- I am not touching this since
  * people are tinkering with dynamic gamemode
  * and I don't like dynamemes
- LGTM(?) anyway

Case 33:
/obj/machinery/dominator/process()
- WHY ..()
- Breaking kills process anyway
- return PROCESS_KILL is actually more important for machines

Case 34:
/datum/game_mode/meteor/process()
- I'll tell you about the cursed thing about compile time optimizations
  * (var * 10 * 10) is *slower* than (var * (10 * 10))
- I have no idea why it looks like this, but I am leaving this
  * for posterity? Idk

Case 35:
/datum/game_mode/revolution/process()
- Culls unnecessary returns; let’s not confuse coders
- Removes != 0
- return values are a batshit. I need to take care of this…
  * in another PR, probably, soon-ish

Case 36:
/datum/game_mode/revolution/speedy/process()
- We don’t return

Case 37:
/obj/machinery/process()
- Automatic killer a la /datum/process
- The truth is, we don’t need this
  * Postmortem: This code is a ridiculous heap of legacy
  * This automatic killer is actually older(8 y/o)
    * ...than the killer at datum(5 y/o)
  * This thing should’ve been phased out 5 years ago
- Proper STOP_PROCESSING
- Guess it would be good to unify normal processing and SSmachines more

Postscript: I will Signal-lize badback quirk next commit

* 2020-11-24 Commit 1

Important:
- Bad back on_process won’t be signalized away since
  * there aren’t appropriate signals
  * and I don’t want to write another signal (COMSIG_MOB_EQUIP?)
    * …unless I somehow find a few other probable use cases
- porting tgstation/tgstation#51392 should be a different PR
- game_mode process() should be left alone

Case 38:
/obj/machinery/airlock_sensor/process()
- responsible for constant input of air info… like a good sensor
- DOES THIS GET TURNED OFF IN THE FIRST PLACE
- update_icon() on demand

Case 39:
/obj/machinery/advanced_airlock_controller/process()
- ..() in process() IS NOT A GOOD IDEA MOST OF THE TIME
  * In this case it kills the process, rendering this process moot
- BeeStation/BeeStation-Hornet#2059 ← how did this happen to Bee
- yogstation13/Yogstation#7906 ← the culprit
- Oh god oh fuck I am in pain why are doing this to me monster860
- Every time I review through a handful of cases to prepare a commit
  * I am subjected to a constant pain
- Trilemma ensues:
  * Keep doing this really slowly
  * Stop this shit right now
  * Be masochist
- This fix is going to create a tiny(?) bit of lag

Case 40:
/obj/machinery/computer/bank_machine/process()
- /obj/machinery/computer/process() is a whole new kind of weird shit
  * It is to be used to check whether it should run process() or not but
  * This proc doesn’t follow that lmao
- More and more I investigate the machine code
  * more and more I lose hope in humanity
- This process is responsible for siphoning process
- Early return for having no power; who didn’t think of this?

Okay, let’s wrap up this batshit:
- Currently, BROKEN flag is misused
  * The checks are all over the place
  * BROKENness prevents interaction whilst it still eats energy
  * Probably other shits will be dug up once I take a serious look
- Power consumption depends on process()
  * I am not joking they really do
  * So idle machines still get process()ed
  * And power consumption isn’t very well controlled in general
- The technical debt here is damn too high just kill me
- So things won’t be fixed in this PR
  * This PR then will focus on mis-codings on machinery process()s
  * FOR THE LOVE OF GIT STOP CALLING ..() EVERYWHERE AHHHHH

* 2020-11-25 Commit 1

Case 41:
/obj/machinery/bluespace_beacon/process()
- Responsible for… beacon?
- Plz keep icon updates sane
- The only thing that changes invisibility is hide()
  * and hide() obviously is sane
  * yet it always calls it
  * faded version isn't vital in the first place so I am doing this
  * See /obj/machinery/navbeacon code for more doc

Case 42:
/obj/machinery/cell_charger/process()
- Responsible for actual charging
- Problems in power usage and BROKEN check are present but,
  * as I said, I am not touching that now
- LGTM otherwise; update_icon here is necessary

Case 43:
/obj/machinery/clonepod/process()
- Responsible for cloning; oh god oh fuck
- Surprisingly LGTM

Case 44:
/obj/machinery/cryopod/process()
- Responsible for freezing people away (read: qdel)
- Proper Destroy()
- Otherwise LGTM

Case 45:
/obj/machinery/jukebox/process()
- Responsible playing and stopping music as needed
- Order of addition and removal can be reversed
  * so I am going to reduce the amount of list iteration
- return PROCESS_KILL
- SSobj bad, use SSmachines

Case 46:
/obj/machinery/jukebox/disco/process()
- Does the same as above except it also bops a lot
- LGTM

Case 47:
/obj/machinery/defibrillator_mount/process()
- Cell charger is 100%
  * I am not touching the balance here
- update_icon is sane and needed

Case 48:
/obj/machinery/dish_drive/process()
- Responsible for constant suction and occasional beaming
- Suction code doesn’t check for other nearby drives but I don’t care
- LGTM

Case 49:
/obj/machinery/droneDispenser/process()
- power_change code is duplicated
- Responsible for drone production; cycles through three modes
- Except the useless parent call, the code LGTM

Case 50:
/obj/machinery/fat_sucker/process()
- Responsible fat sucking and random trivia
- Oh boy powered() situation is a bit deranged
  * /obj/machinery/proc/power_change() handles NOPOWER flag nicely
    * ... and powered() isn’t to be used everywhere
  * But so many machinery codes to
  * Arghhh I will deal with this in a different PR
  * For now it’ll only be dealt with on process()
  * So this powered() will be is_operational()

* Simplifies meteor gamemode number

* Replaced lagacy with a shiny new comment

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #2962 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* fix (#3091)

* Automatic changelog generation for PR #3091 [ci skip]

* Automatic changelog compile [ci skip]

* Removes a duplicate Chair on Metastation. (#3093)

* Festivities are a go (#3094)

Co-authored-by: Naevii <60577525+Naevii@users.noreply.github.com>

Co-authored-by: Naevii <60577525+Naevii@users.noreply.github.com>

* Automatic changelog generation for PR #3094 [ci skip]

* Automatic changelog compile [ci skip]

* Nanotrasen no longer hires minors (#3100)

* Automatic changelog generation for PR #3100 [ci skip]

* Automatic changelog compile [ci skip]

* Adds a new roundend sound (#3088)

* Automatic changelog generation for PR #3088 [ci skip]

* Automatic changelog compile [ci skip]

* Nerfs bumpslams (#3101)

* Nerfs bumpslams

* Rearrange things

* microoptimize while I'm here

* Grant stunned players a reprieve

* Automatic changelog generation for PR #3101 [ci skip]

* Automatic changelog compile [ci skip]

* Update PDA_types.dm (#3096)

* Automatic changelog generation for PR #3096 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* cleans out some active turfs on the CC z level (#3105)

* clans out some active turfs

* I missed some!

* Automatic changelog generation for PR #3105 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes a var in the maps (#3118)

Co-authored-by: ike709 <sparebytes@protonmail.com>

* Automatic changelog compile [ci skip]

* Fastmos mapping improvements (#3006)

* sad

* more

* yes

* no_wallpipes

* wallpipes bad

* aaaa

* feex (#3007)

* Automatic changelog generation for PR #3006 [ci skip]

* Automatic changelog generation for PR #3007 [ci skip]

* Automatic changelog compile [ci skip]

* VV now actually shows icons (#3119)

* fuck

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* imcodr

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* fixes the captain getting midround traitor... lol (#3127)

Signed-off-by: Terra <terra@mcterra.id.au>

* Automatic changelog generation for PR #3127 [ci skip]

* More AT cleanup on CC and Lavaland Z Levels (#3112)

* clans out some active turfs

* I missed some!

* Cleans out lavaland ATs

* missed 3 turfs

* Automatic changelog compile [ci skip]

* Gives the top contributor a coder skirt (#3129)

* Gamer

* Almost fucked up

* Update code/modules/clothing/under/skirt_dress.dm

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3129 [ci skip]

* Automatic changelog compile [ci skip]

* Rejiggers hostile AI to only call oview once in ListTargets() (#3130)

* yeet (#3132)

* An attempt on fixing dynameme role protection (#3128)

* Revert #3127

This reverts commit b9f4c18.

* An attempt has been made to fix dynameme

* EOF

* Automatic changelog generation for PR #3132 [ci skip]

* Automatic changelog generation for PR #3128 [ci skip]

* Signed-off-by: Blue <Blueturbo47@gmail.com> (#3115)

Nya

* Improves self-harm message formatting. (#3126)

* added self harm message thing

* Update code/_onclick/item_attack.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: Isaac <qwertytrogi@gmail.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #3115 [ci skip]

* Automatic changelog generation for PR #3126 [ci skip]

* beaker contents announced (#3071)

* Automatic changelog generation for PR #3071 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes coderskirt (#3133)

* Update _job.dm

* Update _job.dm

* Update uniform.dmi

* Update uniform.dmi

* Update uniform.dmi

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3133 [ci skip]

* Fixes pipes until the game stops yelling at me (#3125)

* good (#3086)

* Automatic changelog generation for PR #3125 [ci skip]

* Automatic changelog generation for PR #3086 [ci skip]

* Add some simple logging to quantum spin inverter  (#3062)

* Add logging to swapper

* add archaniel's suggestion but tweaked slightly

* Automatic changelog generation for PR #3062 [ci skip]

* Automatic changelog compile [ci skip]

* Update regenerative.dm (#2986)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #2986 [ci skip]

* Station bounced radio QOL (#3010)

* radio

* fix

* fix

* speaker toggle is now on CtrlShiftClick

* bool

* fix

* Automatic changelog generation for PR #3010 [ci skip]

* Automatic changelog compile [ci skip]

* ike hates fun (#3137)

* Revert "Fixes coderskirt (#3133)"

This reverts commit f6e48f8.

* Revert "Gives the top contributor a coder skirt (#3129)"

This reverts commit 8de6734.

* Automatic changelog generation for PR #3137 [ci skip]

* Automatic changelog compile [ci skip]

* Mentor Follow go bye-bye (#3117)

* Non-Observing Mentors now don't see the Follow button

* axed

* e

* Automatic changelog generation for PR #3117 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Decal fixes: (#3111)

* Decal elements now generate appearance only one time
  * Decal elements are bespoke elements so we can do it
* Shuttle movements are now handled properly (w/ the simplest fix)
* Rotation of decals via rotate_react now works
* Item blood decals are reworked to work a bit more consistently
  * I am too lazy to fully rework update_icon() system
  * But temporary solution would be ridiculously hacky
  * So item blood decal fix is going to be delayed
  * I might work on reworking update_icon() for that

* Automatic changelog generation for PR #3111 [ci skip]

* Automatic changelog compile [ci skip]

* Auto stash before merge of "master" and "origin/master" (#2995)

* Automatic changelog generation for PR #2995 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* adds cookie's homemade rum, adds it to maint loot (#3141)

* [s]Fix inverted check where if permanent rank changes were disabled in the config, all rank changes would instead always go to the db, even bypassing DBRANK checks. (#3139)

* Automatic changelog generation for PR #3141 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Fix a hallucination runtime (#3148)

* Automatic changelog generation for PR #3148 [ci skip]

* Automatic changelog compile [ci skip]

* first (#3144)

* Automatic changelog generation for PR #3144 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* [PORT] Ports tgstation/tgstation#51453 real quick (#3149)

* Ports tgstation/tgstation#51453 real quick

* Fixes turf atmos getting deleted.

* Moves the gas transfer procs to the gas mixture.

* Fixes emp act to behave like before

* Fixes tanks exploding

* prevents pipenet related warnings

Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>

* Automatic changelog generation for PR #3149 [ci skip]

* Decreases non-traitor mime forcewall duration. Traitor mime forcewall is still very good. (#3067)

* Automatic changelog compile [ci skip]

* Fixes a damn CL change

gggg

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>

* fix (#3047)

* Automatic changelog generation for PR #3047 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* [Port] Ports the long-ranged atmos analyzer (#3054)

* ye

* gives the scanner to ce

* Automatic changelog generation for PR #3054 [ci skip]

* Automatic changelog compile [ci skip]

* yes (#3008)

* Automatic changelog generation for PR #3008 [ci skip]

* Automatic changelog compile [ci skip]

Co-authored-by: Victor <12621257+Victor239@users.noreply.github.com>
Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: ike709 <ike709@users.noreply.github.com>
Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>
Co-authored-by: LatteKat <56778689+jupyterkat@users.noreply.github.com>
Co-authored-by: MNarath <47279840+MNarath1@users.noreply.github.com>
Co-authored-by: Chadwick B. Dunlop <gwybrain@gmail.com>
Co-authored-by: Triiodinegb <garryrobinson@freemail.com>
Co-authored-by: Chessus <jamesseaniger@gmail.com>
Co-authored-by: Xenomedes <park246824@gmail.com>
Co-authored-by: EdgeLordExe <42111655+EdgeLordExe@users.noreply.github.com>
Co-authored-by: Gallyus <5572280+francinum@users.noreply.github.com>
Co-authored-by: TheFakeElon <millahoist7@gmail.com>
Co-authored-by: eeSPee <robotdevilinside@gmail.com>
Co-authored-by: SmArtKar <44720187+SmArtKar@users.noreply.github.com>
Co-authored-by: Isaac <qwertytrogi@gmail.com>
Co-authored-by: Cenrus <31044876+Cenrus@users.noreply.github.com>
Co-authored-by: LastCrusader105 <56616002+LastCrusader105@users.noreply.github.com>
Co-authored-by: Sinestia <40812746+Sinestia@users.noreply.github.com>
Co-authored-by: Alt_Alpha9 <52893488+Jakecantcode@users.noreply.github.com>
Co-authored-by: super12pl <67762796+super12pl@users.noreply.github.com>
Co-authored-by: bloons3 <bloons3@users.noreply.github.com>
Co-authored-by: TiviPlus <57223640+TiviPlus@users.noreply.github.com>
Co-authored-by: Unknown <epicmail709@yahoo.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: Emmett Gaines <ninjanomnom@gmail.com>
Co-authored-by: That0nePerson <63219222+That0nePerson@users.noreply.github.com>
Co-authored-by: Bilary <47011211+BeloneX@users.noreply.github.com>
Co-authored-by: Crossedfall <ping@crossedfall.io>
Co-authored-by: Naevii <60577525+Naevii@users.noreply.github.com>
Co-authored-by: Kmc2000 <bluekorben2000@yahoo.com>
Co-authored-by: Vasily2013 <43328793+Vasily2013@users.noreply.github.com>
Co-authored-by: ike709 <sparebytes@protonmail.com>
Co-authored-by: James <11001588+MCterra10@users.noreply.github.com>
Co-authored-by: Blueturbo47 <65003500+Blueturbo47@users.noreply.github.com>
Co-authored-by: Sinmero <38570414+Sinmero@users.noreply.github.com>
Co-authored-by: Kerbin-Fiber <corbinm70@gmail.com>
Co-authored-by: Isy232 <41198990+Isy232@users.noreply.github.com>
Co-authored-by: nemvar <47324920+nemvar@users.noreply.github.com>
kreeperHLC pushed a commit to kreeperHLC/BeeStation that referenced this pull request Jan 10, 2021
@Raven-Industries
More Detective Office ambience (#3271)
8040d0a 
* Update Space_Station_13_areas.dm

adds 2 new tracks for detectives office ambience

* Update license.txt

adds new tracks to licensing

* Add files via upload

adds 2 new detective ambience tracks

* Raven industries license fix (ChaoticOnyx#4)

* Detective Ambience addition (#1)

* Update Space_Station_13_areas.dm

adds 2 new tracks for detectives office ambience

* Update license.txt

adds new tracks to licensing

* Add files via upload

adds 2 new detective ambience tracks

* Update license.txt

licensing links

* Update license.txt

website screwery gives different people different license versions, who knew. Changed to 3.0 because I'm not dying on this hill.
MC-003B pushed a commit that referenced this pull request Jan 11, 2021
@kreeperHLC @ss13-beebot
@ike709 @PowerfulBacon @bloons3 @SomeAngryMiner @Blueturbo47 @qwertyquerty @That0nePerson @francinum @MNarath1 @jlsnow301 @stylemistake @Archanial @DatBoiTim @St0rmC4st3r @r1ks-iwnl @Victor239 @Crossedfall @Autisem @Sinestia @jupyterkat @cerebral-314 @park66665 @eeSPee @Ghilker @Kryyto @TheFakeElon @Isy232 @Cenrus @uomo91 @Raven-Industries @Naevii @MCHSL @Rohesie @LemonInTheDark @Chessus @Jakecantcode
New merge (#52)
e68b219 
* Automatic changelog compile [ci skip]

* Fixes players getting popcap redirected if they have a mob (#3174)

* How does this even happen?

* switcheroo

* God damn it

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #3174 [ci skip]

* Automatic changelog compile [ci skip]

* logging for binary chat (#3176)

* Automatic changelog generation for PR #3176 [ci skip]

* Automatic changelog compile [ci skip]

* [PORT] Limit how often you can use the emergency shuttle console (#3175)

* port TG shuttle cooldown

implements tgstation/tgstation@688406f

and

tgstation/tgstation@adec073

* removes redundant function calls

doesn't force re-open UI after timer-callback

Removes qdel check

* Update code/modules/shuttle/emergency.dm

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #3175 [ci skip]

* [READY] The great resprite: Suits! engineering ones. (#2677)

* Automatic changelog compile [ci skip]

* :) eat my face off conflicts

* how could i miss these

* i accidentally removed these

* Edits to gloves, new suits for redshirt lite and redshirt head honcho

* atmos man

* Conflictus begonus

* no stepping on other PR toes

* Oaagh

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>

* Automatic changelog compile [ci skip]

* Fixes the maint rooms stormcaster told me about (#3180)

* Automatic changelog generation for PR #3180 [ci skip]

* Automatic changelog compile [ci skip]

* Balance Power Usage (#3102)

* curve power balance

* autodoc

* mass driver

* recycler

* statis beds

* rechargers

* teleporter

* Automatic changelog generation for PR #3102 [ci skip]

* Automatic changelog compile [ci skip]

* Adds a keybind to zoom in for streamers (#3049)

* zoom in keybind

* fix linters

* 4x

* Automatic changelog generation for PR #3049 [ci skip]

* Automatic changelog compile [ci skip]

* fixes #3116 (#3142)

* fixes drying not transfering reagents

* clears reagents before copying them

* Automatic changelog generation for PR #3142 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* More armbands (#3187)

* Automatic changelog generation for PR #3187 [ci skip]

* Automatic changelog compile [ci skip]

* Alcoholic Quirk (#3140)

* adds alcoholic trait, adds 100u bottles of beer and ale

* fixes prob

* remove check_tick, didn't need it

* Automatic changelog generation for PR #3140 [ci skip]

* [Fix] makes firelocks constructable again (#3095)

* firelocks are now constructable again

* just a small change to heavies

this does not really change much but at least it will not break completly if someone tries to change something

* Automatic changelog generation for PR #3095 [ci skip]

* Automatic changelog compile [ci skip]

* Update burgerchat.dm (#3189)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3189 [ci skip]

* Automatic changelog compile [ci skip]

* Upgrade Vote Panel to TGUI (#2979)

* WIP

* Oops

* WIP, part 2

* Implement the backend

* Mostly working

Co-Authored-By: Aleksej Komarov <stylemistake@gmail.com>

* More Features

Co-Authored-By: Aleksej Komarov <stylemistake@gmail.com>

* Improved

* Linters

* Srsly

* notepad.exe

* Sorry linter man

* Brackets

* Some Parenthesis

* Again

* c

* Production Build

* Subtle canges

Co-Authored-By: Gallyus <5572280+francinum@users.noreply.github.com>

* Refactor

* Tgui panel

* Fixes

Co-Authored-By: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Tabled

Co-Authored-By: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Fixed 1's and 0's lol

Co-Authored-By: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: Gallyus <5572280+francinum@users.noreply.github.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>

* Automatic changelog generation for PR #2979 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* The garbage collector doesn't waste time anymore (#3190)

* Fixes syringe gun logging (#3191)

* zesko

* e

* Adds MultiTools to YouTool (#3195)

* Automatic changelog generation for PR #3195 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Fix Cult floor now actually atmos proof (#3123)

* atmospass check to no for cult floor

* incase this ever gets used on a multizlevel map

* partially reverts #2988

reverts the space ruin cult floor beeing atmos prof again

* Automatic changelog generation for PR #3123 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* because I am tired (#3079)

* New martial art, Tribal Claw (#3011)

* wip1

* wip1fix1

* wip2

* finished?

* defence checks

* brings absorb.dm back from the void

* Only lizards can use it now

* unga bunga

* replace tail knockdown with jugular cut

* Tail Grab mute, flavor text warning, 14 TC cost

* Update tribal_claw.dm

* E

ignore runtime being enabled gonna disable it later

* EE

* better jugular cut

* sanity

* runtime moment

* Turns out the space dragon repulse makes you spin anyway

* Adds the old gas mask back. (#3184)

* pain

* e

* Security cyborgs must be researched first (#3106)

* Automatic changelog generation for PR #3011 [ci skip]

* Automatic changelog generation for PR #3079 [ci skip]

* Automatic changelog generation for PR #3184 [ci skip]

* Automatic changelog generation for PR #3106 [ci skip]

* Automatic changelog compile [ci skip]

* [FIX] Ranged Analyzer now in technode and buildable (#3213)

* addtotechnode

* ooops

* Automatic changelog generation for PR #3213 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* [Port] tgui: Refactor Asset Delivery (#3220)

* tgui: Refactor Asset Delivery (#54895)

* tgui: Refactor Asset Delivery

* Re-enable printing of initial backend update payload

* Fix oopsie woopsie hotkey, tgui.html syntax and ntos flavor

(cherry picked from commit 5b382799b9d4f1829165ec61bf46c2db10fd715f)

* Recompile TGUI

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>

* Automatic changelog generation for PR #3220 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* sets blood level to normal on cast (#3230)

* Automatic changelog generation for PR #3230 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* AI icons form a straight line now on 17x15 instead of being weird (#3235)

* AI icons form a straight line now on 17x15 instead of being weird

* lang

* Automatic changelog generation for PR #3235 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Fastsplosions III: Revenge of the Maxcaps (#2874)

* first commit

* fixed some stuff... it compiles now

* I fixed this I swear

* Dream Maker is gaslighting me

* Build you foul demon!

* fixed some runtimes

* e

* moved the runtime check

* blame extools

* fixed spacevines friendly firing

* fixed some more really obnoxious runtimes

* more fixed runtimes

* wrong bandaid

* PowerfulBacon's requested changes

* NO MORE RUNTIMES

* yo dawg... i heard you like runtimes.

so i put some runtimes in your runtimes.

* sounds be good to go now

* Fixed a bug and added nuke crater

* Update _compile_options.dm

* lowered priority

* tickfix

* throwing fix

* funni

* comments

* bad args

* useless arg

* make creak work again

* no spacecreaks

* remove nuke crater for less freezing

* fix doppler arrays, make explosions register a signal

* edgecase

* fix

* fix

* fix

* damn

* morgue runtime

* fix explosions not working on tiles

* things

* fixes

* ided

* hm

* e

* unnecessary check

* Update code/modules/atmospherics/machinery/components/components_base.dm

Co-authored-by: Xenomedes <park246824@gmail.com>

* yes

Co-authored-by: cerebrallolzy <55196334+cerebrallolzy@users.noreply.github.com>
Co-authored-by: LatteKat <56778689+totallynotkatfood@users.noreply.github.com>
Co-authored-by: Xenomedes <park246824@gmail.com>

* Automatic changelog generation for PR #2874 [ci skip]

* Automatic changelog compile [ci skip]

* not any tipe of gaia work (#3236)

* Abductors get Agent IDs (#3234)

* Abductor id

* Lil text change

* Update abduction_outfits.dm

* Automatic changelog generation for PR #3236 [ci skip]

* Adds Syndie MMI as Standalone Option for Roboticists and RD (#3233)

* Adds Syndie MMI as Wholesale

* Adjusts value of Syndie MMI and MMI kit

* Revert "Adjusts value of Syndie MMI and MMI kit"

This reverts commit 34eea889d40c24a9f58e86204eecf05233a361ce.

* 34eea889d4 but I Stashed the Changes to the Correct Branch

* Automatic changelog generation for PR #3234 [ci skip]

* Advanced Health Analyzer is actually advanced now (#3243)

* real belone pr hours

* Update scanners.dm

* Automatic changelog generation for PR #3233 [ci skip]

* Update meteor_wave.dm (#3223)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3243 [ci skip]

* Automatic changelog generation for PR #3223 [ci skip]

* [FIX] Window Firelock now drops reinforced glass (#3218)

* fix

* oops yet again

forgot to delete original message

* Adds cartons of soy milk to biogenerator (#3224)

* I wont suck at git

* remove whitespace

* aaaa

* Update code/modules/research/designs/biogenerator_designs.dm

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #3218 [ci skip]

* Automatic changelog generation for PR #3224 [ci skip]

* Update actions.dm (#3212)

* Automatic changelog generation for PR #3212 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes combat stimulant injector causing nukies to drop weapons. (#3197)

* fix

* actually jitter would still be funny

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3197 [ci skip]

* Freezers/Heaters now switch by an UI button without deconstructing it (#3172)

* yes

Co-Authored-By: Ghilker <42839747+Ghilker@users.noreply.github.com>

* mapstuff

* rebuild tgui

Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>

* Corgium improvements (#3177)

* Corgium

* just in case

* Update code/__DEFINES/traits.dm

* Update code/modules/reagents/chemistry/reagents/other_reagents.dm

* Update code/modules/reagents/chemistry/reagents/other_reagents.dm

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3177 [ci skip]

* asf (#3163)

Co-authored-by: PowerfulBacon <>

* Update job.dm (#3162)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3163 [ci skip]

* Automatic changelog generation for PR #3162 [ci skip]

* a (#3138)

Co-authored-by: PowerfulBacon <>

* Cleanup of our worst namelist (#3084)

* Automatic changelog generation for PR #3138 [ci skip]

* Automatic changelog compile [ci skip]

* Update supersoldier.dm (#3246)

* Automatic changelog generation for PR #3246 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Removes the ability to build walls in CTF (#3245)

* Update others.dm (#3249)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3245 [ci skip]

* Automatic changelog generation for PR #3249 [ci skip]

* vomit no longer hardstuns (#3211)

* Minor Cult Buffs (#3158)

* Cult buffs

* Update cult_comms.dm

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3211 [ci skip]

* Update holidays.dm (#3248)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3158 [ci skip]

* Some beecoin items now actually function. (#3219)

* Gear items now use an ID

* Savefile version bump and purchase fixer.

* Automatic changelog generation for PR #3248 [ci skip]

* Automatic changelog generation for PR #3219 [ci skip]

* Automatic changelog compile [ci skip]

* Fixes the 4th character slot (#3254)

Co-authored-by: Crossedfall <ping@crossedfall.io>

* Automatic changelog generation for PR #3254 [ci skip]

* Automatic changelog compile [ci skip]

* Update observer.dm (#3256)

* Automatic changelog generation for PR #3256 [ci skip]

* Automatic changelog compile [ci skip]

* autodoc is gone (#3258)

* Automatic changelog generation for PR #3258 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Automatic TGS DMAPI Update (#3260)

* The spawned AI subtype now actually works. (#3263)

* Input checking (#3170)

* Input Validation

* Update saved_circuits.dm

* Update saved_circuits.dm

* Update saved_circuits.dm

* Update saved_circuits.dm

* Adds characters that are needed

* Actually just filter them

* Update saved_circuits.dm

* Update saved_circuits.dm

* byond is such a pain in the dick sometimes

* good fucking god I am stupid

* Ike's review

* pretend that didn't happen plz

* here we are

* discovering how replace works be like

Co-authored-by: PowerfulBacon <>

* Automatic changelog compile [ci skip]

* Another attempt on dynamic ruleset role protection bugfix (#3268)

* Configures Rulesets on forced rulesets

* Further configure_ruleset enhancements

* Automatic changelog generation for PR #3268 [ci skip]

* Automatic changelog compile [ci skip]

* bruh (#3276)

* Automatic changelog generation for PR #3276 [ci skip]

* Automatic changelog compile [ci skip]

* Force map json (Mapping Testmerge Helper) (#3277)

* based

* Update admin_verbs.dm

Co-authored-by: PowerfulBacon <>

* Automatic changelog compile [ci skip]

* persistent renaming log (#3283)

* Automatic changelog generation for PR #3283 [ci skip]

* Automatic changelog compile [ci skip]

* Update uplink_items.dm (#3287)

* Automatic changelog generation for PR #3287 [ci skip]

* Automatic changelog compile [ci skip]

* Bugfix for: #3106. Secborg modules boards are unlocked by research properly (#3272)

* Seborg Module Exists

* No Redundant Pre-Reqs

* Puts Back in MechFab

* Update code/modules/research/techweb/all_nodes.dm

Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>

* Update code/modules/research/techweb/all_nodes.dm

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Update code/modules/research/techweb/all_nodes.dm

English go BRRRRRR

Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Fuck it this is gonna be a bugfix. I can nerf it in another PR

* Spelling go BRRRRRR

Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>
Co-authored-by: ike709 <ike709@users.noreply.github.com>

* Automatic changelog generation for PR #3272 [ci skip]

* Automatic changelog compile [ci skip]

* Moves player list out of status topic (#3270)

* Moves player list out of status topic

* Fix formatting

* Automatic changelog generation for PR #3270 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Random Pill bottle colors (#3274)

* Random Pill bottle colors

* Update Init

* fix 2

* Automatic changelog generation for PR #3274 [ci skip]

* a (#3291)

Co-authored-by: PowerfulBacon <>

* Automatic changelog compile [ci skip]

* adds tiny fans to the raven shuttle (#3267)

* adds note to ex-communicate (#3282)

* Automatic changelog generation for PR #3267 [ci skip]

* Automatic changelog generation for PR #3282 [ci skip]

* A Radiation Math Rework (read: contamination nerf) (#3294)

* Implements realistic radiation

* Now radiation wave is singular and atomizing
* Radiation insulation therefore is realistic
* Preservation of radiation
  * No more radiation ex nihilo
  * Nerfs contamination by a lot
  * Contamination stacks
  * the reason: tgstation/tgstation#42572
  * Untested but I already can feel its awfulness

* Raycasting, but not raycasting...

* Things are finally working; includes many fixes

* Final revision before another rework

* Selective Raycasting
* should boost performance when most rays are dead
* otherwise it is more robust in general
* maybe a tiny bit slower
* completely untested roflmao
* ridiculously bad code imho

* Misc changes and fixes

* un-inverted L and R

* All the fixes plus choicetracking

* Debug lines commit

* Changes needed to emulate pre-rework behaviors

* refines-the-defines

* increased contamination budget

* initial dictionary refactor plus debug lines

* Better terminology

* terminology

* dictionary fixes

* Better and more correct definition

* Actual Dictionary Fixes

* Trying to overclock the radiation subsystem

* The Status Quo

* Status Quo 2: Electric Boogaloo

* Cleanup for PR

* Another cleanup

* More math

* Expands Christmas comment

* We need a simpler math

* Blame contamination math

* Change of my mind

* Another change of mind

* plural

* Another cleanup

* Automatic changelog generation for PR #3294 [ci skip]

* ambience starlight (#3297)

* Automatic changelog generation for PR #3297 [ci skip]

* Makes "inverseDir" a global proc (#3298)

* beepboop

* Update code/__HELPERS/unsorted.dm

Co-authored-by: Gallyus <5572280+francinum@users.noreply.github.com>

* z dir flipping

* boop

* indent moment

Co-authored-by: Gallyus <5572280+francinum@users.noreply.github.com>

* Automatic changelog generation for PR #3298 [ci skip]

* It's no longer spessmess (#3303)

* Automatic changelog generation for PR #3303 [ci skip]

* Automatic changelog compile [ci skip]

* Improves extools detection for linux (#3296)

* Automatic changelog generation for PR #3296 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Massive crate cost rebalance and fixed multiple cargo money exploits. (#2981)

* Automatic changelog generation for PR #2981 [ci skip]

* Automatic changelog compile [ci skip]

* make very very stronk (#3308)

Co-authored-by: Sinestia <lul>

* Automatic changelog generation for PR #3308 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* fixes ipc and squid mut toxin recipes (#3284)

* Automatic changelog generation for PR #3284 [ci skip]

* Fix constructs not invoking runes (#3302)

* Automatic changelog compile [ci skip]

* HOO

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>

* Adds logging for chemical smoke (#3286)

* adds logging for chemical smoke

* changes smoke logging to log_attack()

* Automatic changelog generation for PR #3286 [ci skip]

* Adds missing jobs to sages jobs.txt (#3266)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3266 [ci skip]

* Automatic changelog compile [ci skip]

* prevent morph from impersonating camera eyes (#3314)

* Automatic changelog generation for PR #3314 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Port. (#3290)

* Automatic changelog generation for PR #3290 [ci skip]

* Automatic changelog compile [ci skip]

* Removes mob_has_gravity() (#3323)

* Removes mob_has_gravity
* it appears to incur significant overhead
  * I still have no idea why
* I also don't know why it didn't break already

* Removes redundant check

* It turns out, space is not dense

* Some additional changes

* Automatic changelog generation for PR #3323 [ci skip]

* Automatic changelog compile [ci skip]

* More Detective Office ambience (#3271)

* Update Space_Station_13_areas.dm

adds 2 new tracks for detectives office ambience

* Update license.txt

adds new tracks to licensing

* Add files via upload

adds 2 new detective ambience tracks

* Raven industries license fix (#4)

* Detective Ambience addition (#1)

* Update Space_Station_13_areas.dm

adds 2 new tracks for detectives office ambience

* Update license.txt

adds new tracks to licensing

* Add files via upload

adds 2 new detective ambience tracks

* Update license.txt

licensing links

* Update license.txt

website screwery gives different people different license versions, who knew. Changed to 3.0 because I'm not dying on this hill.

* Automatic changelog generation for PR #3271 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip] (#3327)

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>

* [FIX] weapon circuit logging (#3321)

* weapon_circuit attack_log logging

* just includes the circuit name and that its a circuit in the log

* includes the ref name of circuit too

Includes the ref name of the circuit to allow admins to keep tack of who printed it  trough the circuit log and the attack log even if the name was changed

* Automatic changelog generation for PR #3321 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* CE and CMO cloak sprite updated. (#2964)

* Automatic changelog generation for PR #2964 [ci skip]

* Automatic changelog compile [ci skip]

* Update boh_tear.dm (#3324)

Co-authored-by: PowerfulBacon <>

* Automatic changelog generation for PR #3324 [ci skip]

* add tiny fan (#3310)

Co-authored-by: Sinestia <lul>

* Automatic changelog generation for PR #3310 [ci skip]

* Automatic changelog compile [ci skip]

* [PORT] Extools ref tracking frontend from TG and and improvements (#3108)

* Ports tgstation/tgstation#51467 real quick

Comment from the original commit follows:

About The Pull Request

Adds extools-powered reference tracking. Includes a couple procs that retrieve the back and forward references of a datum - Back references let you see what is referencing your object and potentially preventing it from garbage collecting, and forward ones show you what your object in turn references. Also made a cool GUI to inspect and follow these references.

The tracking adds some overhead to all variable sets and list operations. Init time is increased by ~15%. I haven't actually benched it so it might impact the actual game less.
Why It's Good For The Game

no lagging caused by hard dels scanning the entire planet (once coders fix them)

* Ports tgstation/tgstation#52403 real quick

Comment from the original commit follows:

* ref tracking

* legacy

* legacy procs

* fixes

* tweaks

* clarity comments

* wth

* Proactive use of ifdef

* Ports tgstation/tgstation#52237 real quick

Comment from the original commit follows:

* hard del

* runtime

* more throw_impact possible qdeleting

* merge solving

* Stops thrower being passed twice

* fixes a compile error in reference tracking verbs caused by an improper versioning change (#54877)

Co-authored-by: MCHSL <56649176+MCHSL@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>

* Cleans up a common mob helper proc (#3328)

* Automatic changelog generation for PR #3328 [ci skip]

* Automatic changelog generation for PR #3108 [ci skip]

* Pet Beacons (#3293)

* pet beacons

* oops

* Update miscellaneous.dm

* Automatic changelog generation for PR #3293 [ci skip]

* Automatic changelog compile [ci skip]

* Optimize your codebase with one easy trick (#3338)

* Automatic changelog generation for PR #3338 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Update SuperBeepsky.dm (#3333)

gives nullcrate griefsky a faction to prevent it from being targeted by syndicate faction

* Automatic changelog generation for PR #3333 [ci skip]

* Automatic changelog compile [ci skip]

* Moves smoke logging to mob logs (#3339)

* moves smoke logging to mob logs

* do ike's change

* Apply suggestions from code review


Co-authored-by: ike709 <ike709@users.noreply.github.com>
Co-authored-by: Xenomedes <park246824@gmail.com>

* Automatic changelog generation for PR #3339 [ci skip]

* Automatic changelog compile [ci skip]

* Update lighting_source.dm (#3351)

* adds garbage day (#3080)

* Automatic changelog generation for PR #3080 [ci skip]

* Automatic changelog compile [ci skip]

* Automatic changelog compile [ci skip]

* Update miscellaneous.dm (#3352)

(Triple checked by a maintainer)

* Automatic changelog generation for PR #3352 [ci skip]

* Automatic changelog compile [ci skip]

* fix tgui

* Final fix tgui

Co-authored-by: ss13-beebot <56381746+ss13-beebot@users.noreply.github.com>
Co-authored-by: ike709 <ike709@users.noreply.github.com>
Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: bloons3 <bloons3@users.noreply.github.com>
Co-authored-by: SomeAngryMiner <53237389+SomeAngryMiner@users.noreply.github.com>
Co-authored-by: Blueturbo47 <65003500+Blueturbo47@users.noreply.github.com>
Co-authored-by: Isaac <qwertytrogi@gmail.com>
Co-authored-by: That0nePerson <63219222+That0nePerson@users.noreply.github.com>
Co-authored-by: Gallyus <5572280+francinum@users.noreply.github.com>
Co-authored-by: MNarath <47279840+MNarath1@users.noreply.github.com>
Co-authored-by: Jeremiah <42397676+jlsnow301@users.noreply.github.com>
Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Co-authored-by: Archanial <37456678+Archanial@users.noreply.github.com>
Co-authored-by: DatBoiTim <68963748+DatBoiTim@users.noreply.github.com>
Co-authored-by: St0rmC4st3r <34888552+St0rmC4st3r@users.noreply.github.com>
Co-authored-by: r1ks-iwnl <69760936+r1ks-iwnl@users.noreply.github.com>
Co-authored-by: Victor <12621257+Victor239@users.noreply.github.com>
Co-authored-by: Crossedfall <ping@crossedfall.io>
Co-authored-by: Autisem <36102060+Autisem@users.noreply.github.com>
Co-authored-by: Sinestia <40812746+Sinestia@users.noreply.github.com>
Co-authored-by: LatteKat <56778689+jupyterkat@users.noreply.github.com>
Co-authored-by: cerebrallolzy <55196334+cerebrallolzy@users.noreply.github.com>
Co-authored-by: LatteKat <56778689+totallynotkatfood@users.noreply.github.com>
Co-authored-by: Xenomedes <park246824@gmail.com>
Co-authored-by: eeSPee <robotdevilinside@gmail.com>
Co-authored-by: Ghilker <42839747+Ghilker@users.noreply.github.com>
Co-authored-by: Kryyto <69859497+Kryyto@users.noreply.github.com>
Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>
Co-authored-by: Isy232 <41198990+Isy232@users.noreply.github.com>
Co-authored-by: Cenrus <31044876+Cenrus@users.noreply.github.com>
Co-authored-by: uomo <51800976+uomo91@users.noreply.github.com>
Co-authored-by: Raven-Industries <76715855+Raven-Industries@users.noreply.github.com>
Co-authored-by: Naevii <60577525+Naevii@users.noreply.github.com>
Co-authored-by: MCHSL <56649176+MCHSL@users.noreply.github.com>
Co-authored-by: Rohesie <rohesie@gmail.com>
Co-authored-by: LemonInTheDark <58055496+LemonInTheDark@users.noreply.github.com>
Co-authored-by: Chessus <jamesseaniger@gmail.com>
Co-authored-by: Alt_Alpha9 <52893488+Jakecantcode@users.noreply.github.com>
kreeperHLC pushed a commit that referenced this pull request Feb 20, 2021
@ro5490 @PowerfulBacon
@That0nePerson @TheFakeElon @park66665
Oozelings - No Augments, Constantly Clean, Fleshmend Fix, Medibox Fix…
a7cb18a 
…, Changeling Panacea Fix, Food Buff, Spellcheck fix, Rust Heretic fix (#3483)

* No Augments, Constantly Clean, Fleshmend Fix (#4)

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: That0nePerson <63219222+That0nePerson@users.noreply.github.com>
Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>
Co-authored-by: Xenomedes <park246824@gmail.com>

* Fixes and Spellchecks, plus food buff

* slight optimization

* oops

* Update code/modules/surgery/limb_augmentation.dm

Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>

* Patches rust_regen to heal oozelings

* Update code/modules/surgery/limb_augmentation.dm

Co-authored-by: Xenomedes <park246824@gmail.com>

* Balance Adjustement for Nutrition Blood Regen

* Changes IfOozeling on ToxHeal to Force=TRUE

Co-authored-by: PowerfulBacon <26465327+PowerfulBacon@users.noreply.github.com>
Co-authored-by: That0nePerson <63219222+That0nePerson@users.noreply.github.com>
Co-authored-by: TheFakeElon <59686430+TheFakeElon@users.noreply.github.com>
Co-authored-by: Xenomedes <park246824@gmail.com>
kreeperHLC pushed a commit that referenced this pull request Aug 17, 2021
@Sinestia @stylemistake
Juke Build Reforged (#4861)
261160d 
* # This is a combination of 7 commits.
# This is the 1st commit message:

Revert "z"

This reverts commit 3c2b584aa7803965e56be472463a508ff1f90932.

# This is the commit message #2:

Revert "jesus im dum"

This reverts commit 079e7c6b3bb9e4b6bad58d663a804011cd1cebb0.

# This is the commit message #3:

text

# This is the commit message #4:

Revert "ccc"

This reverts commit e7ef0248502f0abeb68749abc73440494b52b9f0.

# This is the commit message #5:

Revert "prec1s"

This reverts commit e217e183d551bdf3e5130c644590b59ec7b36882.

# This is the commit message #6:

Revert "reverttoclassic"

This reverts commit 591e333742d9507bd86e741fefe055120886a395.

# This is the commit message #7:

Revert "v"

This reverts commit bbd3c05ae182bfbb934899aabc25eb93b490bcda.

* Readds the old CBT

* Juke Build (#59390)

* Juke Build Hotfix 1 (#59643)

* Juke Build Fix

* More fixes

* Juke Build Hotfix 2 - PreCompile script compatibility (#59649)

* Juke Build Hotfix 2 - PreCompile script compatibility

* Pass arguments from bat to build.js

* Pass arguments in BUILD.bat as well

* Quick tweak

* Juke Build 0.4.0 (#59796)

Updated Juke Build to version 0.4.0
Main new feature: dependsOn, inputs, outputs, and onlyWhen fields now all accept a function of format ({ get }) => ..., and all of them can be async. This means that you can easily parametrize every part of the build.
Added references to Juke Build to README in the build folder

* Stop compiling DM if compiler outputs are locked. (#60022)

Basically, saves developer's time by yelling that the compiler can't write to dmb/rsc, because they are locked by Dream Daemon.

Added myself as a code owner for /tools/build.

* Spring Cleaning

* Adapt CI to work with this.

* Update continuous_integration, no more ENV:

* merge mistake

* Clear out dist

A mistake made when removing CBT from the old PR, this folder was meant to be untracked and became tracked.

* Docker experiment. Not done. Too lazy to stash

Sorry ~

* Possibly temporary use of tgstation's docker image

* Actually grab auxmos btw, bee's dockerfile doesn't

* Quickfix for Linux Auxtools

Co-authored-by: Aleksej Komarov <stylemistake@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xmaebx @MC-003B